fix(slashing-protection): resolve minEpoch max call stack issue
#5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
commented
May 4, 2023
| @@ -28,7 +28,7 @@ export function numToString(num: number): string { | |||
| } | |||
|
|
|||
| export function minEpoch(epochs: Epoch[]): Epoch | null { | |||
| return epochs.length > 0 ? Math.min(...epochs) : null; | |||
| return epochs.length > 0 ? epochs.reduce((minEpoch, epoch) => (minEpoch < epoch ? minEpoch : epoch)) : null; | |||
There was a problem hiding this comment.
alternative implementation
export function minEpoch(epochs: Epoch[]): Epoch | null {
if (epochs.length === 0) {
return null;
}
let minEpoch = epochs[0];
for (let i = 1; i < epochs.length; i++) {
if (epochs[i] < minEpoch) {
minEpoch = epochs[i];
}
}
return minEpoch;
}but there is no noticeable difference in performance
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
force-pushed
the
nflaig/fix-minEpoch-rangeError
branch
3 times, most recently
from
b532921
to
e693095
Compare
Epochs array might have more than ~10^5 elements, cannot use `Math.min` as it would throw `RangeError: Maximum call stack size exceeded`.
nflaig
force-pushed
the
nflaig/fix-minEpoch-rangeError
branch
from
e693095
to
cd6513e
Compare
nflaig
changed the title
minEpoch max call stack issue
dapplion
approved these changes
May 4, 2023
|
🎉 This PR is included in v1.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5392
Description
Epochs array might have more than ~10^5 elements, cannot use
Math.minas it would throwRangeError: Maximum call stack size exceededifepochs.length >= 125626.This change makes the solution to determine min epoch more robust and adds few unit tests.