New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track gossip block errors in metrics #5481

Closed

twoeths opened this issue May 12, 2023 · 0 comments · Fixed by #5495

Assignees

Labels

prio-high scope-metrics

Contributor

twoeths commented May 12, 2023

Is your feature request related to a problem? Please describe.

There are some invalid signature blocks on mainnet, we do log errors and store them to disk but missed metrics https://beaconcha.in/slot/6417765

Describe the solution you'd like

Add metrics with reason code to

lodestar/packages/beacon-node/src/network/processor/gossipHandlers.ts

Line 171 in f16192f

logger.error("Error receiving block", {slot: signedBlock.message.slot, peer: peerIdStr}, e as Error);
Use this metric group

lodestar/packages/beacon-node/src/metrics/metrics/lodestar.ts

Line 463 in f16192f

gossipBlock: {
Add respective panels to our dashboard

philknows added scope-metrics prio-high labels

matthewkeil mentioned this issue

feat(beacon-node): add block error metric to gossip handlers #5495

Merged

twoeths assigned matthewkeil

twoeths closed this as completed in #5495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment