feat(beacon-node): add block error metric to gossip handlers #5495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
suggested changes
May 16, 2023
|
@dapplion I have the changes loaded to |
|
@matthewkeil can you post a screen capture of how the metrics dashboard looks like? |
|
😂 |
|
I did a bit of digging and there weren't any 
|
|
Should I add a panel for the other |
twoeths
approved these changes
May 18, 2023
twoeths
reviewed
May 18, 2023
twoeths
requested changes
May 18, 2023
|
There we go!!! Starting to get the hang of prom/grafana. @tuyennhv does that look better? 
|
twoeths
reviewed
May 19, 2023
dashboards/lodestar_networking.json
Outdated
| "uid": "${DS_PROMETHEUS}" | ||
| }, | ||
| "editorMode": "code", | ||
| "expr": "rate(lodestar_gossip_block_process_block_errors{}[$rate_interval]) * 12", |
twoeths
reviewed
May 19, 2023
dashboards/lodestar_networking.json
Outdated
| }, | ||
| "editorMode": "code", | ||
| "expr": "rate(lodestar_gossip_block_process_block_errors{}[$rate_interval]) * 12", | ||
| "legendFormat": "{{blockErrorCode}}", |
There was a problem hiding this comment.
@matthewkeil legendFormat should be the label in your metric
Suggested change
| "legendFormat": "{{blockErrorCode}}", | |
| "legendFormat": "{{error}}", |
|
@matthewkeil the grafana panel in this PR was merged to |
matthewkeil
force-pushed
the
mkeil/gossip-block-error-metrics
branch
from
6fb57c0
to
448c0de
Compare
@tuyennhv this is updated. I noticed that the panel still had the old title before it captured all of the errors so i update that to remove the "Unknown Parent" part. I had a bit of trouble with the rebase and needed to cherry pick the commits and force push to get things corrected. Please double check that the changes look ok. |
This reverts commit 56844f5.
twoeths
approved these changes
May 25, 2023
|
🎉 This PR is included in v1.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is related to #5481 and captures gossip block error metrics and adds them to a new dashboard. Will help to debug poorly gossiped blocks by peers by exposing the slot, peerId, time seen and error that was raised.
Description
Closes #5481