Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB buckets have duplicate keys #5753

Closed
nazarhussain opened this issue Jul 12, 2023 · 1 comment · Fixed by #5849
Closed

DB buckets have duplicate keys #5753

nazarhussain opened this issue Jul 12, 2023 · 1 comment · Fixed by #5849
Labels
meta-bug Issues that identify a bug and require a fix. prio-high Resolve issues as soon as possible.
Milestone

Comments

@nazarhussain
Copy link
Contributor

nazarhussain commented Jul 12, 2023

Describe the bug

There are duplicate keys assigned to db buckets which could lead to unintended behavior.

Expected behavior

There should not be a key used twice for any bucket. Unless specified with a good reason.

Steps to reproduce

allForks_blobsSidecarArchive = 30, // DENEB BeaconBlockSlot -> BlobsSidecar

phase0_preGenesisState = 30, // Single = phase0.BeaconState

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

1.9.x

@nazarhussain nazarhussain changed the title Db buckets have duplicate keys DB buckets have duplicate keys Jul 12, 2023
@philknows philknows added the meta-bug Issues that identify a bug and require a fix. label Jul 20, 2023
@dapplion
Copy link
Contributor

There must exist a unit test ensuring no duplication, I'm impressed typescript allows this lol

Collusion of db buckets will brick Lodestar, here we are lucky that networks with blobs (devnets only currently) never compute a genesis state. Must be fixed and ensure to never happen again

@dapplion dapplion added the prio-high Resolve issues as soon as possible. label Jul 20, 2023
@philknows philknows added this to the v1.11.0 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix. prio-high Resolve issues as soon as possible.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants