Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure bn Buckets are sorted and unique #5849

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Aug 4, 2023

Motivation

De-duplicate beacon node DB buckets

Description

Change allForks_blobsSidecarArchive from 30 to 32, with the expectation of being deprecated soon.

CC @g11tech

Closes #5753

@dapplion dapplion requested a review from a team as a code owner August 4, 2023 15:48
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 80902ed Previous: 9034831 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 615.17 us/op 729.99 us/op 0.84
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 74.291 us/op 74.022 us/op 1.00
BLS verify - blst-native 1.2081 ms/op 1.1992 ms/op 1.01
BLS verifyMultipleSignatures 3 - blst-native 2.4644 ms/op 2.4392 ms/op 1.01
BLS verifyMultipleSignatures 8 - blst-native 5.2925 ms/op 5.2469 ms/op 1.01
BLS verifyMultipleSignatures 32 - blst-native 19.110 ms/op 18.869 ms/op 1.01
BLS aggregatePubkeys 32 - blst-native 25.496 us/op 24.990 us/op 1.02
BLS aggregatePubkeys 128 - blst-native 99.882 us/op 98.010 us/op 1.02
getAttestationsForBlock 56.954 ms/op 49.974 ms/op 1.14
isKnown best case - 1 super set check 369.00 ns/op 285.00 ns/op 1.29
isKnown normal case - 2 super set checks 300.00 ns/op 270.00 ns/op 1.11
isKnown worse case - 16 super set checks 280.00 ns/op 281.00 ns/op 1.00
CheckpointStateCache - add get delete 4.8700 us/op 4.8170 us/op 1.01
validate api signedAggregateAndProof - struct 2.8226 ms/op 2.7330 ms/op 1.03
validate gossip signedAggregateAndProof - struct 2.8058 ms/op 2.7348 ms/op 1.03
validate api attestation - struct 1.3490 ms/op 1.3175 ms/op 1.02
validate gossip attestation - struct 1.3539 ms/op 1.3435 ms/op 1.01
pickEth1Vote - no votes 1.2267 ms/op 1.1187 ms/op 1.10
pickEth1Vote - max votes 11.074 ms/op 7.6997 ms/op 1.44
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.1761 ms/op 8.2416 ms/op 1.11
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 16.084 ms/op 13.370 ms/op 1.20
pickEth1Vote - Eth1Data fastSerialize value x2048 582.10 us/op 557.86 us/op 1.04
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.0557 ms/op 6.2537 ms/op 1.13
bytes32 toHexString 562.00 ns/op 493.00 ns/op 1.14
bytes32 Buffer.toString(hex) 334.00 ns/op 294.00 ns/op 1.14
bytes32 Buffer.toString(hex) from Uint8Array 486.00 ns/op 407.00 ns/op 1.19
bytes32 Buffer.toString(hex) + 0x 330.00 ns/op 288.00 ns/op 1.15
Object access 1 prop 0.19300 ns/op 0.16000 ns/op 1.21
Map access 1 prop 0.15600 ns/op 0.14300 ns/op 1.09
Object get x1000 7.9910 ns/op 7.2850 ns/op 1.10
Map get x1000 0.72600 ns/op 0.48900 ns/op 1.48
Object set x1000 54.687 ns/op 46.341 ns/op 1.18
Map set x1000 40.493 ns/op 38.677 ns/op 1.05
Return object 10000 times 0.25040 ns/op 0.22790 ns/op 1.10
Throw Error 10000 times 3.9208 us/op 3.7014 us/op 1.06
fastMsgIdFn sha256 / 200 bytes 3.3830 us/op 3.1440 us/op 1.08
fastMsgIdFn h32 xxhash / 200 bytes 308.00 ns/op 270.00 ns/op 1.14
fastMsgIdFn h64 xxhash / 200 bytes 363.00 ns/op 331.00 ns/op 1.10
fastMsgIdFn sha256 / 1000 bytes 11.607 us/op 10.861 us/op 1.07
fastMsgIdFn h32 xxhash / 1000 bytes 459.00 ns/op 398.00 ns/op 1.15
fastMsgIdFn h64 xxhash / 1000 bytes 436.00 ns/op 391.00 ns/op 1.12
fastMsgIdFn sha256 / 10000 bytes 106.76 us/op 98.063 us/op 1.09
fastMsgIdFn h32 xxhash / 10000 bytes 1.9510 us/op 1.9130 us/op 1.02
fastMsgIdFn h64 xxhash / 10000 bytes 1.3410 us/op 1.3190 us/op 1.02
enrSubnets - fastDeserialize 64 bits 1.3610 us/op 1.2570 us/op 1.08
enrSubnets - ssz BitVector 64 bits 487.00 ns/op 427.00 ns/op 1.14
enrSubnets - fastDeserialize 4 bits 210.00 ns/op 187.00 ns/op 1.12
enrSubnets - ssz BitVector 4 bits 491.00 ns/op 438.00 ns/op 1.12
prioritizePeers score -10:0 att 32-0.1 sync 2-0 117.93 us/op 109.70 us/op 1.07
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 138.78 us/op 132.96 us/op 1.04
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 173.77 us/op 170.19 us/op 1.02
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 316.50 us/op 287.10 us/op 1.10
prioritizePeers score 0:0 att 64-1 sync 4-1 369.98 us/op 329.80 us/op 1.12
array of 16000 items push then shift 1.6195 us/op 1.5778 us/op 1.03
LinkedList of 16000 items push then shift 9.1440 ns/op 8.8850 ns/op 1.03
array of 16000 items push then pop 60.959 ns/op 57.759 ns/op 1.06
LinkedList of 16000 items push then pop 9.0320 ns/op 8.6390 ns/op 1.05
array of 24000 items push then shift 2.4217 us/op 2.4134 us/op 1.00
LinkedList of 24000 items push then shift 9.0850 ns/op 8.8530 ns/op 1.03
array of 24000 items push then pop 115.99 ns/op 108.99 ns/op 1.06
LinkedList of 24000 items push then pop 8.7400 ns/op 8.8240 ns/op 0.99
intersect bitArray bitLen 8 6.8930 ns/op 6.7850 ns/op 1.02
intersect array and set length 8 63.334 ns/op 53.820 ns/op 1.18
intersect bitArray bitLen 128 32.590 ns/op 32.053 ns/op 1.02
intersect array and set length 128 812.48 ns/op 748.09 ns/op 1.09
bitArray.getTrueBitIndexes() bitLen 128 1.6780 us/op 1.4100 us/op 1.19
bitArray.getTrueBitIndexes() bitLen 248 2.8930 us/op 2.3170 us/op 1.25
bitArray.getTrueBitIndexes() bitLen 512 5.7370 us/op 4.4730 us/op 1.28
Buffer.concat 32 items 1.1160 us/op 939.00 ns/op 1.19
Uint8Array.set 32 items 2.2070 us/op 1.5930 us/op 1.39
transfer serialized Status (84 B) 1.9820 us/op 1.7770 us/op 1.12
copy serialized Status (84 B) 1.7420 us/op 1.4550 us/op 1.20
transfer serialized SignedVoluntaryExit (112 B) 2.2920 us/op 1.8620 us/op 1.23
copy serialized SignedVoluntaryExit (112 B) 1.8010 us/op 1.4970 us/op 1.20
transfer serialized ProposerSlashing (416 B) 2.9920 us/op 1.9830 us/op 1.51
copy serialized ProposerSlashing (416 B) 2.8940 us/op 1.7820 us/op 1.62
transfer serialized Attestation (485 B) 3.0340 us/op 2.0410 us/op 1.49
copy serialized Attestation (485 B) 3.0110 us/op 1.7910 us/op 1.68
transfer serialized AttesterSlashing (33232 B) 2.8300 us/op 2.1420 us/op 1.32
copy serialized AttesterSlashing (33232 B) 6.0330 us/op 4.4600 us/op 1.35
transfer serialized Small SignedBeaconBlock (128000 B) 2.9480 us/op 2.4190 us/op 1.22
copy serialized Small SignedBeaconBlock (128000 B) 14.874 us/op 11.732 us/op 1.27
transfer serialized Avg SignedBeaconBlock (200000 B) 3.2410 us/op 2.6960 us/op 1.20
copy serialized Avg SignedBeaconBlock (200000 B) 17.853 us/op 16.672 us/op 1.07
transfer serialized BlobsSidecar (524380 B) 3.5180 us/op 2.7870 us/op 1.26
copy serialized BlobsSidecar (524380 B) 89.057 us/op 82.225 us/op 1.08
transfer serialized Big SignedBeaconBlock (1000000 B) 3.7580 us/op 2.8820 us/op 1.30
copy serialized Big SignedBeaconBlock (1000000 B) 158.39 us/op 152.78 us/op 1.04
pass gossip attestations to forkchoice per slot 2.1138 ms/op 2.1091 ms/op 1.00
forkChoice updateHead vc 100000 bc 64 eq 0 2.2363 ms/op 2.4037 ms/op 0.93
forkChoice updateHead vc 600000 bc 64 eq 0 13.909 ms/op 13.988 ms/op 0.99
forkChoice updateHead vc 1000000 bc 64 eq 0 22.753 ms/op 23.211 ms/op 0.98
forkChoice updateHead vc 600000 bc 320 eq 0 17.457 ms/op 16.617 ms/op 1.05
forkChoice updateHead vc 600000 bc 1200 eq 0 85.432 ms/op 84.598 ms/op 1.01
forkChoice updateHead vc 600000 bc 64 eq 1000 22.236 ms/op 21.884 ms/op 1.02
forkChoice updateHead vc 600000 bc 64 eq 10000 23.943 ms/op 23.890 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 300000 29.836 ms/op 28.809 ms/op 1.04
computeDeltas 3.1159 ms/op 2.9654 ms/op 1.05
computeProposerBoostScoreFromBalances 392.44 us/op 384.33 us/op 1.02
altair processAttestation - 250000 vs - 7PWei normalcase 2.4806 ms/op 2.2103 ms/op 1.12
altair processAttestation - 250000 vs - 7PWei worstcase 3.6193 ms/op 3.5675 ms/op 1.01
altair processAttestation - setStatus - 1/6 committees join 187.38 us/op 220.46 us/op 0.85
altair processAttestation - setStatus - 1/3 committees join 344.83 us/op 410.70 us/op 0.84
altair processAttestation - setStatus - 1/2 committees join 471.51 us/op 598.83 us/op 0.79
altair processAttestation - setStatus - 2/3 committees join 596.49 us/op 732.91 us/op 0.81
altair processAttestation - setStatus - 4/5 committees join 802.52 us/op 996.35 us/op 0.81
altair processAttestation - setStatus - 100% committees join 959.96 us/op 1.1403 ms/op 0.84
altair processBlock - 250000 vs - 7PWei normalcase 9.1264 ms/op 9.1024 ms/op 1.00
altair processBlock - 250000 vs - 7PWei normalcase hashState 16.742 ms/op 16.907 ms/op 0.99
altair processBlock - 250000 vs - 7PWei worstcase 39.289 ms/op 37.214 ms/op 1.06
altair processBlock - 250000 vs - 7PWei worstcase hashState 57.105 ms/op 58.201 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei normalcase 2.2964 ms/op 1.9202 ms/op 1.20
phase0 processBlock - 250000 vs - 7PWei worstcase 30.418 ms/op 28.899 ms/op 1.05
altair processEth1Data - 250000 vs - 7PWei normalcase 476.31 us/op 505.63 us/op 0.94
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 15.020 us/op 8.8270 us/op 1.70
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 65.807 us/op 66.434 us/op 0.99
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 26.146 us/op 17.944 us/op 1.46
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 13.136 us/op 11.561 us/op 1.14
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 191.40 us/op 204.30 us/op 0.94
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.1602 ms/op 1.1466 ms/op 1.01
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.7099 ms/op 1.8919 ms/op 0.90
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.7254 ms/op 1.8326 ms/op 0.94
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.0090 ms/op 3.8261 ms/op 0.79
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.5572 ms/op 2.7173 ms/op 0.94
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 5.5158 ms/op 4.9170 ms/op 1.12
Tree 40 250000 create 363.22 ms/op 334.40 ms/op 1.09
Tree 40 250000 get(125000) 208.92 ns/op 231.19 ns/op 0.90
Tree 40 250000 set(125000) 952.56 ns/op 984.84 ns/op 0.97
Tree 40 250000 toArray() 21.204 ms/op 22.411 ms/op 0.95
Tree 40 250000 iterate all - toArray() + loop 21.349 ms/op 22.592 ms/op 0.94
Tree 40 250000 iterate all - get(i) 72.266 ms/op 75.668 ms/op 0.96
MutableVector 250000 create 12.415 ms/op 12.555 ms/op 0.99
MutableVector 250000 get(125000) 6.5750 ns/op 6.6810 ns/op 0.98
MutableVector 250000 set(125000) 268.71 ns/op 283.80 ns/op 0.95
MutableVector 250000 toArray() 3.8166 ms/op 2.9100 ms/op 1.31
MutableVector 250000 iterate all - toArray() + loop 3.4502 ms/op 2.9530 ms/op 1.17
MutableVector 250000 iterate all - get(i) 1.5859 ms/op 1.5585 ms/op 1.02
Array 250000 create 3.5044 ms/op 2.7051 ms/op 1.30
Array 250000 clone - spread 1.1178 ms/op 1.4131 ms/op 0.79
Array 250000 get(125000) 0.56100 ns/op 0.66500 ns/op 0.84
Array 250000 set(125000) 0.62700 ns/op 0.74800 ns/op 0.84
Array 250000 iterate all - loop 90.610 us/op 83.846 us/op 1.08
effectiveBalanceIncrements clone Uint8Array 300000 30.305 us/op 107.48 us/op 0.28
effectiveBalanceIncrements clone MutableVector 300000 306.00 ns/op 253.00 ns/op 1.21
effectiveBalanceIncrements rw all Uint8Array 300000 178.78 us/op 181.41 us/op 0.99
effectiveBalanceIncrements rw all MutableVector 300000 82.753 ms/op 105.99 ms/op 0.78
phase0 afterProcessEpoch - 250000 vs - 7PWei 117.20 ms/op 115.66 ms/op 1.01
phase0 beforeProcessEpoch - 250000 vs - 7PWei 39.669 ms/op 35.252 ms/op 1.13
altair processEpoch - mainnet_e81889 323.76 ms/op 329.71 ms/op 0.98
mainnet_e81889 - altair beforeProcessEpoch 63.218 ms/op 64.616 ms/op 0.98
mainnet_e81889 - altair processJustificationAndFinalization 15.629 us/op 18.349 us/op 0.85
mainnet_e81889 - altair processInactivityUpdates 6.4321 ms/op 6.6259 ms/op 0.97
mainnet_e81889 - altair processRewardsAndPenalties 65.155 ms/op 65.215 ms/op 1.00
mainnet_e81889 - altair processRegistryUpdates 2.8940 us/op 2.3430 us/op 1.24
mainnet_e81889 - altair processSlashings 480.00 ns/op 459.00 ns/op 1.05
mainnet_e81889 - altair processEth1DataReset 496.00 ns/op 688.00 ns/op 0.72
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2891 ms/op 1.2668 ms/op 1.02
mainnet_e81889 - altair processSlashingsReset 2.8520 us/op 3.2690 us/op 0.87
mainnet_e81889 - altair processRandaoMixesReset 6.1270 us/op 5.1820 us/op 1.18
mainnet_e81889 - altair processHistoricalRootsUpdate 1.1200 us/op 916.00 ns/op 1.22
mainnet_e81889 - altair processParticipationFlagUpdates 3.2920 us/op 1.7560 us/op 1.87
mainnet_e81889 - altair processSyncCommitteeUpdates 720.00 ns/op 711.00 ns/op 1.01
mainnet_e81889 - altair afterProcessEpoch 129.87 ms/op 127.88 ms/op 1.02
capella processEpoch - mainnet_e217614 1.0959 s/op 1.0718 s/op 1.02
mainnet_e217614 - capella beforeProcessEpoch 271.18 ms/op 256.75 ms/op 1.06
mainnet_e217614 - capella processJustificationAndFinalization 18.511 us/op 12.930 us/op 1.43
mainnet_e217614 - capella processInactivityUpdates 18.528 ms/op 17.370 ms/op 1.07
mainnet_e217614 - capella processRewardsAndPenalties 277.48 ms/op 289.11 ms/op 0.96
mainnet_e217614 - capella processRegistryUpdates 22.666 us/op 20.258 us/op 1.12
mainnet_e217614 - capella processSlashings 503.00 ns/op 485.00 ns/op 1.04
mainnet_e217614 - capella processEth1DataReset 880.00 ns/op 505.00 ns/op 1.74
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.2158 ms/op 4.1643 ms/op 1.01
mainnet_e217614 - capella processSlashingsReset 2.2750 us/op 2.2570 us/op 1.01
mainnet_e217614 - capella processRandaoMixesReset 3.9370 us/op 3.5930 us/op 1.10
mainnet_e217614 - capella processHistoricalRootsUpdate 634.00 ns/op 539.00 ns/op 1.18
mainnet_e217614 - capella processParticipationFlagUpdates 2.3920 us/op 1.8530 us/op 1.29
mainnet_e217614 - capella afterProcessEpoch 306.58 ms/op 295.22 ms/op 1.04
phase0 processEpoch - mainnet_e58758 359.40 ms/op 327.29 ms/op 1.10
mainnet_e58758 - phase0 beforeProcessEpoch 140.53 ms/op 102.98 ms/op 1.36
mainnet_e58758 - phase0 processJustificationAndFinalization 14.204 us/op 13.538 us/op 1.05
mainnet_e58758 - phase0 processRewardsAndPenalties 69.288 ms/op 51.255 ms/op 1.35
mainnet_e58758 - phase0 processRegistryUpdates 10.751 us/op 9.2770 us/op 1.16
mainnet_e58758 - phase0 processSlashings 474.00 ns/op 478.00 ns/op 0.99
mainnet_e58758 - phase0 processEth1DataReset 370.00 ns/op 446.00 ns/op 0.83
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.5355 ms/op 941.38 us/op 1.63
mainnet_e58758 - phase0 processSlashingsReset 2.0060 us/op 2.0630 us/op 0.97
mainnet_e58758 - phase0 processRandaoMixesReset 3.7810 us/op 3.5020 us/op 1.08
mainnet_e58758 - phase0 processHistoricalRootsUpdate 413.00 ns/op 426.00 ns/op 0.97
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.6860 us/op 3.5810 us/op 1.03
mainnet_e58758 - phase0 afterProcessEpoch 96.248 ms/op 100.67 ms/op 0.96
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2511 ms/op 1.2096 ms/op 1.03
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4050 ms/op 1.4349 ms/op 0.98
altair processInactivityUpdates - 250000 normalcase 23.595 ms/op 25.503 ms/op 0.93
altair processInactivityUpdates - 250000 worstcase 22.976 ms/op 24.672 ms/op 0.93
phase0 processRegistryUpdates - 250000 normalcase 8.3560 us/op 7.3890 us/op 1.13
phase0 processRegistryUpdates - 250000 badcase_full_deposits 303.55 us/op 313.90 us/op 0.97
phase0 processRegistryUpdates - 250000 worstcase 0.5 134.23 ms/op 128.62 ms/op 1.04
altair processRewardsAndPenalties - 250000 normalcase 70.888 ms/op 67.454 ms/op 1.05
altair processRewardsAndPenalties - 250000 worstcase 71.216 ms/op 69.086 ms/op 1.03
phase0 getAttestationDeltas - 250000 normalcase 7.5595 ms/op 7.6649 ms/op 0.99
phase0 getAttestationDeltas - 250000 worstcase 7.4702 ms/op 7.6288 ms/op 0.98
phase0 processSlashings - 250000 worstcase 2.1906 ms/op 2.3648 ms/op 0.93
altair processSyncCommitteeUpdates - 250000 146.66 ms/op 146.70 ms/op 1.00
BeaconState.hashTreeRoot - No change 263.00 ns/op 299.00 ns/op 0.88
BeaconState.hashTreeRoot - 1 full validator 49.524 us/op 49.685 us/op 1.00
BeaconState.hashTreeRoot - 32 full validator 545.14 us/op 486.67 us/op 1.12
BeaconState.hashTreeRoot - 512 full validator 5.4011 ms/op 5.0052 ms/op 1.08
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 62.022 us/op 59.593 us/op 1.04
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 869.30 us/op 813.26 us/op 1.07
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.261 ms/op 10.094 ms/op 1.12
BeaconState.hashTreeRoot - 1 balances 48.697 us/op 46.149 us/op 1.06
BeaconState.hashTreeRoot - 32 balances 464.00 us/op 417.36 us/op 1.11
BeaconState.hashTreeRoot - 512 balances 4.4526 ms/op 3.8251 ms/op 1.16
BeaconState.hashTreeRoot - 250000 balances 73.924 ms/op 79.814 ms/op 0.93
aggregationBits - 2048 els - zipIndexesInBitList 14.324 us/op 14.153 us/op 1.01
regular array get 100000 times 35.604 us/op 43.565 us/op 0.82
wrappedArray get 100000 times 33.020 us/op 32.762 us/op 1.01
arrayWithProxy get 100000 times 14.779 ms/op 14.807 ms/op 1.00
ssz.Root.equals 214.00 ns/op 208.00 ns/op 1.03
byteArrayEquals 209.00 ns/op 214.00 ns/op 0.98
shuffle list - 16384 els 6.9748 ms/op 7.1293 ms/op 0.98
shuffle list - 250000 els 102.83 ms/op 104.47 ms/op 0.98
processSlot - 1 slots 8.0590 us/op 7.8490 us/op 1.03
processSlot - 32 slots 1.2736 ms/op 1.3134 ms/op 0.97
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 55.385 ms/op 54.036 ms/op 1.02
getCommitteeAssignments - req 1 vs - 250000 vc 2.5024 ms/op 2.5468 ms/op 0.98
getCommitteeAssignments - req 100 vs - 250000 vc 3.7263 ms/op 3.7629 ms/op 0.99
getCommitteeAssignments - req 1000 vs - 250000 vc 4.0346 ms/op 4.0991 ms/op 0.98
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.7600 ns/op 4.9200 ns/op 0.97
state getBlockRootAtSlot - 250000 vs - 7PWei 612.67 ns/op 871.50 ns/op 0.70
computeProposers - vc 250000 8.6911 ms/op 9.5031 ms/op 0.91
computeEpochShuffling - vc 250000 105.13 ms/op 104.29 ms/op 1.01
getNextSyncCommittee - vc 250000 150.27 ms/op 152.56 ms/op 0.98
computeSigningRoot for AttestationData 12.931 us/op 13.031 us/op 0.99
hash AttestationData serialized data then Buffer.toString(base64) 2.3218 us/op 2.3027 us/op 1.01
toHexString serialized data 1.0631 us/op 1.0527 us/op 1.01
Buffer.toString(base64) 227.07 ns/op 215.14 ns/op 1.06

by benchmarkbot/action

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nflaig nflaig changed the title Ensure bn Buckets are sorted and unique fix: ensure bn Buckets are sorted and unique Aug 4, 2023
@wemeetagain wemeetagain merged commit bbadfed into unstable Aug 4, 2023
11 of 12 checks passed
@wemeetagain wemeetagain deleted the dapplion/buckets-dedup branch August 4, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB buckets have duplicate keys
4 participants