Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build:watch script #1142

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Add build:watch script #1142

merged 1 commit into from
Jul 13, 2020

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Jul 12, 2020 •
edited
Loading

Fixes #1089.

  • Adds build watch scripts to all packages. Devs can target the packages in development with lerna's scope.
  • Otherwise, it also adds a concurrent script in the root package.json so everything is watched at once. Can be heavy on memory ~4GB on my laptop.

mpetrunic
mpetrunic requested changes Jul 13, 2020
View reviewed changes
Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some junk left

packages/lodestar-utils/src/assert.ts Outdated Show resolved Hide resolved
mpetrunic
mpetrunic requested changes Jul 13, 2020
View reviewed changes
packages/lodestar-cli/src/index.ts Outdated Show resolved Hide resolved
@wemeetagain wemeetagain merged commit ef92378 into ChainSafe:master Jul 13, 2020
@dapplion dapplion deleted the dapplion/build-watch branch July 14, 2020 20:23
@dapplion dapplion mentioned this pull request Jul 7, 2022
Closed
@nflaig nflaig mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

@twoeths twoeths Awaiting requested review from twoeths

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

monorepo build:watch
3 participants
@dapplion @wemeetagain @mpetrunic