Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GENESIS_BASE_FEE_PER_GAS test case for hexEncoding #3309

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Oct 5, 2021

Motivation

part of #3275

Description

  • add a small test case for GENESIS_BASE_FEE_PER_GAS in the spec

@codeclimate
Copy link

codeclimate bot commented Oct 5, 2021

Code Climate has analyzed commit a211e59 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #3309 (a211e59) into master (c3a1e18) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3309   +/-   ##
=======================================
  Coverage   38.46%   38.46%           
=======================================
  Files         303      303           
  Lines        7665     7665           
  Branches     1126     1126           
=======================================
  Hits         2948     2948           
  Misses       4582     4582           
  Partials      135      135           

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: daaa423 Previous: c3a1e18 Ratio
BeaconState.hashTreeRoot - No change 703.00 ns/op 689.00 ns/op 1.02
BeaconState.hashTreeRoot - 1 full validator 80.400 us/op 92.597 us/op 0.87
BeaconState.hashTreeRoot - 32 full validator 1.1626 ms/op 1.3351 ms/op 0.87
BeaconState.hashTreeRoot - 512 full validator 15.114 ms/op 16.721 ms/op 0.90
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 79.416 us/op 92.022 us/op 0.86
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.3552 ms/op 1.2351 ms/op 1.10
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 18.459 ms/op 19.292 ms/op 0.96
BeaconState.hashTreeRoot - 1 balances 56.852 us/op 63.850 us/op 0.89
BeaconState.hashTreeRoot - 32 balances 480.60 us/op 569.03 us/op 0.84
BeaconState.hashTreeRoot - 512 balances 4.8733 ms/op 5.6788 ms/op 0.86
BeaconState.hashTreeRoot - 250000 balances 92.998 ms/op 98.404 ms/op 0.95
processSlot - 1 slots 38.722 us/op 51.601 us/op 0.75
processSlot - 32 slots 2.1454 ms/op 2.3840 ms/op 0.90
getCommitteeAssignments - req 1 vs - 250000 vc 5.1814 ms/op 4.3640 ms/op 1.19
getCommitteeAssignments - req 100 vs - 250000 vc 7.1319 ms/op 6.3103 ms/op 1.13
getCommitteeAssignments - req 1000 vs - 250000 vc 7.6609 ms/op 7.2720 ms/op 1.05
computeProposers - vc 250000 21.204 ms/op 23.073 ms/op 0.92
computeEpochShuffling - vc 250000 192.10 ms/op 180.45 ms/op 1.06
getNextSyncCommittee - vc 250000 347.96 ms/op 374.77 ms/op 0.93
altair processAttestation - 250000 vs - 7PWei normalcase 35.921 ms/op 47.105 ms/op 0.76
altair processAttestation - 250000 vs - 7PWei worstcase 41.531 ms/op 53.168 ms/op 0.78
altair processAttestation - setStatus - 1/6 committees join 10.390 ms/op 10.918 ms/op 0.95
altair processAttestation - setStatus - 1/3 committees join 21.876 ms/op 24.200 ms/op 0.90
altair processAttestation - setStatus - 1/2 committees join 33.881 ms/op 35.453 ms/op 0.96
altair processAttestation - setStatus - 2/3 committees join 45.820 ms/op 47.074 ms/op 0.97
altair processAttestation - setStatus - 4/5 committees join 54.957 ms/op 62.122 ms/op 0.88
altair processAttestation - setStatus - 100% committees join 69.307 ms/op 70.367 ms/op 0.98
altair processAttestation - updateEpochParticipants - 1/6 committees join 11.219 ms/op 11.717 ms/op 0.96
altair processAttestation - updateEpochParticipants - 1/3 committees join 23.895 ms/op 23.333 ms/op 1.02
altair processAttestation - updateEpochParticipants - 1/2 committees join 24.394 ms/op 24.068 ms/op 1.01
altair processAttestation - updateEpochParticipants - 2/3 committees join 25.873 ms/op 27.874 ms/op 0.93
altair processAttestation - updateEpochParticipants - 4/5 committees join 26.972 ms/op 25.042 ms/op 1.08
altair processAttestation - updateEpochParticipants - 100% committees join 26.007 ms/op 26.820 ms/op 0.97
altair processAttestation - updateAllStatus 19.155 ms/op 19.632 ms/op 0.98
altair processBlock - 250000 vs - 7PWei normalcase 39.379 ms/op 42.933 ms/op 0.92
altair processBlock - 250000 vs - 7PWei worstcase 107.50 ms/op 121.65 ms/op 0.88
altair processEpoch - pyrmont_e62330 445.67 ms/op 446.17 ms/op 1.00
pyrmont_e62330 - altair beforeProcessEpoch 150.72 ms/op 158.67 ms/op 0.95
pyrmont_e62330 - altair processJustificationAndFinalization 58.055 us/op 117.21 us/op 0.50
pyrmont_e62330 - altair processInactivityUpdates 8.1037 ms/op 7.6890 ms/op 1.05
pyrmont_e62330 - altair processRewardsAndPenalties 56.897 ms/op 53.304 ms/op 1.07
pyrmont_e62330 - altair processRegistryUpdates 7.0500 us/op 21.612 us/op 0.33
pyrmont_e62330 - altair processSlashings 1.4210 us/op 6.1880 us/op 0.23
pyrmont_e62330 - altair processEth1DataReset 1.3650 us/op 5.7560 us/op 0.24
pyrmont_e62330 - altair processEffectiveBalanceUpdates 5.9125 ms/op 5.8499 ms/op 1.01
pyrmont_e62330 - altair processSlashingsReset 9.0760 us/op 37.145 us/op 0.24
pyrmont_e62330 - altair processRandaoMixesReset 12.799 us/op 43.820 us/op 0.29
pyrmont_e62330 - altair processHistoricalRootsUpdate 1.3580 us/op 7.6630 us/op 0.18
pyrmont_e62330 - altair processParticipationFlagUpdates 44.119 ms/op 45.119 ms/op 0.98
pyrmont_e62330 - altair processSyncCommitteeUpdates 1.3070 us/op 5.7320 us/op 0.23
pyrmont_e62330 - altair afterProcessEpoch 116.52 ms/op 128.28 ms/op 0.91
altair processInactivityUpdates - 250000 normalcase 70.296 ms/op 73.220 ms/op 0.96
altair processInactivityUpdates - 250000 worstcase 63.665 ms/op 66.298 ms/op 0.96
altair processParticipationFlagUpdates - 250000 anycase 93.304 ms/op 88.369 ms/op 1.06
altair processRewardsAndPenalties - 250000 normalcase 116.07 ms/op 113.18 ms/op 1.03
altair processRewardsAndPenalties - 250000 worstcase 126.57 ms/op 127.98 ms/op 0.99
altair processSyncCommitteeUpdates - 250000 364.25 ms/op 374.75 ms/op 0.97
Tree 40 250000 create 496.25 ms/op 544.94 ms/op 0.91
Tree 40 250000 get(125000) 272.84 ns/op 251.19 ns/op 1.09
Tree 40 250000 set(125000) 1.5987 us/op 1.9358 us/op 0.83
Tree 40 250000 toArray() 39.959 ms/op 43.798 ms/op 0.91
Tree 40 250000 iterate all - toArray() + loop 39.885 ms/op 44.009 ms/op 0.91
Tree 40 250000 iterate all - get(i) 104.72 ms/op 103.96 ms/op 1.01
MutableVector 250000 create 22.173 ms/op 23.514 ms/op 0.94
MutableVector 250000 get(125000) 12.858 ns/op 16.926 ns/op 0.76
MutableVector 250000 set(125000) 604.14 ns/op 614.40 ns/op 0.98
MutableVector 250000 toArray() 8.2432 ms/op 7.5143 ms/op 1.10
MutableVector 250000 iterate all - toArray() + loop 8.4800 ms/op 8.1545 ms/op 1.04
MutableVector 250000 iterate all - get(i) 3.4303 ms/op 4.0956 ms/op 0.84
Array 250000 create 5.1308 ms/op 5.1984 ms/op 0.99
Array 250000 clone - spread 2.4229 ms/op 2.0223 ms/op 1.20
Array 250000 get(125000) 1.1420 ns/op 0.82500 ns/op 1.38
Array 250000 set(125000) 0.78800 ns/op 0.88200 ns/op 0.89
Array 250000 iterate all - loop 167.92 us/op 129.91 us/op 1.29
aggregationBits - 2048 els - readonlyValues 273.77 us/op 249.58 us/op 1.10
aggregationBits - 2048 els - zipIndexesInBitList 50.311 us/op 44.812 us/op 1.12
ssz.Root.equals 1.4580 us/op 1.4900 us/op 0.98
ssz.Root.equals with valueOf() 1.7150 us/op 1.7020 us/op 1.01
byteArrayEquals with valueOf() 1.7250 us/op 1.7220 us/op 1.00
phase0 processBlock - 250000 vs - 7PWei normalcase 10.580 ms/op 12.124 ms/op 0.87
phase0 processBlock - 250000 vs - 7PWei worstcase 80.091 ms/op 83.339 ms/op 0.96
phase0 afterProcessEpoch - 250000 vs - 7PWei 211.28 ms/op 200.47 ms/op 1.05
phase0 beforeProcessEpoch - 250000 vs - 7PWei 542.38 ms/op 637.42 ms/op 0.85
phase0 processEpoch - mainnet_e58758 787.74 ms/op 850.37 ms/op 0.93
mainnet_e58758 - phase0 beforeProcessEpoch 484.09 ms/op 522.72 ms/op 0.93
mainnet_e58758 - phase0 processJustificationAndFinalization 49.258 us/op 107.38 us/op 0.46
mainnet_e58758 - phase0 processRewardsAndPenalties 81.965 ms/op 135.09 ms/op 0.61
mainnet_e58758 - phase0 processRegistryUpdates 34.858 us/op 87.044 us/op 0.40
mainnet_e58758 - phase0 processSlashings 1.4090 us/op 6.5260 us/op 0.22
mainnet_e58758 - phase0 processEth1DataReset 1.4130 us/op 5.8230 us/op 0.24
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 9.9173 ms/op 10.380 ms/op 0.96
mainnet_e58758 - phase0 processSlashingsReset 7.9560 us/op 32.871 us/op 0.24
mainnet_e58758 - phase0 processRandaoMixesReset 12.171 us/op 39.667 us/op 0.31
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.3270 us/op 7.4980 us/op 0.18
mainnet_e58758 - phase0 processParticipationRecordUpdates 10.260 us/op 28.589 us/op 0.36
mainnet_e58758 - phase0 afterProcessEpoch 189.45 ms/op 186.22 ms/op 1.02
phase0 processEffectiveBalanceUpdates - 250000 normalcase 11.758 ms/op 11.005 ms/op 1.07
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.2097 s/op 1.5144 s/op 0.80
phase0 processRegistryUpdates - 250000 normalcase 35.816 us/op 88.673 us/op 0.40
phase0 processRegistryUpdates - 250000 badcase_full_deposits 3.0536 ms/op 3.5029 ms/op 0.87
phase0 processRegistryUpdates - 250000 worstcase 0.5 1.5983 s/op 1.8382 s/op 0.87
phase0 getAttestationDeltas - 250000 normalcase 35.270 ms/op 34.923 ms/op 1.01
phase0 getAttestationDeltas - 250000 worstcase 35.102 ms/op 34.543 ms/op 1.02
phase0 processSlashings - 250000 worstcase 38.943 ms/op 32.379 ms/op 1.20
shuffle list - 16384 els 14.010 ms/op 12.248 ms/op 1.14
shuffle list - 250000 els 188.98 ms/op 169.68 ms/op 1.11
getEffectiveBalances - 250000 vs - 7PWei 12.014 ms/op 11.335 ms/op 1.06
computeDeltas 4.5079 ms/op 3.6922 ms/op 1.22
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.6809 ms/op 2.8579 ms/op 0.94
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 905.56 us/op 964.32 us/op 0.94
BLS verify - blst-native 1.8585 ms/op 2.0150 ms/op 0.92
BLS verifyMultipleSignatures 3 - blst-native 3.8089 ms/op 3.8701 ms/op 0.98
BLS verifyMultipleSignatures 8 - blst-native 8.2096 ms/op 9.2041 ms/op 0.89
BLS verifyMultipleSignatures 32 - blst-native 29.791 ms/op 33.017 ms/op 0.90
BLS aggregatePubkeys 32 - blst-native 39.887 us/op 46.899 us/op 0.85
BLS aggregatePubkeys 128 - blst-native 156.02 us/op 181.63 us/op 0.86
getAttestationsForBlock 75.977 ms/op 86.544 ms/op 0.88
CheckpointStateCache - add get delete 15.830 us/op 18.101 us/op 0.87
validate gossip signedAggregateAndProof - struct 4.4483 ms/op 4.9951 ms/op 0.89
validate gossip signedAggregateAndProof - treeBacked 4.4621 ms/op 4.8028 ms/op 0.93
validate gossip attestation - struct 2.0875 ms/op 2.2968 ms/op 0.91
validate gossip attestation - treeBacked 2.0993 ms/op 2.2982 ms/op 0.91

by benchmarkbot/action

@wemeetagain wemeetagain merged commit adaf90f into master Oct 5, 2021
@wemeetagain wemeetagain deleted the tuyen/GENESIS_BASE_FEE_PER_GAS_unit_test branch October 5, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants