Keep states in cache as WeakRef #3420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3420 +/- ##
=======================================
Coverage 38.21% 38.21%
=======================================
Files 303 303
Lines 7890 7921 +31
Branches 1207 1110 -97
=======================================
+ Hits 3015 3027 +12
- Misses 4734 4764 +30
+ Partials 141 130 -11 |
|
Code Climate has analyzed commit 4f96320 and detected 0 issues on this pull request. View more on Code Climate. |
Performance Report✔️ no performance regression detected Full benchmark results
|
5 tasks
Do not delete branch plz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Lodestar has suffered serious memory issues when the state cache grows unbounded due to some bug (for example #3171)
The problem is that the state caches are unbounded memory wise. Current state cache design only limits by state count. In normal conditions that's good enough thanks to high structural sharing. However if the states are too different it will cause an out of memory (OOM) exception.
Description
Keep all states but the head as WeakRefs. NodeJS will garbage collect (GC) the oldest WeakRefs when the app's memory is considered too high.
Script
packages/lodestar/test/perf/weakrefOrder.tsdemonstrates the behavior of WeakRef (tested in NodeJS v14 and v16).WeakRef.deref(), for that WeakRef to become GC-able the macro queue must tick at least once