-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement standard keymanager API #3522
Conversation
Code Climate has analyzed commit a497722 and detected 8 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Performance Report✔️ no performance regression detected Full benchmark results
|
…g as all tests shuts down node properly
…r needs bearer token
…ivationPath would be done later
@dadepo Failing tests and conflicts |
@dadepo failed build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looking for another +1 before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! should we in future save this in a leveldb repo?
Thats an interesting one. So far, what I have observed is: it seem the general practice is to have the keystore files stored on the filesystem, but we can definitely consider/discuss pros/cons of moving it to a leveldb repo |
I don't think so, I doesn't feel right to store a keystore in a level db. Regular JSON files feel more "auditable" and transparent |
Motivation
Implements the standard key manager API from https://ethereum.github.io/keymanager-APIs/, formerly ethereum/beacon-APIs#151
Closes #3523
Description