-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to spec 1.1.6 sans proposer boost #3608
Conversation
Code Climate has analyzed commit 9e505c7 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3608 +/- ##
=======================================
Coverage 37.50% 37.50%
=======================================
Files 311 311
Lines 8357 8357
Branches 1295 1295
=======================================
Hits 3134 3134
Misses 5074 5074
Partials 149 149 |
@@ -157,6 +157,11 @@ export function forkChoiceTest(fork: ForkName): void { | |||
timeout: 10000, | |||
// eslint-disable-next-line @typescript-eslint/no-empty-function | |||
expectFunc: () => {}, | |||
shouldSkip: (_testCase, name, _index) => { | |||
const ignoreTestsWithKeywords = ["proposer_boost"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This skip will be removed with the PR:#3540, has been added as part of strategy to update the spec version in easier manageable PRs
Performance Report✔️ no performance regression detected Full benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
Spec 1.1.6 has following changes pending apart from proposer boost
Description
Details
merge/transition
tests to be added as separate PR: tracked here: Add missingbellatrix
tests to spec runner #3541Part of #3483