Remove SSZ from params #3651
Merged
Remove SSZ from params #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
requested review from
g11tech,
mpetrunic,
twoeths and
wemeetagain
as code owners
|
Code Climate has analyzed commit 7180c6f and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3651 +/- ##
==========================================
- Coverage 37.16% 37.16% -0.01%
==========================================
Files 321 321
Lines 8696 8689 -7
Branches 1348 1346 -2
==========================================
- Hits 3232 3229 -3
+ Misses 5319 5317 -2
+ Partials 145 143 -2 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
previously requested changes
Jan 21, 2022
| /** | ||
| * Run-time chain configuration | ||
| */ | ||
| export interface IChainConfig { | ||
| export type IChainConfig = { |
There was a problem hiding this comment.
Otherwise Typescript doesnt allow this to be used as a Record<string,unknown> argument in functions
| }; | ||
|
|
||
| export const chainConfigTypes: SpecTypes<IChainConfig> = { | ||
| PRESET_BASE: "string", |
There was a problem hiding this comment.
should these values be enum? or overkill?
There was a problem hiding this comment.
Overkill? This whole approach will be review soon anyway to make parsing im the validator client and cli more resilient
| @@ -23,7 +25,7 @@ presetStatus.frozen = true; | |||
| * | |||
| * The active preset can be manually overridden with `setActivePreset` | |||
| */ | |||
| export const ACTIVE_PRESET: PresetName = | |||
| export const ACTIVE_PRESET = | |||
There was a problem hiding this comment.
is this type now inferred to be PresetName?
There was a problem hiding this comment.
Apparently it's not needed, I can't think of a reason why it would be necessary. Not sure if it's a legacy forgotten though or an old uncommented reason
| @@ -16,7 +15,7 @@ export interface IPhase0Preset { | |||
| SAFE_SLOTS_TO_UPDATE_JUSTIFIED: number; | |||
|
|
|||
| // Gwei Values | |||
| MIN_DEPOSIT_AMOUNT: bigint; | |||
| MIN_DEPOSIT_AMOUNT: number; | |||
There was a problem hiding this comment.
This isn't used anywhere?! I guess its hard to argue against changing it to a number
There was a problem hiding this comment.
Yeah, not used anywhere 🤷
|
|
||
| export const bellatrix: IBellatrixPreset = { | ||
| /* eslint-disable @typescript-eslint/naming-convention */ |
There was a problem hiding this comment.
Yes to allow having all caps
| import {PresetName} from "@chainsafe/lodestar-params"; | ||
|
|
||
| /* eslint-disable @typescript-eslint/naming-convention */ |
There was a problem hiding this comment.
Yes to allow having all caps
g11tech
previously approved these changes
Jan 22, 2022
g11tech
force-pushed
the
dapplion/params-remove-ssz-2
branch
from
172ef15
to
7180c6f
Compare
g11tech
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently config and params use SSZ to define the type of its values. This approach is sub-optimal because:
Description