-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish exact dependencies for nighly release #3679
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3679 +/- ##
=======================================
Coverage 37.20% 37.20%
=======================================
Files 322 322
Lines 8717 8717
Branches 1349 1349
=======================================
Hits 3243 3243
Misses 5332 5332
Partials 142 142 |
Performance Report✔️ no performance regression detected Full benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this! I agree it's a good approach, consumers of this versions are okay not getting semver PATCH updates since this should be used in testing environments
Motivation
npm install is not able to resolve the dev versioned dependencies specified with
^
operator for e.g.@chainsafe/lodestar-config@^0.34.0-dev.4
resolves to =>0.34.0
whennpm install @chainsafe/lodestar-cli@^0.34.0-dev.4
is done.On a bit of digging through on internet, people have tried using
--exact
version in lerna publish to make npm resolve the exact package. Hopefully this fixes the dependency resolution in the install, and wll fix the nightly buildCloses #3676