exchangeTransitionConfiguration heartbeat implementation #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
requested review from
wemeetagain,
twoeths and
dapplion
as code owners
Performance Report✔️ no performance regression detected Full benchmark results
|
14 tasks
dapplion
reviewed
Feb 28, 2022
| this.rpc = | ||
| rpc ?? | ||
| new JsonRpcHttpClient(opts.urls, { | ||
| signal, | ||
| timeout: opts.timeout, | ||
| }); | ||
| void this.exchangeTransitionConfiguration(); |
There was a problem hiding this comment.
void Promise that may reject is a bad idea.
dapplion
reviewed
Feb 28, 2022
| transitionConfig.terminalBlockHash !== this.transitionConfig.terminalBlockHash || | ||
| transitionConfig.terminalBlockNumber !== this.transitionConfig.terminalBlockNumber | ||
| ) { | ||
| throw Error( |
There was a problem hiding this comment.
This http engine should not be responsible to throw this Error. There should be something at a higher level that does this recurring calls and logs loudly if there's a mismatch. Keep in mind that there may be multiple transports in the future besides http. The return of this function could be a status
type ReturnType = {match: true} | {match: false; local: TransitionConfig; remote: TransitionConfig}
dapplion
reviewed
Feb 28, 2022
| } | ||
| // Use this lastHeartBeatAt in the actual engine api calls to identify if this needs to | ||
| // be called again | ||
| this.lastHeartBeatAt = Math.floor(new Date().getTime() / 1000); |
There was a problem hiding this comment.
This class should not be responsible to track the frequency of calls, this class should be state-less
|
closing this to begin afresh as the code has diverged quite a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Execution engines will now hosts an api to specify and match transition configuration ethereum/execution-apis#172, which is supposed to act as a heatbeat between EL and CL.
This PR implements and matches the same and aims to implements the heart beat functionality
Description
PS: this work is currently WIP and some details/clarifications are awaited. Also this is not the part of Kiln v2 spec.
Part of Kiln tracker