Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gossipsub to 0.13.2 #3873

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Bump gossipsub to 0.13.2 #3873

merged 1 commit into from
Mar 26, 2022

Conversation

wemeetagain
Copy link
Member

@wemeetagain wemeetagain commented Mar 26, 2022 •
edited by dapplion
Loading

Upstream fix in floodpublish logic that may affect attestation propagation

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #3873 (e78a2c9) into master (0b85a46) will increase coverage by 2.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3873      +/-   ##
==========================================
+ Coverage   33.09%   36.00%   +2.90%     
==========================================
  Files         297      326      +29     
  Lines        8236     9091     +855     
  Branches     1318     1434     +116     
==========================================
+ Hits         2726     3273     +547     
- Misses       5431     5675     +244     
- Partials       79      143      +64

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: c6cc040 Previous: 0b85a46 Ratio
BeaconState.hashTreeRoot - No change 624.00 ns/op 722.00 ns/op 0.86
BeaconState.hashTreeRoot - 1 full validator 144.07 us/op 151.69 us/op 0.95
BeaconState.hashTreeRoot - 32 full validator 2.2641 ms/op 2.3159 ms/op 0.98
BeaconState.hashTreeRoot - 512 full validator 30.449 ms/op 30.442 ms/op 1.00
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 149.17 us/op 149.61 us/op 1.00
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.4353 ms/op 2.8031 ms/op 0.87
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 31.679 ms/op 32.673 ms/op 0.97
BeaconState.hashTreeRoot - 1 balances 105.86 us/op 96.448 us/op 1.10
BeaconState.hashTreeRoot - 32 balances 860.80 us/op 908.13 us/op 0.95
BeaconState.hashTreeRoot - 512 balances 9.2938 ms/op 8.7363 ms/op 1.06
BeaconState.hashTreeRoot - 250000 balances 156.46 ms/op 183.15 ms/op 0.85
processSlot - 1 slots 54.874 us/op 54.996 us/op 1.00
processSlot - 32 slots 3.2988 ms/op 3.4254 ms/op 0.96
getCommitteeAssignments - req 1 vs - 250000 vc 5.7999 ms/op 6.3259 ms/op 0.92
getCommitteeAssignments - req 100 vs - 250000 vc 8.3338 ms/op 8.8067 ms/op 0.95
getCommitteeAssignments - req 1000 vs - 250000 vc 8.8711 ms/op 9.3494 ms/op 0.95
computeProposers - vc 250000 24.395 ms/op 24.279 ms/op 1.00
computeEpochShuffling - vc 250000 215.77 ms/op 220.76 ms/op 0.98
getNextSyncCommittee - vc 250000 398.02 ms/op 395.44 ms/op 1.01
altair processAttestation - 250000 vs - 7PWei normalcase 41.034 ms/op 41.483 ms/op 0.99
altair processAttestation - 250000 vs - 7PWei worstcase 39.158 ms/op 39.306 ms/op 1.00
altair processAttestation - setStatus - 1/6 committees join 13.015 ms/op 11.978 ms/op 1.09
altair processAttestation - setStatus - 1/3 committees join 27.781 ms/op 24.613 ms/op 1.13
altair processAttestation - setStatus - 1/2 committees join 40.122 ms/op 37.720 ms/op 1.06
altair processAttestation - setStatus - 2/3 committees join 61.088 ms/op 50.638 ms/op 1.21
altair processAttestation - setStatus - 4/5 committees join 58.282 ms/op 60.592 ms/op 0.96
altair processAttestation - setStatus - 100% committees join 70.817 ms/op 75.905 ms/op 0.93
altair processAttestation - updateEpochParticipants - 1/6 committees join 12.453 ms/op 12.553 ms/op 0.99
altair processAttestation - updateEpochParticipants - 1/3 committees join 25.218 ms/op 26.592 ms/op 0.95
altair processAttestation - updateEpochParticipants - 1/2 committees join 23.648 ms/op 26.472 ms/op 0.89
altair processAttestation - updateEpochParticipants - 2/3 committees join 25.608 ms/op 24.233 ms/op 1.06
altair processAttestation - updateEpochParticipants - 4/5 committees join 26.541 ms/op 25.616 ms/op 1.04
altair processAttestation - updateEpochParticipants - 100% committees join 30.543 ms/op 30.693 ms/op 1.00
altair processAttestation - updateAllStatus 21.688 ms/op 21.714 ms/op 1.00
altair processBlock - 250000 vs - 7PWei normalcase 38.562 ms/op 37.130 ms/op 1.04
altair processBlock - 250000 vs - 7PWei worstcase 118.62 ms/op 118.88 ms/op 1.00
altair processEpoch - mainnet_e81889 921.12 ms/op 901.25 ms/op 1.02
mainnet_e81889 - altair beforeProcessEpoch 366.12 ms/op 347.76 ms/op 1.05
mainnet_e81889 - altair processJustificationAndFinalization 85.010 us/op 64.183 us/op 1.32
mainnet_e81889 - altair processInactivityUpdates 23.542 ms/op 20.741 ms/op 1.14
mainnet_e81889 - altair processRewardsAndPenalties 111.19 ms/op 156.48 ms/op 0.71
mainnet_e81889 - altair processRegistryUpdates 13.592 us/op 9.3590 us/op 1.45
mainnet_e81889 - altair processSlashings 2.9510 us/op 3.3310 us/op 0.89
mainnet_e81889 - altair processEth1DataReset 3.2490 us/op 3.3210 us/op 0.98
mainnet_e81889 - altair processEffectiveBalanceUpdates 7.3636 ms/op 7.4833 ms/op 0.98
mainnet_e81889 - altair processSlashingsReset 21.760 us/op 14.174 us/op 1.54
mainnet_e81889 - altair processRandaoMixesReset 25.634 us/op 17.585 us/op 1.46
mainnet_e81889 - altair processHistoricalRootsUpdate 4.8340 us/op 4.2560 us/op 1.14
mainnet_e81889 - altair processParticipationFlagUpdates 78.043 ms/op 77.506 ms/op 1.01
mainnet_e81889 - altair processSyncCommitteeUpdates 2.6650 us/op 3.2470 us/op 0.82
mainnet_e81889 - altair afterProcessEpoch 258.70 ms/op 263.94 ms/op 0.98
altair processInactivityUpdates - 250000 normalcase 78.186 ms/op 77.268 ms/op 1.01
altair processInactivityUpdates - 250000 worstcase 79.666 ms/op 76.739 ms/op 1.04
altair processParticipationFlagUpdates - 250000 anycase 78.999 ms/op 68.316 ms/op 1.16
altair processRewardsAndPenalties - 250000 normalcase 99.871 ms/op 124.99 ms/op 0.80
altair processRewardsAndPenalties - 250000 worstcase 114.44 ms/op 86.873 ms/op 1.32
altair processSyncCommitteeUpdates - 250000 401.91 ms/op 408.85 ms/op 0.98
Tree 40 250000 create 741.66 ms/op 710.30 ms/op 1.04
Tree 40 250000 get(125000) 389.63 ns/op 392.65 ns/op 0.99
Tree 40 250000 set(125000) 2.1878 us/op 2.3359 us/op 0.94
Tree 40 250000 toArray() 42.865 ms/op 44.778 ms/op 0.96
Tree 40 250000 iterate all - toArray() + loop 41.745 ms/op 44.825 ms/op 0.93
Tree 40 250000 iterate all - get(i) 135.95 ms/op 142.79 ms/op 0.95
MutableVector 250000 create 24.207 ms/op 27.387 ms/op 0.88
MutableVector 250000 get(125000) 14.500 ns/op 15.682 ns/op 0.92
MutableVector 250000 set(125000) 614.11 ns/op 585.45 ns/op 1.05
MutableVector 250000 toArray() 10.295 ms/op 9.7754 ms/op 1.05
MutableVector 250000 iterate all - toArray() + loop 10.244 ms/op 10.046 ms/op 1.02
MutableVector 250000 iterate all - get(i) 4.3123 ms/op 4.0491 ms/op 1.06
Array 250000 create 6.6810 ms/op 6.0310 ms/op 1.11
Array 250000 clone - spread 2.8271 ms/op 2.4736 ms/op 1.14
Array 250000 get(125000) 1.3320 ns/op 1.2360 ns/op 1.08
Array 250000 set(125000) 1.3550 ns/op 1.2230 ns/op 1.11
Array 250000 iterate all - loop 196.42 us/op 201.31 us/op 0.98
effectiveBalanceIncrements clone Uint8Array 300000 84.976 us/op 73.715 us/op 1.15
effectiveBalanceIncrements clone MutableVector 300000 881.00 ns/op 786.00 ns/op 1.12
effectiveBalanceIncrements rw all Uint8Array 300000 332.88 us/op 362.19 us/op 0.92
effectiveBalanceIncrements rw all MutableVector 300000 209.35 ms/op 199.22 ms/op 1.05
aggregationBits - 2048 els - readonlyValues 223.04 us/op 216.12 us/op 1.03
aggregationBits - 2048 els - zipIndexesInBitList 35.372 us/op 38.555 us/op 0.92
regular array get 100000 times 77.269 us/op 80.804 us/op 0.96
wrappedArray get 100000 times 78.569 us/op 80.886 us/op 0.97
arrayWithProxy get 100000 times 31.984 ms/op 34.336 ms/op 0.93
ssz.Root.equals 1.2540 us/op 1.3120 us/op 0.96
ssz.Root.equals with valueOf() 1.4600 us/op 1.5870 us/op 0.92
byteArrayEquals with valueOf() 1.4130 us/op 1.4880 us/op 0.95
phase0 processBlock - 250000 vs - 7PWei normalcase 10.407 ms/op 9.4055 ms/op 1.11
phase0 processBlock - 250000 vs - 7PWei worstcase 82.906 ms/op 86.518 ms/op 0.96
phase0 afterProcessEpoch - 250000 vs - 7PWei 232.15 ms/op 249.05 ms/op 0.93
phase0 beforeProcessEpoch - 250000 vs - 7PWei 612.17 ms/op 656.01 ms/op 0.93
phase0 processEpoch - mainnet_e58758 867.39 ms/op 872.71 ms/op 0.99
mainnet_e58758 - phase0 beforeProcessEpoch 478.45 ms/op 477.73 ms/op 1.00
mainnet_e58758 - phase0 processJustificationAndFinalization 93.510 us/op 61.155 us/op 1.53
mainnet_e58758 - phase0 processRewardsAndPenalties 125.77 ms/op 126.55 ms/op 0.99
mainnet_e58758 - phase0 processRegistryUpdates 67.156 us/op 40.919 us/op 1.64
mainnet_e58758 - phase0 processSlashings 4.0830 us/op 3.3550 us/op 1.22
mainnet_e58758 - phase0 processEth1DataReset 3.9990 us/op 3.4730 us/op 1.15
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 5.9053 ms/op 6.1811 ms/op 0.96
mainnet_e58758 - phase0 processSlashingsReset 21.127 us/op 12.531 us/op 1.69
mainnet_e58758 - phase0 processRandaoMixesReset 26.825 us/op 18.496 us/op 1.45
mainnet_e58758 - phase0 processHistoricalRootsUpdate 5.5590 us/op 4.0930 us/op 1.36
mainnet_e58758 - phase0 processParticipationRecordUpdates 20.315 us/op 12.680 us/op 1.60
mainnet_e58758 - phase0 afterProcessEpoch 211.87 ms/op 215.31 ms/op 0.98
phase0 processEffectiveBalanceUpdates - 250000 normalcase 6.8382 ms/op 7.0996 ms/op 0.96
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 7.5382 ms/op 7.5240 ms/op 1.00
phase0 processRegistryUpdates - 250000 normalcase 67.225 us/op 41.779 us/op 1.61
phase0 processRegistryUpdates - 250000 badcase_full_deposits 3.3941 ms/op 3.2129 ms/op 1.06
phase0 processRegistryUpdates - 250000 worstcase 0.5 1.7977 s/op 1.7501 s/op 1.03
phase0 getAttestationDeltas - 250000 normalcase 15.006 ms/op 15.149 ms/op 0.99
phase0 getAttestationDeltas - 250000 worstcase 14.987 ms/op 15.292 ms/op 0.98
phase0 processSlashings - 250000 worstcase 39.998 ms/op 38.212 ms/op 1.05
shuffle list - 16384 els 14.847 ms/op 15.534 ms/op 0.96
shuffle list - 250000 els 208.19 ms/op 222.56 ms/op 0.94
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 486.90 us/op 576.27 us/op 0.84
pass gossip attestations to forkchoice per slot 17.635 ms/op 17.003 ms/op 1.04
computeDeltas 3.5731 ms/op 3.8119 ms/op 0.94
computeProposerBoostScoreFromBalances 577.59 us/op 603.43 us/op 0.96
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.3212 ms/op 1.9910 ms/op 1.17
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 805.52 us/op 864.23 us/op 0.93
BLS verify - blst-native 2.1860 ms/op 2.2289 ms/op 0.98
BLS verifyMultipleSignatures 3 - blst-native 4.4423 ms/op 4.5631 ms/op 0.97
BLS verifyMultipleSignatures 8 - blst-native 9.3818 ms/op 9.8327 ms/op 0.95
BLS verifyMultipleSignatures 32 - blst-native 34.689 ms/op 35.522 ms/op 0.98
BLS aggregatePubkeys 32 - blst-native 47.473 us/op 47.813 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 175.21 us/op 185.12 us/op 0.95
getAttestationsForBlock 67.109 ms/op 74.229 ms/op 0.90
CheckpointStateCache - add get delete 22.039 us/op 21.402 us/op 1.03
validate gossip signedAggregateAndProof - struct 5.0783 ms/op 5.3022 ms/op 0.96
validate gossip signedAggregateAndProof - treeBacked 4.9511 ms/op 5.2225 ms/op 0.95
validate gossip attestation - struct 2.4373 ms/op 2.4850 ms/op 0.98
validate gossip attestation - treeBacked 2.3450 ms/op 2.5092 ms/op 0.93
pickEth1Vote - no votes 10.360 ms/op 10.590 ms/op 0.98
pickEth1Vote - max votes 59.945 ms/op 59.161 ms/op 1.01
pickEth1Vote - Eth1Data hashTreeRoot value x2048 29.568 ms/op 29.352 ms/op 1.01
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 11.120 ms/op 11.050 ms/op 1.01
pickEth1Vote - Eth1Data fastSerialize value x2048 5.9555 ms/op 5.9598 ms/op 1.00
pickEth1Vote - Eth1Data fastSerialize tree x2048 28.457 ms/op 27.602 ms/op 1.03
bytes32 toHexString 1.8710 us/op 1.9400 us/op 0.96
bytes32 Buffer.toString(hex) 811.00 ns/op 854.00 ns/op 0.95
bytes32 Buffer.toString(hex) from Uint8Array 966.00 ns/op 1.1100 us/op 0.87
bytes32 Buffer.toString(hex) + 0x 778.00 ns/op 836.00 ns/op 0.93
Object access 1 prop 0.37600 ns/op 0.42400 ns/op 0.89
Map access 1 prop 0.34000 ns/op 0.36200 ns/op 0.94
Object get x1000 19.327 ns/op 22.570 ns/op 0.86
Map get x1000 1.1970 ns/op 1.1750 ns/op 1.02
Object set x1000 119.64 ns/op 127.24 ns/op 0.94
Map set x1000 70.649 ns/op 76.042 ns/op 0.93
Return object 10000 times 0.42440 ns/op 0.45010 ns/op 0.94
Throw Error 10000 times 6.5612 us/op 6.8129 us/op 0.96
enrSubnets - fastDeserialize 64 bits 1.4100 us/op 1.4600 us/op 0.97
enrSubnets - ssz BitVector 64 bits 19.274 us/op 19.871 us/op 0.97
enrSubnets - fastDeserialize 4 bits 516.00 ns/op 533.00 ns/op 0.97
enrSubnets - ssz BitVector 4 bits 3.1960 us/op 3.4210 us/op 0.93
RateTracker 1000000 limit, 1 obj count per request 206.51 ns/op 210.92 ns/op 0.98
RateTracker 1000000 limit, 2 obj count per request 154.48 ns/op 157.66 ns/op 0.98
RateTracker 1000000 limit, 4 obj count per request 125.39 ns/op 129.93 ns/op 0.97
RateTracker 1000000 limit, 8 obj count per request 111.25 ns/op 117.16 ns/op 0.95
RateTracker with prune 4.1870 us/op 4.3950 us/op 0.95
array of 16000 items push then shift 3.7343 us/op 3.7840 us/op 0.99
LinkedList of 16000 items push then shift 20.194 ns/op 18.537 ns/op 1.09
array of 16000 items push then pop 230.27 ns/op 241.46 ns/op 0.95
LinkedList of 16000 items push then pop 17.693 ns/op 18.988 ns/op 0.93
array of 24000 items push then shift 5.1263 us/op 5.4444 us/op 0.94
LinkedList of 24000 items push then shift 21.588 ns/op 21.123 ns/op 1.02
array of 24000 items push then pop 211.19 ns/op 221.20 ns/op 0.95
LinkedList of 24000 items push then pop 19.193 ns/op 20.228 ns/op 0.95

by benchmarkbot/action

@twoeths twoeths merged commit 08f98c2 into master Mar 26, 2022
@twoeths twoeths deleted the cayman/bump-gossipsub branch March 26, 2022 20:36
@dapplion dapplion mentioned this pull request May 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoeths twoeths twoeths approved these changes

@dapplion dapplion Awaiting requested review from dapplion

@g11tech g11tech Awaiting requested review from g11tech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wemeetagain @twoeths