Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash assert_valid_rc script #4096

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Add bash assert_valid_rc script #4096

merged 1 commit into from
Jun 1, 2022

Conversation

wemeetagain
Copy link
Member

Motivation

Publishing v0.38.0-rc.0 failed due to node not being installed in the first step.

Description

Simple replacement of the existing node script.

@wemeetagain wemeetagain requested a review from a team as a code owner June 1, 2022 03:21
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 0ba06cf Previous: 34fdbde Ratio
BeaconState.hashTreeRoot - No change 492.00 ns/op 503.00 ns/op 0.98
BeaconState.hashTreeRoot - 1 full validator 66.484 us/op 66.929 us/op 0.99
BeaconState.hashTreeRoot - 32 full validator 652.87 us/op 660.12 us/op 0.99
BeaconState.hashTreeRoot - 512 full validator 7.1355 ms/op 8.0095 ms/op 0.89
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 84.593 us/op 86.877 us/op 0.97
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.1186 ms/op 1.1498 ms/op 0.97
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 15.140 ms/op 16.724 ms/op 0.91
BeaconState.hashTreeRoot - 1 balances 65.427 us/op 65.833 us/op 0.99
BeaconState.hashTreeRoot - 32 balances 560.33 us/op 566.91 us/op 0.99
BeaconState.hashTreeRoot - 512 balances 5.4073 ms/op 5.8908 ms/op 0.92
BeaconState.hashTreeRoot - 250000 balances 113.30 ms/op 116.52 ms/op 0.97
processSlot - 1 slots 13.384 us/op 12.953 us/op 1.03
processSlot - 32 slots 1.8398 ms/op 1.9346 ms/op 0.95
getCommitteeAssignments - req 1 vs - 250000 vc 5.3536 ms/op 5.4407 ms/op 0.98
getCommitteeAssignments - req 100 vs - 250000 vc 7.8195 ms/op 7.9360 ms/op 0.99
getCommitteeAssignments - req 1000 vs - 250000 vc 8.3306 ms/op 8.4251 ms/op 0.99
computeProposers - vc 250000 17.038 ms/op 18.393 ms/op 0.93
computeEpochShuffling - vc 250000 171.37 ms/op 176.92 ms/op 0.97
getNextSyncCommittee - vc 250000 281.70 ms/op 304.57 ms/op 0.92
altair processAttestation - 250000 vs - 7PWei normalcase 3.3279 ms/op 4.2890 ms/op 0.78
altair processAttestation - 250000 vs - 7PWei worstcase 4.9357 ms/op 6.0270 ms/op 0.82
altair processAttestation - setStatus - 1/6 committees join 163.43 us/op 188.06 us/op 0.87
altair processAttestation - setStatus - 1/3 committees join 321.87 us/op 355.48 us/op 0.91
altair processAttestation - setStatus - 1/2 committees join 468.48 us/op 494.75 us/op 0.95
altair processAttestation - setStatus - 2/3 committees join 614.88 us/op 656.10 us/op 0.94
altair processAttestation - setStatus - 4/5 committees join 848.16 us/op 928.07 us/op 0.91
altair processAttestation - setStatus - 100% committees join 1.0416 ms/op 1.1107 ms/op 0.94
altair processBlock - 250000 vs - 7PWei normalcase 19.649 ms/op 25.404 ms/op 0.77
altair processBlock - 250000 vs - 7PWei normalcase hashState 35.248 ms/op 40.159 ms/op 0.88
altair processBlock - 250000 vs - 7PWei worstcase 81.104 ms/op 80.758 ms/op 1.00
altair processBlock - 250000 vs - 7PWei worstcase hashState 102.48 ms/op 105.09 ms/op 0.98
altair processEth1Data - 250000 vs - 7PWei normalcase 771.97 us/op 928.60 us/op 0.83
altair processEpoch - mainnet_e81889 523.24 ms/op 576.45 ms/op 0.91
mainnet_e81889 - altair beforeProcessEpoch 97.870 ms/op 149.93 ms/op 0.65
mainnet_e81889 - altair processJustificationAndFinalization 21.577 us/op 17.507 us/op 1.23
mainnet_e81889 - altair processInactivityUpdates 8.8831 ms/op 10.875 ms/op 0.82
mainnet_e81889 - altair processRewardsAndPenalties 73.047 ms/op 85.468 ms/op 0.85
mainnet_e81889 - altair processRegistryUpdates 3.3240 us/op 2.8010 us/op 1.19
mainnet_e81889 - altair processSlashings 838.00 ns/op 657.00 ns/op 1.28
mainnet_e81889 - altair processEth1DataReset 686.00 ns/op 716.00 ns/op 0.96
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.0768 ms/op 2.0343 ms/op 1.02
mainnet_e81889 - altair processSlashingsReset 4.9000 us/op 5.2490 us/op 0.93
mainnet_e81889 - altair processRandaoMixesReset 4.4220 us/op 6.3410 us/op 0.70
mainnet_e81889 - altair processHistoricalRootsUpdate 739.00 ns/op 1.2000 us/op 0.62
mainnet_e81889 - altair processParticipationFlagUpdates 8.1790 us/op 2.9200 us/op 2.80
mainnet_e81889 - altair processSyncCommitteeUpdates 705.00 ns/op 892.00 ns/op 0.79
mainnet_e81889 - altair afterProcessEpoch 220.26 ms/op 206.72 ms/op 1.07
altair processInactivityUpdates - 250000 normalcase 27.396 ms/op 37.699 ms/op 0.73
altair processInactivityUpdates - 250000 worstcase 22.772 ms/op 25.272 ms/op 0.90
altair processRewardsAndPenalties - 250000 normalcase 101.39 ms/op 80.856 ms/op 1.25
altair processRewardsAndPenalties - 250000 worstcase 89.748 ms/op 113.71 ms/op 0.79
altair processSyncCommitteeUpdates - 250000 290.84 ms/op 313.98 ms/op 0.93
Tree 40 250000 create 705.98 ms/op 1.2338 s/op 0.57
Tree 40 250000 get(125000) 252.92 ns/op 256.57 ns/op 0.99
Tree 40 250000 set(125000) 2.4766 us/op 3.7811 us/op 0.65
Tree 40 250000 toArray() 28.574 ms/op 32.362 ms/op 0.88
Tree 40 250000 iterate all - toArray() + loop 28.972 ms/op 32.886 ms/op 0.88
Tree 40 250000 iterate all - get(i) 115.30 ms/op 119.06 ms/op 0.97
MutableVector 250000 create 14.223 ms/op 15.861 ms/op 0.90
MutableVector 250000 get(125000) 10.638 ns/op 10.680 ns/op 1.00
MutableVector 250000 set(125000) 595.37 ns/op 990.37 ns/op 0.60
MutableVector 250000 toArray() 5.6127 ms/op 7.2920 ms/op 0.77
MutableVector 250000 iterate all - toArray() + loop 5.7335 ms/op 7.4857 ms/op 0.77
MutableVector 250000 iterate all - get(i) 2.8544 ms/op 2.6147 ms/op 1.09
Array 250000 create 5.4964 ms/op 7.3620 ms/op 0.75
Array 250000 clone - spread 3.2430 ms/op 7.5465 ms/op 0.43
Array 250000 get(125000) 1.6000 ns/op 2.8580 ns/op 0.56
Array 250000 set(125000) 1.6560 ns/op 2.9170 ns/op 0.57
Array 250000 iterate all - loop 153.15 us/op 151.05 us/op 1.01
effectiveBalanceIncrements clone Uint8Array 300000 96.258 us/op 103.61 us/op 0.93
effectiveBalanceIncrements clone MutableVector 300000 658.00 ns/op 2.2960 us/op 0.29
effectiveBalanceIncrements rw all Uint8Array 300000 248.03 us/op 247.52 us/op 1.00
effectiveBalanceIncrements rw all MutableVector 300000 149.07 ms/op 323.54 ms/op 0.46
aggregationBits - 2048 els - zipIndexesInBitList 24.640 us/op 49.661 us/op 0.50
regular array get 100000 times 62.250 us/op 60.585 us/op 1.03
wrappedArray get 100000 times 62.429 us/op 61.310 us/op 1.02
arrayWithProxy get 100000 times 32.256 ms/op 29.248 ms/op 1.10
ssz.Root.equals 551.00 ns/op 592.00 ns/op 0.93
byteArrayEquals 551.00 ns/op 576.00 ns/op 0.96
phase0 processBlock - 250000 vs - 7PWei normalcase 3.4143 ms/op 4.2853 ms/op 0.80
phase0 processBlock - 250000 vs - 7PWei worstcase 51.719 ms/op 54.068 ms/op 0.96
phase0 afterProcessEpoch - 250000 vs - 7PWei 189.92 ms/op 197.72 ms/op 0.96
phase0 beforeProcessEpoch - 250000 vs - 7PWei 59.255 ms/op 91.660 ms/op 0.65
phase0 processEpoch - mainnet_e58758 478.32 ms/op 538.66 ms/op 0.89
mainnet_e58758 - phase0 beforeProcessEpoch 190.96 ms/op 214.38 ms/op 0.89
mainnet_e58758 - phase0 processJustificationAndFinalization 19.897 us/op 18.397 us/op 1.08
mainnet_e58758 - phase0 processRewardsAndPenalties 61.794 ms/op 129.96 ms/op 0.48
mainnet_e58758 - phase0 processRegistryUpdates 7.6760 us/op 8.6160 us/op 0.89
mainnet_e58758 - phase0 processSlashings 638.00 ns/op 587.00 ns/op 1.09
mainnet_e58758 - phase0 processEth1DataReset 663.00 ns/op 603.00 ns/op 1.10
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.7915 ms/op 2.8867 ms/op 0.62
mainnet_e58758 - phase0 processSlashingsReset 4.3920 us/op 4.1740 us/op 1.05
mainnet_e58758 - phase0 processRandaoMixesReset 4.9760 us/op 4.2740 us/op 1.16
mainnet_e58758 - phase0 processHistoricalRootsUpdate 803.00 ns/op 720.00 ns/op 1.12
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.5090 us/op 4.2860 us/op 1.29
mainnet_e58758 - phase0 afterProcessEpoch 166.45 ms/op 168.41 ms/op 0.99
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.0424 ms/op 2.0554 ms/op 0.99
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.1393 ms/op 2.2347 ms/op 0.96
phase0 processRegistryUpdates - 250000 normalcase 6.4500 us/op 6.5540 us/op 0.98
phase0 processRegistryUpdates - 250000 badcase_full_deposits 361.56 us/op 380.03 us/op 0.95
phase0 processRegistryUpdates - 250000 worstcase 0.5 172.54 ms/op 211.62 ms/op 0.82
phase0 getAttestationDeltas - 250000 normalcase 11.633 ms/op 17.301 ms/op 0.67
phase0 getAttestationDeltas - 250000 worstcase 11.697 ms/op 16.871 ms/op 0.69
phase0 processSlashings - 250000 worstcase 5.1067 ms/op 5.7204 ms/op 0.89
shuffle list - 16384 els 11.428 ms/op 11.678 ms/op 0.98
shuffle list - 250000 els 169.82 ms/op 171.70 ms/op 0.99
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 377.50 us/op 440.27 us/op 0.86
pass gossip attestations to forkchoice per slot 3.1518 ms/op 3.1286 ms/op 1.01
computeDeltas 3.2343 ms/op 3.4726 ms/op 0.93
computeProposerBoostScoreFromBalances 805.73 us/op 805.52 us/op 1.00
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.7176 ms/op 2.5345 ms/op 0.68
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 64.696 us/op 81.483 us/op 0.79
BLS verify - blst-native 2.1757 ms/op 2.1750 ms/op 1.00
BLS verifyMultipleSignatures 3 - blst-native 4.4854 ms/op 4.4813 ms/op 1.00
BLS verifyMultipleSignatures 8 - blst-native 9.6773 ms/op 9.6904 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 35.152 ms/op 35.218 ms/op 1.00
BLS aggregatePubkeys 32 - blst-native 46.669 us/op 46.982 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 182.43 us/op 182.65 us/op 1.00
getAttestationsForBlock 52.618 ms/op 72.442 ms/op 0.73
isKnown best case - 1 super set check 493.00 ns/op 507.00 ns/op 0.97
isKnown normal case - 2 super set checks 484.00 ns/op 493.00 ns/op 0.98
isKnown worse case - 16 super set checks 484.00 ns/op 496.00 ns/op 0.98
CheckpointStateCache - add get delete 10.640 us/op 12.094 us/op 0.88
validate gossip signedAggregateAndProof - struct 5.0207 ms/op 5.0431 ms/op 1.00
validate gossip attestation - struct 2.3643 ms/op 2.3715 ms/op 1.00
altair verifyImport mainnet_s3766816:31 6.8604 s/op 7.1273 s/op 0.96
pickEth1Vote - no votes 2.1474 ms/op 2.2714 ms/op 0.95
pickEth1Vote - max votes 21.629 ms/op 29.644 ms/op 0.73
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.288 ms/op 14.710 ms/op 0.90
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 23.466 ms/op 31.426 ms/op 0.75
pickEth1Vote - Eth1Data fastSerialize value x2048 1.5045 ms/op 1.3996 ms/op 1.07
pickEth1Vote - Eth1Data fastSerialize tree x2048 13.924 ms/op 16.981 ms/op 0.82
bytes32 toHexString 1.0160 us/op 1.1040 us/op 0.92
bytes32 Buffer.toString(hex) 791.00 ns/op 741.00 ns/op 1.07
bytes32 Buffer.toString(hex) from Uint8Array 1.0260 us/op 1.0210 us/op 1.00
bytes32 Buffer.toString(hex) + 0x 793.00 ns/op 743.00 ns/op 1.07
Object access 1 prop 0.45100 ns/op 0.38800 ns/op 1.16
Map access 1 prop 0.44500 ns/op 0.30700 ns/op 1.45
Object get x1000 11.399 ns/op 11.196 ns/op 1.02
Map get x1000 1.0630 ns/op 1.0800 ns/op 0.98
Object set x1000 70.841 ns/op 90.184 ns/op 0.79
Map set x1000 45.455 ns/op 59.228 ns/op 0.77
Return object 10000 times 0.44190 ns/op 0.44130 ns/op 1.00
Throw Error 10000 times 6.0326 us/op 6.0932 us/op 0.99
enrSubnets - fastDeserialize 64 bits 2.6220 us/op 3.1030 us/op 0.84
enrSubnets - ssz BitVector 64 bits 874.00 ns/op 883.00 ns/op 0.99
enrSubnets - fastDeserialize 4 bits 419.00 ns/op 410.00 ns/op 1.02
enrSubnets - ssz BitVector 4 bits 855.00 ns/op 868.00 ns/op 0.99
prioritizePeers score -10:0 att 32-0.1 sync 2-0 79.921 us/op 91.143 us/op 0.88
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 126.03 us/op 137.63 us/op 0.92
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 187.88 us/op 223.94 us/op 0.84
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 390.55 us/op 359.28 us/op 1.09
prioritizePeers score 0:0 att 64-1 sync 4-1 451.06 us/op 455.00 us/op 0.99
RateTracker 1000000 limit, 1 obj count per request 177.29 ns/op 187.85 ns/op 0.94
RateTracker 1000000 limit, 2 obj count per request 129.93 ns/op 140.69 ns/op 0.92
RateTracker 1000000 limit, 4 obj count per request 102.91 ns/op 116.73 ns/op 0.88
RateTracker 1000000 limit, 8 obj count per request 91.553 ns/op 105.15 ns/op 0.87
RateTracker with prune 3.6630 us/op 5.0630 us/op 0.72
array of 16000 items push then shift 51.577 us/op 51.637 us/op 1.00
LinkedList of 16000 items push then shift 16.584 ns/op 21.103 ns/op 0.79
array of 16000 items push then pop 188.40 ns/op 211.21 ns/op 0.89
LinkedList of 16000 items push then pop 14.180 ns/op 16.170 ns/op 0.88
array of 24000 items push then shift 77.323 us/op 77.406 us/op 1.00
LinkedList of 24000 items push then shift 19.347 ns/op 30.199 ns/op 0.64
array of 24000 items push then pop 168.11 ns/op 216.80 ns/op 0.78
LinkedList of 24000 items push then pop 15.863 ns/op 18.417 ns/op 0.86
intersect bitArray bitLen 8 10.919 ns/op 10.642 ns/op 1.03
intersect array and set length 8 126.39 ns/op 155.35 ns/op 0.81
intersect bitArray bitLen 128 55.668 ns/op 55.524 ns/op 1.00
intersect array and set length 128 1.7587 us/op 1.9272 us/op 0.91

by benchmarkbot/action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants