Merge single and multi block processors #4317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
reviewed
Jul 17, 2022
| } | ||
| } catch (e) { | ||
| // above functions should only throw BlockError | ||
| const err = getBlockError(e, blocks[0]); |
There was a problem hiding this comment.
Shouldn't the block error be for the block that errored?
There was a problem hiding this comment.
After completing this work everything is processed in batch so you don't know which block caused the error. Each function should take care of adding the right block to BlockError which is already happening, but here, at this line you have no clue which block caused this. blocks[0] is a placeholder, it shouldn't really happen. In future PRs we can review what to do in this case
wemeetagain
reviewed
Jul 17, 2022
| if (res.err instanceof ChainSegmentError && res.err.importedBlocks > 0) { | ||
| this.advanceChain(batch.startEpoch); | ||
| } | ||
| // TODO: Disabled for now |
There was a problem hiding this comment.
can you make an issue for this? I guess it's a small thing, an optimization to avoid reprocessing up to batch.length - 1 blocks.
There was a problem hiding this comment.
We can do an issue but I don't see this ever being implemented judging for our priorities in the last 2 years. i.e. to help process sync we have tens higher priority items to go after
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Merge single and multi block processors