Update the gossip max chunk size to bellatrix specs #4450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The max allowed chunk size for gossip at/post bellatrix are 10x the normal ones to take care of transaction payloads.
This PR increases the allowed size if bellatrix is configured. There is "gotcha" in this:
For incoming payloads this isn't an issue however for outgoing payloads pre-merge if we send big chunks they might be rejected by other clients. However sizes greater than even
GOSSIP_MAX_SIZEaren't likely.However an issue has been created for it: #4449
Description
Closed #3486