Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network disconnect peers e2e test on CI #4747

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Fix network disconnect peers e2e test on CI #4747

merged 2 commits into from
Nov 10, 2022

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Nov 10, 2022 •
edited
Loading

Motivation

Fix network e2e test on CI

Description

Closes #4744

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: bf0f375 Previous: b9c7bae Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.2469 ms/op 2.4031 ms/op 0.93
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 82.756 us/op 98.684 us/op 0.84
BLS verify - blst-native 2.2334 ms/op 2.4782 ms/op 0.90
BLS verifyMultipleSignatures 3 - blst-native 4.5745 ms/op 5.0740 ms/op 0.90
BLS verifyMultipleSignatures 8 - blst-native 9.8439 ms/op 11.620 ms/op 0.85
BLS verifyMultipleSignatures 32 - blst-native 35.724 ms/op 39.394 ms/op 0.91
BLS aggregatePubkeys 32 - blst-native 47.588 us/op 52.061 us/op 0.91
BLS aggregatePubkeys 128 - blst-native 186.47 us/op 215.85 us/op 0.86
getAttestationsForBlock 98.673 ms/op 97.621 ms/op 1.01
isKnown best case - 1 super set check 503.00 ns/op 473.00 ns/op 1.06
isKnown normal case - 2 super set checks 492.00 ns/op 468.00 ns/op 1.05
isKnown worse case - 16 super set checks 490.00 ns/op 461.00 ns/op 1.06
CheckpointStateCache - add get delete 10.265 us/op 9.9380 us/op 1.03
validate gossip signedAggregateAndProof - struct 5.0976 ms/op 5.7170 ms/op 0.89
validate gossip attestation - struct 2.4377 ms/op 2.7848 ms/op 0.88
pickEth1Vote - no votes 2.4984 ms/op 2.1926 ms/op 1.14
pickEth1Vote - max votes 22.394 ms/op 20.178 ms/op 1.11
pickEth1Vote - Eth1Data hashTreeRoot value x2048 12.811 ms/op 12.844 ms/op 1.00
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.893 ms/op 21.546 ms/op 1.06
pickEth1Vote - Eth1Data fastSerialize value x2048 1.7910 ms/op 1.7802 ms/op 1.01
pickEth1Vote - Eth1Data fastSerialize tree x2048 15.267 ms/op 14.487 ms/op 1.05
bytes32 toHexString 1.2470 us/op 1.1360 us/op 1.10
bytes32 Buffer.toString(hex) 835.00 ns/op 778.00 ns/op 1.07
bytes32 Buffer.toString(hex) from Uint8Array 1.0770 us/op 1.1210 us/op 0.96
bytes32 Buffer.toString(hex) + 0x 821.00 ns/op 865.00 ns/op 0.95
Object access 1 prop 0.41700 ns/op 0.40100 ns/op 1.04
Map access 1 prop 0.35400 ns/op 0.31200 ns/op 1.13
Object get x1000 20.415 ns/op 15.209 ns/op 1.34
Map get x1000 1.1880 ns/op 0.91700 ns/op 1.30
Object set x1000 147.43 ns/op 104.61 ns/op 1.41
Map set x1000 86.832 ns/op 74.918 ns/op 1.16
Return object 10000 times 0.44930 ns/op 0.38240 ns/op 1.17
Throw Error 10000 times 6.9979 us/op 6.5381 us/op 1.07
fastMsgIdFn sha256 / 200 bytes 5.0430 us/op 4.8170 us/op 1.05
fastMsgIdFn h32 xxhash / 200 bytes 644.00 ns/op 598.00 ns/op 1.08
fastMsgIdFn h64 xxhash / 200 bytes 852.00 ns/op 813.00 ns/op 1.05
fastMsgIdFn sha256 / 1000 bytes 15.721 us/op 15.568 us/op 1.01
fastMsgIdFn h32 xxhash / 1000 bytes 850.00 ns/op 744.00 ns/op 1.14
fastMsgIdFn h64 xxhash / 1000 bytes 989.00 ns/op 849.00 ns/op 1.16
fastMsgIdFn sha256 / 10000 bytes 134.11 us/op 150.26 us/op 0.89
fastMsgIdFn h32 xxhash / 10000 bytes 2.8300 us/op 2.6440 us/op 1.07
fastMsgIdFn h64 xxhash / 10000 bytes 2.1250 us/op 2.0190 us/op 1.05
enrSubnets - fastDeserialize 64 bits 3.0140 us/op 2.9730 us/op 1.01
enrSubnets - ssz BitVector 64 bits 906.00 ns/op 776.00 ns/op 1.17
enrSubnets - fastDeserialize 4 bits 481.00 ns/op 413.00 ns/op 1.16
enrSubnets - ssz BitVector 4 bits 902.00 ns/op 817.00 ns/op 1.10
prioritizePeers score -10:0 att 32-0.1 sync 2-0 110.46 us/op 98.745 us/op 1.12
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 145.34 us/op 145.50 us/op 1.00
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 243.58 us/op 263.30 us/op 0.93
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 512.04 us/op 551.34 us/op 0.93
prioritizePeers score 0:0 att 64-1 sync 4-1 547.43 us/op 579.05 us/op 0.95
RateTracker 1000000 limit, 1 obj count per request 219.45 ns/op 190.46 ns/op 1.15
RateTracker 1000000 limit, 2 obj count per request 163.66 ns/op 147.96 ns/op 1.11
RateTracker 1000000 limit, 4 obj count per request 135.29 ns/op 122.60 ns/op 1.10
RateTracker 1000000 limit, 8 obj count per request 121.74 ns/op 106.29 ns/op 1.15
RateTracker with prune 5.2770 us/op 4.9070 us/op 1.08
array of 16000 items push then shift 3.8378 us/op 4.7724 us/op 0.80
LinkedList of 16000 items push then shift 20.222 ns/op 17.810 ns/op 1.14
array of 16000 items push then pop 272.40 ns/op 260.62 ns/op 1.05
LinkedList of 16000 items push then pop 19.810 ns/op 16.401 ns/op 1.21
array of 24000 items push then shift 5.4246 us/op 6.9462 us/op 0.78
LinkedList of 24000 items push then shift 23.043 ns/op 17.817 ns/op 1.29
array of 24000 items push then pop 244.37 ns/op 216.25 ns/op 1.13
LinkedList of 24000 items push then pop 20.666 ns/op 17.038 ns/op 1.21
intersect bitArray bitLen 8 13.897 ns/op 11.719 ns/op 1.19
intersect array and set length 8 190.38 ns/op 184.24 ns/op 1.03
intersect bitArray bitLen 128 86.429 ns/op 66.051 ns/op 1.31
intersect array and set length 128 2.6536 us/op 2.1270 us/op 1.25
Buffer.concat 32 items 2.3100 ns/op 2.1420 ns/op 1.08
pass gossip attestations to forkchoice per slot 4.8050 ms/op 4.0656 ms/op 1.18
computeDeltas 7.0614 ms/op 5.2081 ms/op 1.36
computeProposerBoostScoreFromBalances 1.0856 ms/op 815.27 us/op 1.33
altair processAttestation - 250000 vs - 7PWei normalcase 4.0648 ms/op 4.7173 ms/op 0.86
altair processAttestation - 250000 vs - 7PWei worstcase 6.8395 ms/op 6.4467 ms/op 1.06
altair processAttestation - setStatus - 1/6 committees join 252.13 us/op 225.49 us/op 1.12
altair processAttestation - setStatus - 1/3 committees join 485.81 us/op 440.76 us/op 1.10
altair processAttestation - setStatus - 1/2 committees join 699.67 us/op 665.76 us/op 1.05
altair processAttestation - setStatus - 2/3 committees join 886.90 us/op 794.13 us/op 1.12
altair processAttestation - setStatus - 4/5 committees join 1.2136 ms/op 1.1148 ms/op 1.09
altair processAttestation - setStatus - 100% committees join 1.4436 ms/op 1.3242 ms/op 1.09
altair processBlock - 250000 vs - 7PWei normalcase 30.878 ms/op 28.760 ms/op 1.07
altair processBlock - 250000 vs - 7PWei normalcase hashState 43.178 ms/op 40.847 ms/op 1.06
altair processBlock - 250000 vs - 7PWei worstcase 94.310 ms/op 97.275 ms/op 0.97
altair processBlock - 250000 vs - 7PWei worstcase hashState 114.39 ms/op 116.77 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei normalcase 4.3465 ms/op 4.3884 ms/op 0.99
phase0 processBlock - 250000 vs - 7PWei worstcase 54.600 ms/op 57.432 ms/op 0.95
altair processEth1Data - 250000 vs - 7PWei normalcase 1.0092 ms/op 1.0397 ms/op 0.97
Tree 40 250000 create 892.11 ms/op 916.42 ms/op 0.97
Tree 40 250000 get(125000) 338.38 ns/op 291.92 ns/op 1.16
Tree 40 250000 set(125000) 2.8193 us/op 2.7505 us/op 1.03
Tree 40 250000 toArray() 37.418 ms/op 34.158 ms/op 1.10
Tree 40 250000 iterate all - toArray() + loop 37.678 ms/op 33.935 ms/op 1.11
Tree 40 250000 iterate all - get(i) 131.78 ms/op 121.89 ms/op 1.08
MutableVector 250000 create 20.487 ms/op 17.390 ms/op 1.18
MutableVector 250000 get(125000) 15.680 ns/op 13.662 ns/op 1.15
MutableVector 250000 set(125000) 718.50 ns/op 781.62 ns/op 0.92
MutableVector 250000 toArray() 8.4966 ms/op 6.6622 ms/op 1.28
MutableVector 250000 iterate all - toArray() + loop 8.5776 ms/op 6.8266 ms/op 1.26
MutableVector 250000 iterate all - get(i) 4.1254 ms/op 3.1624 ms/op 1.30
Array 250000 create 7.9502 ms/op 6.5089 ms/op 1.22
Array 250000 clone - spread 4.3188 ms/op 4.0137 ms/op 1.08
Array 250000 get(125000) 1.8540 ns/op 1.5600 ns/op 1.19
Array 250000 set(125000) 1.8320 ns/op 1.7320 ns/op 1.06
Array 250000 iterate all - loop 201.60 us/op 135.79 us/op 1.48
effectiveBalanceIncrements clone Uint8Array 300000 93.881 us/op 199.50 us/op 0.47
effectiveBalanceIncrements clone MutableVector 300000 1.3200 us/op 742.00 ns/op 1.78
effectiveBalanceIncrements rw all Uint8Array 300000 303.16 us/op 269.95 us/op 1.12
effectiveBalanceIncrements rw all MutableVector 300000 234.45 ms/op 204.87 ms/op 1.14
phase0 afterProcessEpoch - 250000 vs - 7PWei 224.71 ms/op 199.70 ms/op 1.13
phase0 beforeProcessEpoch - 250000 vs - 7PWei 120.04 ms/op 74.139 ms/op 1.62
altair processEpoch - mainnet_e81889 679.82 ms/op 629.19 ms/op 1.08
mainnet_e81889 - altair beforeProcessEpoch 181.16 ms/op 148.23 ms/op 1.22
mainnet_e81889 - altair processJustificationAndFinalization 37.567 us/op 75.323 us/op 0.50
mainnet_e81889 - altair processInactivityUpdates 12.937 ms/op 10.621 ms/op 1.22
mainnet_e81889 - altair processRewardsAndPenalties 103.95 ms/op 97.401 ms/op 1.07
mainnet_e81889 - altair processRegistryUpdates 6.9190 us/op 23.830 us/op 0.29
mainnet_e81889 - altair processSlashings 1.8560 us/op 4.6760 us/op 0.40
mainnet_e81889 - altair processEth1DataReset 1.8250 us/op 7.4780 us/op 0.24
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.8990 ms/op 2.5896 ms/op 1.12
mainnet_e81889 - altair processSlashingsReset 16.273 us/op 36.505 us/op 0.45
mainnet_e81889 - altair processRandaoMixesReset 13.673 us/op 33.863 us/op 0.40
mainnet_e81889 - altair processHistoricalRootsUpdate 2.8360 us/op 5.7820 us/op 0.49
mainnet_e81889 - altair processParticipationFlagUpdates 9.1190 us/op 18.773 us/op 0.49
mainnet_e81889 - altair processSyncCommitteeUpdates 1.4910 us/op 5.8240 us/op 0.26
mainnet_e81889 - altair afterProcessEpoch 236.57 ms/op 192.88 ms/op 1.23
phase0 processEpoch - mainnet_e58758 609.60 ms/op 600.20 ms/op 1.02
mainnet_e58758 - phase0 beforeProcessEpoch 253.59 ms/op 276.23 ms/op 0.92
mainnet_e58758 - phase0 processJustificationAndFinalization 28.866 us/op 81.956 us/op 0.35
mainnet_e58758 - phase0 processRewardsAndPenalties 145.53 ms/op 150.17 ms/op 0.97
mainnet_e58758 - phase0 processRegistryUpdates 16.312 us/op 57.647 us/op 0.28
mainnet_e58758 - phase0 processSlashings 1.6200 us/op 4.2080 us/op 0.38
mainnet_e58758 - phase0 processEth1DataReset 1.5700 us/op 6.1100 us/op 0.26
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.6704 ms/op 1.9846 ms/op 1.35
mainnet_e58758 - phase0 processSlashingsReset 7.5680 us/op 32.824 us/op 0.23
mainnet_e58758 - phase0 processRandaoMixesReset 14.361 us/op 46.046 us/op 0.31
mainnet_e58758 - phase0 processHistoricalRootsUpdate 2.1890 us/op 7.3790 us/op 0.30
mainnet_e58758 - phase0 processParticipationRecordUpdates 11.543 us/op 29.209 us/op 0.40
mainnet_e58758 - phase0 afterProcessEpoch 194.31 ms/op 157.52 ms/op 1.23
phase0 processEffectiveBalanceUpdates - 250000 normalcase 3.0892 ms/op 2.2662 ms/op 1.36
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.8608 ms/op 2.5267 ms/op 1.53
altair processInactivityUpdates - 250000 normalcase 44.997 ms/op 50.580 ms/op 0.89
altair processInactivityUpdates - 250000 worstcase 55.009 ms/op 59.706 ms/op 0.92
phase0 processRegistryUpdates - 250000 normalcase 15.060 us/op 55.434 us/op 0.27
phase0 processRegistryUpdates - 250000 badcase_full_deposits 655.82 us/op 556.63 us/op 1.18
phase0 processRegistryUpdates - 250000 worstcase 0.5 241.02 ms/op 234.85 ms/op 1.03
altair processRewardsAndPenalties - 250000 normalcase 124.29 ms/op 144.32 ms/op 0.86
altair processRewardsAndPenalties - 250000 worstcase 93.275 ms/op 133.83 ms/op 0.70
phase0 getAttestationDeltas - 250000 normalcase 15.327 ms/op 13.602 ms/op 1.13
phase0 getAttestationDeltas - 250000 worstcase 15.471 ms/op 13.234 ms/op 1.17
phase0 processSlashings - 250000 worstcase 6.6814 ms/op 6.6323 ms/op 1.01
altair processSyncCommitteeUpdates - 250000 328.58 ms/op 312.53 ms/op 1.05
BeaconState.hashTreeRoot - No change 609.00 ns/op 564.00 ns/op 1.08
BeaconState.hashTreeRoot - 1 full validator 70.545 us/op 73.568 us/op 0.96
BeaconState.hashTreeRoot - 32 full validator 743.13 us/op 887.86 us/op 0.84
BeaconState.hashTreeRoot - 512 full validator 7.1188 ms/op 7.7891 ms/op 0.91
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 102.10 us/op 100.40 us/op 1.02
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.5576 ms/op 1.5520 ms/op 1.00
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 17.953 ms/op 18.638 ms/op 0.96
BeaconState.hashTreeRoot - 1 balances 72.695 us/op 72.082 us/op 1.01
BeaconState.hashTreeRoot - 32 balances 695.64 us/op 700.03 us/op 0.99
BeaconState.hashTreeRoot - 512 balances 6.8867 ms/op 6.6448 ms/op 1.04
BeaconState.hashTreeRoot - 250000 balances 113.15 ms/op 96.574 ms/op 1.17
aggregationBits - 2048 els - zipIndexesInBitList 41.204 us/op 33.468 us/op 1.23
regular array get 100000 times 81.107 us/op 51.747 us/op 1.57
wrappedArray get 100000 times 80.907 us/op 51.169 us/op 1.58
arrayWithProxy get 100000 times 34.443 ms/op 31.601 ms/op 1.09
ssz.Root.equals 602.00 ns/op 517.00 ns/op 1.16
byteArrayEquals 593.00 ns/op 509.00 ns/op 1.17
shuffle list - 16384 els 13.715 ms/op 10.859 ms/op 1.26
shuffle list - 250000 els 200.54 ms/op 164.43 ms/op 1.22
processSlot - 1 slots 17.423 us/op 15.782 us/op 1.10
processSlot - 32 slots 2.0490 ms/op 2.1355 ms/op 0.96
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 474.24 us/op 441.40 us/op 1.07
getCommitteeAssignments - req 1 vs - 250000 vc 6.3431 ms/op 5.0718 ms/op 1.25
getCommitteeAssignments - req 100 vs - 250000 vc 8.7674 ms/op 7.0962 ms/op 1.24
getCommitteeAssignments - req 1000 vs - 250000 vc 9.5144 ms/op 7.4555 ms/op 1.28
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 11.710 ns/op 8.3000 ns/op 1.41
state getBlockRootAtSlot - 250000 vs - 7PWei 1.3171 us/op 1.1452 us/op 1.15
computeProposers - vc 250000 19.413 ms/op 19.843 ms/op 0.98
computeEpochShuffling - vc 250000 203.75 ms/op 166.11 ms/op 1.23
getNextSyncCommittee - vc 250000 325.60 ms/op 320.64 ms/op 1.02

by benchmarkbot/action

@twoeths twoeths marked this pull request as ready for review November 10, 2022 12:48
@twoeths twoeths requested a review from a team as a code owner November 10, 2022 12:48
@twoeths
Copy link
Contributor Author

twoeths commented Nov 10, 2022

the only failed e2e test in this PR is #4746

@wemeetagain wemeetagain enabled auto-merge (squash) November 10, 2022 15:59
@wemeetagain wemeetagain merged commit 07e02aa into unstable Nov 10, 2022
@wemeetagain wemeetagain deleted the tuyen/fix-network-e2e branch November 10, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed network e2e test on CI
2 participants
@twoeths @wemeetagain