Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add firefox setup to CI pipeline #4802

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Add firefox setup to CI pipeline #4802

merged 1 commit into from
Nov 23, 2022

Conversation

nazarhussain
Copy link
Contributor

@nazarhussain nazarhussain commented Nov 23, 2022 •
edited
Loading

Motivation

Fix the browser tests.

Description

Fix the browser tests failing with firefox error.

Closes: #4795

Closes #issue_number

Steps to test or reproduce

Run browser tests.

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 4c3b931 Previous: 13190d2 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.1979 ms/op 2.6689 ms/op 0.82
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 79.314 us/op 109.04 us/op 0.73
BLS verify - blst-native 2.1709 ms/op 1.9741 ms/op 1.10
BLS verifyMultipleSignatures 3 - blst-native 4.4788 ms/op 4.0913 ms/op 1.09
BLS verifyMultipleSignatures 8 - blst-native 9.5212 ms/op 8.8892 ms/op 1.07
BLS verifyMultipleSignatures 32 - blst-native 34.805 ms/op 30.875 ms/op 1.13
BLS aggregatePubkeys 32 - blst-native 47.135 us/op 40.893 us/op 1.15
BLS aggregatePubkeys 128 - blst-native 181.21 us/op 168.88 us/op 1.07
getAttestationsForBlock 104.50 ms/op 109.05 ms/op 0.96
isKnown best case - 1 super set check 509.00 ns/op 489.00 ns/op 1.04
isKnown normal case - 2 super set checks 514.00 ns/op 453.00 ns/op 1.13
isKnown worse case - 16 super set checks 499.00 ns/op 425.00 ns/op 1.17
CheckpointStateCache - add get delete 10.420 us/op 10.252 us/op 1.02
validate gossip signedAggregateAndProof - struct 5.1652 ms/op 4.7310 ms/op 1.09
validate gossip attestation - struct 2.4526 ms/op 2.1474 ms/op 1.14
pickEth1Vote - no votes 2.6107 ms/op 2.2393 ms/op 1.17
pickEth1Vote - max votes 23.406 ms/op 21.680 ms/op 1.08
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.264 ms/op 12.924 ms/op 1.03
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 23.214 ms/op 20.529 ms/op 1.13
pickEth1Vote - Eth1Data fastSerialize value x2048 1.8205 ms/op 1.5352 ms/op 1.19
pickEth1Vote - Eth1Data fastSerialize tree x2048 14.942 ms/op 15.149 ms/op 0.99
bytes32 toHexString 1.1980 us/op 1.2230 us/op 0.98
bytes32 Buffer.toString(hex) 812.00 ns/op 735.00 ns/op 1.10
bytes32 Buffer.toString(hex) from Uint8Array 1.1370 us/op 1.0320 us/op 1.10
bytes32 Buffer.toString(hex) + 0x 826.00 ns/op 748.00 ns/op 1.10
Object access 1 prop 0.41700 ns/op 0.39300 ns/op 1.06
Map access 1 prop 0.34500 ns/op 0.33100 ns/op 1.04
Object get x1000 20.432 ns/op 16.200 ns/op 1.26
Map get x1000 1.1930 ns/op 0.95200 ns/op 1.25
Object set x1000 141.00 ns/op 104.15 ns/op 1.35
Map set x1000 88.393 ns/op 74.151 ns/op 1.19
Return object 10000 times 0.45270 ns/op 0.38510 ns/op 1.18
Throw Error 10000 times 7.0909 us/op 6.2098 us/op 1.14
fastMsgIdFn sha256 / 200 bytes 4.9900 us/op 4.6280 us/op 1.08
fastMsgIdFn h32 xxhash / 200 bytes 629.00 ns/op 555.00 ns/op 1.13
fastMsgIdFn h64 xxhash / 200 bytes 837.00 ns/op 965.00 ns/op 0.87
fastMsgIdFn sha256 / 1000 bytes 15.785 us/op 14.817 us/op 1.07
fastMsgIdFn h32 xxhash / 1000 bytes 805.00 ns/op 775.00 ns/op 1.04
fastMsgIdFn h64 xxhash / 1000 bytes 980.00 ns/op 1.0060 us/op 0.97
fastMsgIdFn sha256 / 10000 bytes 130.71 us/op 126.50 us/op 1.03
fastMsgIdFn h32 xxhash / 10000 bytes 2.7120 us/op 2.5090 us/op 1.08
fastMsgIdFn h64 xxhash / 10000 bytes 1.9380 us/op 1.8600 us/op 1.04
enrSubnets - fastDeserialize 64 bits 2.9220 us/op 2.5200 us/op 1.16
enrSubnets - ssz BitVector 64 bits 859.00 ns/op 723.00 ns/op 1.19
enrSubnets - fastDeserialize 4 bits 443.00 ns/op 364.00 ns/op 1.22
enrSubnets - ssz BitVector 4 bits 872.00 ns/op 747.00 ns/op 1.17
prioritizePeers score -10:0 att 32-0.1 sync 2-0 104.94 us/op 96.142 us/op 1.09
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 154.30 us/op 144.11 us/op 1.07
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 252.08 us/op 262.27 us/op 0.96
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 450.62 us/op 592.89 us/op 0.76
prioritizePeers score 0:0 att 64-1 sync 4-1 544.05 us/op 478.04 us/op 1.14
RateTracker 1000000 limit, 1 obj count per request 217.44 ns/op 181.28 ns/op 1.20
RateTracker 1000000 limit, 2 obj count per request 158.47 ns/op 138.54 ns/op 1.14
RateTracker 1000000 limit, 4 obj count per request 133.12 ns/op 113.01 ns/op 1.18
RateTracker 1000000 limit, 8 obj count per request 117.44 ns/op 97.074 ns/op 1.21
RateTracker with prune 4.7620 us/op 4.5380 us/op 1.05
array of 16000 items push then shift 3.2540 us/op 4.7784 us/op 0.68
LinkedList of 16000 items push then shift 20.129 ns/op 17.493 ns/op 1.15
array of 16000 items push then pop 269.64 ns/op 249.82 ns/op 1.08
LinkedList of 16000 items push then pop 19.278 ns/op 16.542 ns/op 1.17
array of 24000 items push then shift 4.7248 us/op 6.7795 us/op 0.70
LinkedList of 24000 items push then shift 22.885 ns/op 19.188 ns/op 1.19
array of 24000 items push then pop 241.39 ns/op 216.97 ns/op 1.11
LinkedList of 24000 items push then pop 20.224 ns/op 20.106 ns/op 1.01
intersect bitArray bitLen 8 13.554 ns/op 14.516 ns/op 0.93
intersect array and set length 8 185.12 ns/op 211.99 ns/op 0.87
intersect bitArray bitLen 128 71.503 ns/op 76.269 ns/op 0.94
intersect array and set length 128 2.6234 us/op 2.3977 us/op 1.09
Buffer.concat 32 items 2.1830 ns/op 2.3110 ns/op 0.94
pass gossip attestations to forkchoice per slot 4.7971 ms/op 4.2890 ms/op 1.12
computeDeltas 6.5381 ms/op 5.6934 ms/op 1.15
computeProposerBoostScoreFromBalances 1.0803 ms/op 799.50 us/op 1.35
altair processAttestation - 250000 vs - 7PWei normalcase 4.4176 ms/op 4.7966 ms/op 0.92
altair processAttestation - 250000 vs - 7PWei worstcase 6.7207 ms/op 7.0793 ms/op 0.95
altair processAttestation - setStatus - 1/6 committees join 236.50 us/op 229.42 us/op 1.03
altair processAttestation - setStatus - 1/3 committees join 483.23 us/op 429.62 us/op 1.12
altair processAttestation - setStatus - 1/2 committees join 650.27 us/op 613.53 us/op 1.06
altair processAttestation - setStatus - 2/3 committees join 847.55 us/op 847.05 us/op 1.00
altair processAttestation - setStatus - 4/5 committees join 1.1486 ms/op 1.1847 ms/op 0.97
altair processAttestation - setStatus - 100% committees join 1.4220 ms/op 1.4401 ms/op 0.99
altair processBlock - 250000 vs - 7PWei normalcase 32.168 ms/op 30.051 ms/op 1.07
altair processBlock - 250000 vs - 7PWei normalcase hashState 43.884 ms/op 42.442 ms/op 1.03
altair processBlock - 250000 vs - 7PWei worstcase 95.992 ms/op 90.679 ms/op 1.06
altair processBlock - 250000 vs - 7PWei worstcase hashState 118.68 ms/op 105.77 ms/op 1.12
phase0 processBlock - 250000 vs - 7PWei normalcase 4.1791 ms/op 3.9897 ms/op 1.05
phase0 processBlock - 250000 vs - 7PWei worstcase 54.343 ms/op 49.045 ms/op 1.11
altair processEth1Data - 250000 vs - 7PWei normalcase 1.0859 ms/op 1.0771 ms/op 1.01
Tree 40 250000 create 890.95 ms/op 929.34 ms/op 0.96
Tree 40 250000 get(125000) 335.50 ns/op 293.35 ns/op 1.14
Tree 40 250000 set(125000) 2.9929 us/op 3.2405 us/op 0.92
Tree 40 250000 toArray() 37.654 ms/op 32.881 ms/op 1.15
Tree 40 250000 iterate all - toArray() + loop 37.652 ms/op 34.768 ms/op 1.08
Tree 40 250000 iterate all - get(i) 130.17 ms/op 123.65 ms/op 1.05
MutableVector 250000 create 20.093 ms/op 16.200 ms/op 1.24
MutableVector 250000 get(125000) 15.837 ns/op 12.685 ns/op 1.25
MutableVector 250000 set(125000) 742.57 ns/op 843.18 ns/op 0.88
MutableVector 250000 toArray() 8.7714 ms/op 7.2787 ms/op 1.21
MutableVector 250000 iterate all - toArray() + loop 8.9556 ms/op 8.4820 ms/op 1.06
MutableVector 250000 iterate all - get(i) 3.8889 ms/op 3.8580 ms/op 1.01
Array 250000 create 7.9962 ms/op 6.5451 ms/op 1.22
Array 250000 clone - spread 4.4720 ms/op 2.8139 ms/op 1.59
Array 250000 get(125000) 1.9740 ns/op 1.1480 ns/op 1.72
Array 250000 set(125000) 1.8930 ns/op 1.0980 ns/op 1.72
Array 250000 iterate all - loop 199.46 us/op 126.67 us/op 1.57
effectiveBalanceIncrements clone Uint8Array 300000 94.286 us/op 213.56 us/op 0.44
effectiveBalanceIncrements clone MutableVector 300000 723.00 ns/op 696.00 ns/op 1.04
effectiveBalanceIncrements rw all Uint8Array 300000 295.35 us/op 274.25 us/op 1.08
effectiveBalanceIncrements rw all MutableVector 300000 178.55 ms/op 180.19 ms/op 0.99
phase0 afterProcessEpoch - 250000 vs - 7PWei 229.29 ms/op 176.21 ms/op 1.30
phase0 beforeProcessEpoch - 250000 vs - 7PWei 81.250 ms/op 79.067 ms/op 1.03
altair processEpoch - mainnet_e81889 673.97 ms/op 605.48 ms/op 1.11
mainnet_e81889 - altair beforeProcessEpoch 182.20 ms/op 164.09 ms/op 1.11
mainnet_e81889 - altair processJustificationAndFinalization 40.831 us/op 65.354 us/op 0.62
mainnet_e81889 - altair processInactivityUpdates 12.535 ms/op 10.635 ms/op 1.18
mainnet_e81889 - altair processRewardsAndPenalties 106.73 ms/op 103.00 ms/op 1.04
mainnet_e81889 - altair processRegistryUpdates 8.4100 us/op 13.262 us/op 0.63
mainnet_e81889 - altair processSlashings 2.3910 us/op 3.7700 us/op 0.63
mainnet_e81889 - altair processEth1DataReset 2.3590 us/op 3.7360 us/op 0.63
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.9724 ms/op 2.4122 ms/op 1.23
mainnet_e81889 - altair processSlashingsReset 12.538 us/op 24.618 us/op 0.51
mainnet_e81889 - altair processRandaoMixesReset 14.351 us/op 25.762 us/op 0.56
mainnet_e81889 - altair processHistoricalRootsUpdate 2.4680 us/op 3.7660 us/op 0.66
mainnet_e81889 - altair processParticipationFlagUpdates 6.4830 us/op 16.528 us/op 0.39
mainnet_e81889 - altair processSyncCommitteeUpdates 1.7880 us/op 3.1640 us/op 0.57
mainnet_e81889 - altair afterProcessEpoch 229.72 ms/op 201.33 ms/op 1.14
phase0 processEpoch - mainnet_e58758 607.64 ms/op 594.69 ms/op 1.02
mainnet_e58758 - phase0 beforeProcessEpoch 261.35 ms/op 255.16 ms/op 1.02
mainnet_e58758 - phase0 processJustificationAndFinalization 37.375 us/op 57.516 us/op 0.65
mainnet_e58758 - phase0 processRewardsAndPenalties 172.16 ms/op 82.152 ms/op 2.10
mainnet_e58758 - phase0 processRegistryUpdates 21.042 us/op 29.457 us/op 0.71
mainnet_e58758 - phase0 processSlashings 1.6360 us/op 2.6070 us/op 0.63
mainnet_e58758 - phase0 processEth1DataReset 2.4870 us/op 2.9280 us/op 0.85
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.4138 ms/op 2.0450 ms/op 1.18
mainnet_e58758 - phase0 processSlashingsReset 9.8870 us/op 14.568 us/op 0.68
mainnet_e58758 - phase0 processRandaoMixesReset 15.663 us/op 21.703 us/op 0.72
mainnet_e58758 - phase0 processHistoricalRootsUpdate 2.3690 us/op 3.7690 us/op 0.63
mainnet_e58758 - phase0 processParticipationRecordUpdates 11.708 us/op 23.008 us/op 0.51
mainnet_e58758 - phase0 afterProcessEpoch 188.75 ms/op 159.56 ms/op 1.18
phase0 processEffectiveBalanceUpdates - 250000 normalcase 3.0927 ms/op 2.2743 ms/op 1.36
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.7746 ms/op 2.5209 ms/op 1.50
altair processInactivityUpdates - 250000 normalcase 46.680 ms/op 47.487 ms/op 0.98
altair processInactivityUpdates - 250000 worstcase 57.474 ms/op 50.562 ms/op 1.14
phase0 processRegistryUpdates - 250000 normalcase 17.150 us/op 26.835 us/op 0.64
phase0 processRegistryUpdates - 250000 badcase_full_deposits 545.23 us/op 544.17 us/op 1.00
phase0 processRegistryUpdates - 250000 worstcase 0.5 247.89 ms/op 274.71 ms/op 0.90
altair processRewardsAndPenalties - 250000 normalcase 166.16 ms/op 88.055 ms/op 1.89
altair processRewardsAndPenalties - 250000 worstcase 125.43 ms/op 144.88 ms/op 0.87
phase0 getAttestationDeltas - 250000 normalcase 15.374 ms/op 12.767 ms/op 1.20
phase0 getAttestationDeltas - 250000 worstcase 14.980 ms/op 13.606 ms/op 1.10
phase0 processSlashings - 250000 worstcase 6.3113 ms/op 6.1698 ms/op 1.02
altair processSyncCommitteeUpdates - 250000 321.18 ms/op 323.71 ms/op 0.99
BeaconState.hashTreeRoot - No change 561.00 ns/op 597.00 ns/op 0.94
BeaconState.hashTreeRoot - 1 full validator 71.383 us/op 68.485 us/op 1.04
BeaconState.hashTreeRoot - 32 full validator 734.55 us/op 776.32 us/op 0.95
BeaconState.hashTreeRoot - 512 full validator 9.2023 ms/op 7.2495 ms/op 1.27
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 92.757 us/op 92.584 us/op 1.00
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.3464 ms/op 1.4333 ms/op 0.94
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 18.329 ms/op 18.451 ms/op 0.99
BeaconState.hashTreeRoot - 1 balances 74.269 us/op 71.037 us/op 1.05
BeaconState.hashTreeRoot - 32 balances 680.62 us/op 796.29 us/op 0.85
BeaconState.hashTreeRoot - 512 balances 6.5515 ms/op 6.2179 ms/op 1.05
BeaconState.hashTreeRoot - 250000 balances 112.89 ms/op 99.458 ms/op 1.14
aggregationBits - 2048 els - zipIndexesInBitList 30.145 us/op 32.882 us/op 0.92
regular array get 100000 times 78.839 us/op 51.474 us/op 1.53
wrappedArray get 100000 times 79.169 us/op 54.015 us/op 1.47
arrayWithProxy get 100000 times 33.478 ms/op 32.859 ms/op 1.02
ssz.Root.equals 543.00 ns/op 556.00 ns/op 0.98
byteArrayEquals 520.00 ns/op 527.00 ns/op 0.99
shuffle list - 16384 els 12.954 ms/op 10.669 ms/op 1.21
shuffle list - 250000 els 187.50 ms/op 153.57 ms/op 1.22
processSlot - 1 slots 14.608 us/op 16.311 us/op 0.90
processSlot - 32 slots 1.9920 ms/op 2.3309 ms/op 0.85
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 437.11 us/op 383.26 us/op 1.14
getCommitteeAssignments - req 1 vs - 250000 vc 6.0996 ms/op 4.8205 ms/op 1.27
getCommitteeAssignments - req 100 vs - 250000 vc 8.4232 ms/op 7.6984 ms/op 1.09
getCommitteeAssignments - req 1000 vs - 250000 vc 9.2111 ms/op 7.9885 ms/op 1.15
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 12.200 ns/op 9.2600 ns/op 1.32
state getBlockRootAtSlot - 250000 vs - 7PWei 1.2960 us/op 1.3403 us/op 0.97
computeProposers - vc 250000 19.528 ms/op 20.553 ms/op 0.95
computeEpochShuffling - vc 250000 191.34 ms/op 166.39 ms/op 1.15
getNextSyncCommittee - vc 250000 320.53 ms/op 325.38 ms/op 0.99

by benchmarkbot/action

@nazarhussain nazarhussain marked this pull request as ready for review November 23, 2022 11:40
@nazarhussain nazarhussain requested a review from a team as a code owner November 23, 2022 11:40
@nazarhussain
Copy link
Contributor Author

Could not found why CI stopped working all of a sudden and Firefox got missing. Now added the firefox setup manually.

@dapplion dapplion enabled auto-merge (squash) November 23, 2022 11:43
@dapplion dapplion merged commit 3373687 into unstable Nov 23, 2022
@dapplion dapplion deleted the nh/browser-tests-firefox branch November 23, 2022 11:51
dapplion pushed a commit that referenced this pull request Nov 23, 2022
@nazarhussain @dapplion
Add firefox setup to CI pipeline (#4802)
166e706
dapplion added a commit that referenced this pull request Nov 23, 2022
@dapplion @nazarhussain
Release v1.2.2 (#4804)
f093b46 
* Schedule gnosis merge

* v1.2.2

* Add firefox setup to CI pipeline (#4802)

Co-authored-by: Nazar Hussain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser tests failed in CI:
2 participants
@nazarhussain @dapplion