Fix prometheus in local metrics docker setup #5123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Dockerized setup to collect metrics from local beacon node and validator client is broken
Description
need to set in
environment
now instead ofargs
else default values set in Dockerfile will be usedlodestar/docker/prometheus/Dockerfile
Lines 11 to 13 in d5e05d3
also fixed default value for
VC_URL
to use default metric portOne other thing, the local grafana docker build is also broken but not sure how to go about that and I think the issue is already known
this is not docker build compliant
lodestar/docker/grafana/Dockerfile
Lines 10 to 11 in d5e05d3
should not rely on
buildx
features here if possible