Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prometheus in local metrics docker setup #5123

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Feb 9, 2023

Motivation

Dockerized setup to collect metrics from local beacon node and validator client is broken

Description

need to set in environment now instead of args else default values set in Dockerfile will be used

ENV BEACON_URL='beacon_node:8008'
ENV VC_URL='validator'
VOLUME /prometheus

also fixed default value for VC_URL to use default metric port

One other thing, the local grafana docker build is also broken but not sure how to go about that and I think the issue is already known

this is not docker build compliant

# copy over some reasonable default dashboards, user can mount a volume over top of it
COPY --from=dashboards . /dashboards/

should not rely on buildx features here if possible

@nflaig nflaig requested a review from a team as a code owner February 9, 2023 20:52
@wemeetagain
Copy link
Member

Agree the reliance on buildx is not good. Open to suggestions to make life easier

@wemeetagain wemeetagain merged commit 914397a into ChainSafe:unstable Feb 10, 2023
@nflaig
Copy link
Member Author

nflaig commented Feb 11, 2023

@wemeetagain I am not sure if there is a approach without some trade-offs, at the moment running docker-compose -f docker/docker-compose.local.yml up -d will fail due to as it tries to load dashboards from docker.io/library/dashboards:latest.
To make the build work have to comment out this line COPY --from=dashboards . /dashboards/ which is not ideal.

I see two possible solutions for this

  1. move the build context to root folder which would allow to copy dashboards without relying on buildx
  2. publish a separate image chainsafe/lodestar-dashboards which just bundles the dashboards then load the dashboards from that image. This image could potentially also be useful for 3rd party services which want to make use of lodestar dashboards in their custom builds.

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants