Fix reorg depth count #5160
Merged
Fix reorg depth count #5160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts and the common ancestor slot (ChainSafe#5136)
wemeetagain
reviewed
Feb 16, 2023
wemeetagain
reviewed
Feb 16, 2023
| @@ -767,7 +767,7 @@ export class ForkChoice implements IForkChoice { | |||
| return blocksAtSlot; | |||
| } | |||
|
|
|||
| /** Returns the distance of common ancestor of nodes to newNode. Returns null if newNode is descendant of prevNode */ | |||
| /** Returns the distance of common ancestor of nodes to the max of the newNode and the prevNode. Returns null if newNode is descendant of prevNode */ | |||
There was a problem hiding this comment.
Seems this null comment is stale. Can you just remove it?
There was a problem hiding this comment.
Line 781 suggests the noCommonAncestor error code is equivalent to a null response which is why I left it
There was a problem hiding this comment.
I think that comment was from before we returned a AncestorResult.
wemeetagain
reviewed
Feb 16, 2023
wemeetagain
approved these changes
Feb 16, 2023
|
🎉 This PR is included in v1.6.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5136