Simplify INetwork Interface #5187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
reviewed
Feb 21, 2023
| @@ -122,6 +122,21 @@ export type GossipModules = { | |||
| chain: IBeaconChain; | |||
| }; | |||
|
|
|||
| export type GossipBeaconNode = { | |||
There was a problem hiding this comment.
shouldn't this rather be an interface?
There was a problem hiding this comment.
Definitely could be an interface. I don't know that we have clear project-wide opinions on the use of one vs the either.
There was a problem hiding this comment.
IMO if it is implemented by a class within the project directly or even outside in an external library I would use interface otherwise should just use type
There was a problem hiding this comment.
Yeah, type here is a bit sloppy. Can clean it up in a future PR.
I'm continuing to do some work to clean this up, aiming to move the network to a worker, so will continue touching these pieces of code.
Comment on lines
+52
to
+58
| networkStub.getMetadata.returns( | ||
| Promise.resolve({ | ||
| attnets: BitArray.fromBoolArray([true]), | ||
| syncnets: BitArray.fromBitLen(0), | ||
| seqNumber: BigInt(1), | ||
| }) | ||
| ); |
There was a problem hiding this comment.
might just be able to do
Suggested change
| networkStub.getMetadata.returns( | |
| Promise.resolve({ | |
| attnets: BitArray.fromBoolArray([true]), | |
| syncnets: BitArray.fromBitLen(0), | |
| seqNumber: BigInt(1), | |
| }) | |
| ); | |
| networkStub.getMetadata.resolves( | |
| attnets: BitArray.fromBoolArray([true]), | |
| syncnets: BitArray.fromBitLen(0), | |
| seqNumber: BigInt(1), | |
| ); |
there are more cases below
|
Noted we should probably have two classes, one interacting with everything else in the main thread and one for the worker - main thread comms |
|
🎉 This PR is included in v1.6.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Another step towards #4856
The
INetworkclass should be simplified in preparation for moving it to a worker.Description
GossipsubBeaconNode