Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow new release create-rc based off stable branch #5209

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Allow new release create-rc based off stable branch #5209

merged 1 commit into from
Feb 27, 2023

Conversation

wemeetagain
Copy link
Member

Motivation

1.5.0 will be similar to a hotfix that might otherwise be released as 1.4.4, but will include some fixes that require a breaking change. Our release scripts assume that all new releases will be based on the unstable branch.
Update the release:create-rc script to allow future releases to happen more easily.

Description

@wemeetagain wemeetagain requested a review from a team as a code owner February 27, 2023 18:42
g11tech
g11tech approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go!

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 90fb4c9 Previous: 6429685 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 472.13 us/op 501.82 us/op 0.94
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 44.780 us/op 47.651 us/op 0.94
BLS verify - blst-native 1.1984 ms/op 1.2347 ms/op 0.97
BLS verifyMultipleSignatures 3 - blst-native 2.4418 ms/op 2.4597 ms/op 0.99
BLS verifyMultipleSignatures 8 - blst-native 5.3717 ms/op 5.2457 ms/op 1.02
BLS verifyMultipleSignatures 32 - blst-native 19.252 ms/op 19.187 ms/op 1.00
BLS aggregatePubkeys 32 - blst-native 25.773 us/op 25.852 us/op 1.00
BLS aggregatePubkeys 128 - blst-native 101.05 us/op 99.981 us/op 1.01
getAttestationsForBlock 56.945 ms/op 52.230 ms/op 1.09
isKnown best case - 1 super set check 270.00 ns/op 266.00 ns/op 1.02
isKnown normal case - 2 super set checks 266.00 ns/op 261.00 ns/op 1.02
isKnown worse case - 16 super set checks 252.00 ns/op 255.00 ns/op 0.99
CheckpointStateCache - add get delete 5.4010 us/op 5.2070 us/op 1.04
validate gossip signedAggregateAndProof - struct 2.7872 ms/op 2.7806 ms/op 1.00
validate gossip attestation - struct 1.3679 ms/op 1.3248 ms/op 1.03
pickEth1Vote - no votes 1.2747 ms/op 1.2324 ms/op 1.03
pickEth1Vote - max votes 11.061 ms/op 10.539 ms/op 1.05
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.1722 ms/op 8.6177 ms/op 1.06
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.060 ms/op 14.883 ms/op 0.94
pickEth1Vote - Eth1Data fastSerialize value x2048 636.84 us/op 637.53 us/op 1.00
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.9350 ms/op 8.0863 ms/op 0.86
bytes32 toHexString 530.00 ns/op 518.00 ns/op 1.02
bytes32 Buffer.toString(hex) 375.00 ns/op 346.00 ns/op 1.08
bytes32 Buffer.toString(hex) from Uint8Array 563.00 ns/op 556.00 ns/op 1.01
bytes32 Buffer.toString(hex) + 0x 335.00 ns/op 337.00 ns/op 0.99
Object access 1 prop 0.16300 ns/op 0.17200 ns/op 0.95
Map access 1 prop 0.15400 ns/op 0.15800 ns/op 0.97
Object get x1000 6.5670 ns/op 6.5440 ns/op 1.00
Map get x1000 0.60200 ns/op 0.63800 ns/op 0.94
Object set x1000 51.385 ns/op 53.499 ns/op 0.96
Map set x1000 42.337 ns/op 43.388 ns/op 0.98
Return object 10000 times 0.23350 ns/op 0.23350 ns/op 1.00
Throw Error 10000 times 4.0577 us/op 4.0574 us/op 1.00
fastMsgIdFn sha256 / 200 bytes 3.4010 us/op 3.4370 us/op 0.99
fastMsgIdFn h32 xxhash / 200 bytes 269.00 ns/op 271.00 ns/op 0.99
fastMsgIdFn h64 xxhash / 200 bytes 378.00 ns/op 382.00 ns/op 0.99
fastMsgIdFn sha256 / 1000 bytes 11.434 us/op 11.500 us/op 0.99
fastMsgIdFn h32 xxhash / 1000 bytes 391.00 ns/op 401.00 ns/op 0.98
fastMsgIdFn h64 xxhash / 1000 bytes 447.00 ns/op 453.00 ns/op 0.99
fastMsgIdFn sha256 / 10000 bytes 103.78 us/op 103.31 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 1.9170 us/op 1.9190 us/op 1.00
fastMsgIdFn h64 xxhash / 10000 bytes 1.3650 us/op 1.3700 us/op 1.00
enrSubnets - fastDeserialize 64 bits 1.2700 us/op 1.2790 us/op 0.99
enrSubnets - ssz BitVector 64 bits 487.00 ns/op 487.00 ns/op 1.00
enrSubnets - fastDeserialize 4 bits 164.00 ns/op 165.00 ns/op 0.99
enrSubnets - ssz BitVector 4 bits 474.00 ns/op 484.00 ns/op 0.98
prioritizePeers score -10:0 att 32-0.1 sync 2-0 95.031 us/op 94.454 us/op 1.01
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 121.98 us/op 129.13 us/op 0.94
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 168.07 us/op 159.38 us/op 1.05
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 303.30 us/op 298.36 us/op 1.02
prioritizePeers score 0:0 att 64-1 sync 4-1 357.29 us/op 355.85 us/op 1.00
array of 16000 items push then shift 1.6007 us/op 1.6224 us/op 0.99
LinkedList of 16000 items push then shift 8.5900 ns/op 8.6630 ns/op 0.99
array of 16000 items push then pop 88.905 ns/op 91.372 ns/op 0.97
LinkedList of 16000 items push then pop 8.4650 ns/op 8.5070 ns/op 1.00
array of 24000 items push then shift 2.3324 us/op 2.3615 us/op 0.99
LinkedList of 24000 items push then shift 8.6630 ns/op 8.7140 ns/op 0.99
array of 24000 items push then pop 74.097 ns/op 71.467 ns/op 1.04
LinkedList of 24000 items push then pop 8.3090 ns/op 8.4250 ns/op 0.99
intersect bitArray bitLen 8 12.889 ns/op 13.129 ns/op 0.98
intersect array and set length 8 74.730 ns/op 74.890 ns/op 1.00
intersect bitArray bitLen 128 42.595 ns/op 43.862 ns/op 0.97
intersect array and set length 128 1.0149 us/op 1.0088 us/op 1.01
Buffer.concat 32 items 2.8890 us/op 2.5570 us/op 1.13
Uint8Array.set 32 items 2.4070 us/op 2.9280 us/op 0.82
pass gossip attestations to forkchoice per slot 3.2874 ms/op 2.2924 ms/op 1.43
computeDeltas 3.4158 ms/op 3.1269 ms/op 1.09
computeProposerBoostScoreFromBalances 1.7816 ms/op 1.7704 ms/op 1.01
altair processAttestation - 250000 vs - 7PWei normalcase 2.4676 ms/op 2.1404 ms/op 1.15
altair processAttestation - 250000 vs - 7PWei worstcase 3.4768 ms/op 3.6171 ms/op 0.96
altair processAttestation - setStatus - 1/6 committees join 141.21 us/op 141.64 us/op 1.00
altair processAttestation - setStatus - 1/3 committees join 288.87 us/op 270.86 us/op 1.07
altair processAttestation - setStatus - 1/2 committees join 386.29 us/op 383.23 us/op 1.01
altair processAttestation - setStatus - 2/3 committees join 477.19 us/op 471.23 us/op 1.01
altair processAttestation - setStatus - 4/5 committees join 676.49 us/op 656.46 us/op 1.03
altair processAttestation - setStatus - 100% committees join 781.84 us/op 757.31 us/op 1.03
altair processBlock - 250000 vs - 7PWei normalcase 16.383 ms/op 18.627 ms/op 0.88
altair processBlock - 250000 vs - 7PWei normalcase hashState 25.640 ms/op 24.894 ms/op 1.03
altair processBlock - 250000 vs - 7PWei worstcase 47.106 ms/op 49.819 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase hashState 67.915 ms/op 70.850 ms/op 0.96
phase0 processBlock - 250000 vs - 7PWei normalcase 2.1364 ms/op 2.0462 ms/op 1.04
phase0 processBlock - 250000 vs - 7PWei worstcase 29.375 ms/op 28.808 ms/op 1.02
altair processEth1Data - 250000 vs - 7PWei normalcase 466.47 us/op 518.76 us/op 0.90
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 9.0340 us/op 7.7560 us/op 1.16
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 30.428 us/op 23.546 us/op 1.29
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 12.074 us/op 8.7400 us/op 1.38
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 8.8180 us/op 7.3930 us/op 1.19
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 114.93 us/op 87.102 us/op 1.32
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 678.31 us/op 642.39 us/op 1.06
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 912.47 us/op 938.05 us/op 0.97
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 874.91 us/op 900.78 us/op 0.97
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.3648 ms/op 2.2853 ms/op 1.03
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.5723 ms/op 1.5872 ms/op 0.99
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 3.9175 ms/op 3.8638 ms/op 1.01
Tree 40 250000 create 304.80 ms/op 320.21 ms/op 0.95
Tree 40 250000 get(125000) 186.11 ns/op 190.51 ns/op 0.98
Tree 40 250000 set(125000) 937.86 ns/op 974.91 ns/op 0.96
Tree 40 250000 toArray() 22.045 ms/op 18.697 ms/op 1.18
Tree 40 250000 iterate all - toArray() + loop 21.253 ms/op 17.977 ms/op 1.18
Tree 40 250000 iterate all - get(i) 75.300 ms/op 69.036 ms/op 1.09
MutableVector 250000 create 9.8247 ms/op 11.374 ms/op 0.86
MutableVector 250000 get(125000) 6.2590 ns/op 6.4330 ns/op 0.97
MutableVector 250000 set(125000) 279.65 ns/op 258.63 ns/op 1.08
MutableVector 250000 toArray() 3.2654 ms/op 3.1389 ms/op 1.04
MutableVector 250000 iterate all - toArray() + loop 3.5417 ms/op 3.1263 ms/op 1.13
MutableVector 250000 iterate all - get(i) 1.5268 ms/op 1.5051 ms/op 1.01
Array 250000 create 2.6350 ms/op 2.7506 ms/op 0.96
Array 250000 clone - spread 1.0691 ms/op 1.1613 ms/op 0.92
Array 250000 get(125000) 0.54700 ns/op 0.56700 ns/op 0.96
Array 250000 set(125000) 0.63400 ns/op 0.64900 ns/op 0.98
Array 250000 iterate all - loop 84.399 us/op 106.61 us/op 0.79
effectiveBalanceIncrements clone Uint8Array 300000 26.518 us/op 26.972 us/op 0.98
effectiveBalanceIncrements clone MutableVector 300000 317.00 ns/op 364.00 ns/op 0.87
effectiveBalanceIncrements rw all Uint8Array 300000 171.54 us/op 167.11 us/op 1.03
effectiveBalanceIncrements rw all MutableVector 300000 79.238 ms/op 86.848 ms/op 0.91
phase0 afterProcessEpoch - 250000 vs - 7PWei 115.14 ms/op 113.60 ms/op 1.01
phase0 beforeProcessEpoch - 250000 vs - 7PWei 44.415 ms/op 42.130 ms/op 1.05
altair processEpoch - mainnet_e81889 322.66 ms/op 336.99 ms/op 0.96
mainnet_e81889 - altair beforeProcessEpoch 51.607 ms/op 65.252 ms/op 0.79
mainnet_e81889 - altair processJustificationAndFinalization 18.486 us/op 20.081 us/op 0.92
mainnet_e81889 - altair processInactivityUpdates 5.6510 ms/op 5.5917 ms/op 1.01
mainnet_e81889 - altair processRewardsAndPenalties 67.332 ms/op 68.716 ms/op 0.98
mainnet_e81889 - altair processRegistryUpdates 2.7880 us/op 2.7080 us/op 1.03
mainnet_e81889 - altair processSlashings 471.00 ns/op 416.00 ns/op 1.13
mainnet_e81889 - altair processEth1DataReset 479.00 ns/op 472.00 ns/op 1.01
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2576 ms/op 1.2450 ms/op 1.01
mainnet_e81889 - altair processSlashingsReset 4.7860 us/op 6.6780 us/op 0.72
mainnet_e81889 - altair processRandaoMixesReset 4.1860 us/op 4.5860 us/op 0.91
mainnet_e81889 - altair processHistoricalRootsUpdate 581.00 ns/op 691.00 ns/op 0.84
mainnet_e81889 - altair processParticipationFlagUpdates 2.2740 us/op 2.7900 us/op 0.82
mainnet_e81889 - altair processSyncCommitteeUpdates 424.00 ns/op 477.00 ns/op 0.89
mainnet_e81889 - altair afterProcessEpoch 117.08 ms/op 119.57 ms/op 0.98
phase0 processEpoch - mainnet_e58758 314.82 ms/op 359.24 ms/op 0.88
mainnet_e58758 - phase0 beforeProcessEpoch 120.38 ms/op 118.33 ms/op 1.02
mainnet_e58758 - phase0 processJustificationAndFinalization 16.706 us/op 18.744 us/op 0.89
mainnet_e58758 - phase0 processRewardsAndPenalties 52.461 ms/op 53.120 ms/op 0.99
mainnet_e58758 - phase0 processRegistryUpdates 6.8730 us/op 9.0260 us/op 0.76
mainnet_e58758 - phase0 processSlashings 474.00 ns/op 691.00 ns/op 0.69
mainnet_e58758 - phase0 processEth1DataReset 473.00 ns/op 911.00 ns/op 0.52
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0201 ms/op 1.0694 ms/op 0.95
mainnet_e58758 - phase0 processSlashingsReset 3.1490 us/op 8.7260 us/op 0.36
mainnet_e58758 - phase0 processRandaoMixesReset 4.4790 us/op 6.2800 us/op 0.71
mainnet_e58758 - phase0 processHistoricalRootsUpdate 513.00 ns/op 1.0500 us/op 0.49
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.7950 us/op 6.0350 us/op 0.79
mainnet_e58758 - phase0 afterProcessEpoch 93.703 ms/op 108.81 ms/op 0.86
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2257 ms/op 1.2805 ms/op 0.96
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4634 ms/op 1.5131 ms/op 0.97
altair processInactivityUpdates - 250000 normalcase 24.425 ms/op 31.694 ms/op 0.77
altair processInactivityUpdates - 250000 worstcase 20.859 ms/op 31.119 ms/op 0.67
phase0 processRegistryUpdates - 250000 normalcase 6.0750 us/op 7.6090 us/op 0.80
phase0 processRegistryUpdates - 250000 badcase_full_deposits 230.01 us/op 282.55 us/op 0.81
phase0 processRegistryUpdates - 250000 worstcase 0.5 124.17 ms/op 129.54 ms/op 0.96
altair processRewardsAndPenalties - 250000 normalcase 63.235 ms/op 67.912 ms/op 0.93
altair processRewardsAndPenalties - 250000 worstcase 66.267 ms/op 70.477 ms/op 0.94
phase0 getAttestationDeltas - 250000 normalcase 6.4328 ms/op 6.6152 ms/op 0.97
phase0 getAttestationDeltas - 250000 worstcase 6.5187 ms/op 6.6152 ms/op 0.99
phase0 processSlashings - 250000 worstcase 3.4609 ms/op 3.5179 ms/op 0.98
altair processSyncCommitteeUpdates - 250000 166.97 ms/op 178.25 ms/op 0.94
BeaconState.hashTreeRoot - No change 266.00 ns/op 287.00 ns/op 0.93
BeaconState.hashTreeRoot - 1 full validator 51.824 us/op 54.115 us/op 0.96
BeaconState.hashTreeRoot - 32 full validator 518.90 us/op 522.26 us/op 0.99
BeaconState.hashTreeRoot - 512 full validator 4.9832 ms/op 5.7720 ms/op 0.86
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 63.613 us/op 67.571 us/op 0.94
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 933.14 us/op 908.62 us/op 1.03
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.182 ms/op 11.362 ms/op 0.98
BeaconState.hashTreeRoot - 1 balances 51.548 us/op 51.670 us/op 1.00
BeaconState.hashTreeRoot - 32 balances 432.24 us/op 475.52 us/op 0.91
BeaconState.hashTreeRoot - 512 balances 4.2108 ms/op 4.6600 ms/op 0.90
BeaconState.hashTreeRoot - 250000 balances 73.577 ms/op 78.035 ms/op 0.94
aggregationBits - 2048 els - zipIndexesInBitList 15.170 us/op 17.640 us/op 0.86
regular array get 100000 times 43.856 us/op 34.921 us/op 1.26
wrappedArray get 100000 times 32.946 us/op 33.645 us/op 0.98
arrayWithProxy get 100000 times 15.090 ms/op 16.543 ms/op 0.91
ssz.Root.equals 538.00 ns/op 645.00 ns/op 0.83
byteArrayEquals 531.00 ns/op 600.00 ns/op 0.89
shuffle list - 16384 els 6.7645 ms/op 7.0164 ms/op 0.96
shuffle list - 250000 els 98.741 ms/op 103.38 ms/op 0.96
processSlot - 1 slots 8.3520 us/op 9.5260 us/op 0.88
processSlot - 32 slots 1.3221 ms/op 1.4200 ms/op 0.93
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 187.25 us/op 220.55 us/op 0.85
getCommitteeAssignments - req 1 vs - 250000 vc 2.8890 ms/op 2.9679 ms/op 0.97
getCommitteeAssignments - req 100 vs - 250000 vc 4.1274 ms/op 4.1616 ms/op 0.99
getCommitteeAssignments - req 1000 vs - 250000 vc 4.4262 ms/op 4.4698 ms/op 0.99
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.6900 ns/op 5.1400 ns/op 0.91
state getBlockRootAtSlot - 250000 vs - 7PWei 674.92 ns/op 851.32 ns/op 0.79
computeProposers - vc 250000 11.069 ms/op 11.298 ms/op 0.98
computeEpochShuffling - vc 250000 106.90 ms/op 104.04 ms/op 1.03
getNextSyncCommittee - vc 250000 174.39 ms/op 188.42 ms/op 0.93

by benchmarkbot/action

@wemeetagain
Copy link
Member Author

this release, I already ran the steps manually, but this will be helpful for next time

@wemeetagain wemeetagain merged commit d5c08e3 into unstable Feb 27, 2023
@wemeetagain wemeetagain deleted the cayman/update-create-rc branch February 27, 2023 23:59
@wemeetagain
Copy link
Member Author

🎉 This PR is included in v1.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wemeetagain @g11tech