chore: dynamic year on the chainsafe cli notice #5476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
force-pushed
the
nflaig/dynamic-cli-year
branch
from
edec9f0
to
d550804
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
|
Q: Is it really necessary to print the year? While it has been a common practice to include the year in copyright notices, it's not universally required, especially in many jurisdictions, including the United States. This tradition started because under the old U.S. copyright law (before 1978), the copyright would only last for 28 years from the date of publication, but could be renewed for another 28 years if the copyright was properly noticed, and the renewal registered. This is why you often saw, and still see, copyright notices with a year in them. However, under the Berne Convention for the Protection of Literary and Artistic Works, which the U.S. joined in 1989, copyright is automatic and does not require registration or a copyright notice. Many other countries are also signatories to this convention. So, in many cases, including the year in a copyright notice is not strictly necessary. However, it's still a common practice because it can provide certain benefits:
In the case of software projects, it's also common to include the range of years during which the project has been updated. This can help indicate the lifespan and active maintenance period of the project. However, it's worth noting that every jurisdiction may have slightly different rules about what is required or beneficial in a copyright notice. It's always a good idea to consult with a legal expert if you're unsure about the specific requirements or benefits for your situation. I would vote to remove the year |
I kinda like this part but can also just remove it, no strong opinion either way as long as it does not display outdated information |
|
I like it too, no real reason but for the vibe. Feels like it gives a sense of the progression of the project, gives confidence in the project |
dapplion
approved these changes
May 14, 2023
|
🎉 This PR is included in v1.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed in #5466 we don't really know why the year is even there but it "looks correct" so let's keep it and make sure it always up to date.
Description
Makes year on the chainsafe cli notice dynamic.