test: remove chain mocks #5582
Merged
test: remove chain mocks #5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
|
I like the motivation, but the e2e tests are failing |
dapplion
commented
May 31, 2023
| @@ -105,7 +103,6 @@ export class Network implements INetwork { | |||
| this.chain.emitter.on(routes.events.EventType.head, this.onHead); | |||
| this.chain.emitter.on(routes.events.EventType.lightClientFinalityUpdate, this.onLightClientFinalityUpdate); | |||
| this.chain.emitter.on(routes.events.EventType.lightClientOptimisticUpdate, this.onLightClientOptimisticUpdate); | |||
| modules.signal.addEventListener("abort", this.close.bind(this), {once: true}); | |||
There was a problem hiding this comment.
This is a terrible idea, debugging tests I discovered that close() is being called twice:
- first time through AbortController, not awaited, uncontrolled
- second time via close() but since it's second time it has no effect
This broke the expected close flow from the caller, causing issues in subsequent tests
dapplion
commented
May 31, 2023
There was a problem hiding this comment.
While attempting to fix the use of BeaconChain mock in network tests, I noticed that they can use the actual BeaconChain class and it works fine.
So the big refactor of the last commit is adding a new function getNetworkForTest() which instantiates a network class with the real BeaconChain thing as dependency
dapplion
force-pushed
the
dapplion/damn-mocks
branch
from
f484b0f
to
49ed179
Compare
wemeetagain
approved these changes
May 31, 2023
|
🎉 This PR is included in v1.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
MockBeaconChain class is very annoying to have to update everytime we change its interface. It's actually unnecessary, so this PR just drops it completely.
Description
Remove manual chain mocks of: