Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make results of keymanager e2e tests deterministic #5641

Merged
merged 1 commit into from
Jun 13, 2023
Merged

test: make results of keymanager e2e tests deterministic #5641

merged 1 commit into from
Jun 13, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jun 13, 2023

Motivation

Keystores are decrypted in parallel now (#5624) which means the order in which they are added to the validator store (validatorStore.addSigner) is no longer deterministic.

lodestar/packages/cli/src/cmds/validator/keymanager/impl.ts

Line 166 in f07d97f

this.validator.validatorStore.addSigner({type: SignerType.Local, secretKey});

This makes the result of keymanager e2e non-deterministic and causes e2e tests to fail randomly.

image

However, the order of signers in validator store does not matter which means the assertion can be updated to check the response in an unordered way.

Description

This change makes results of keymanager e2e tests deterministic, we only need to check the presence of all keys in response, irrespective of their order.

@nflaig nflaig requested a review from a team as a code owner June 13, 2023 16:54
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 5e54353 Previous: f07d97f Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 965.52 us/op 813.79 us/op 1.19
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 52.282 us/op 51.823 us/op 1.01
BLS verify - blst-native 1.2531 ms/op 1.2576 ms/op 1.00
BLS verifyMultipleSignatures 3 - blst-native 2.5516 ms/op 2.5805 ms/op 0.99
BLS verifyMultipleSignatures 8 - blst-native 5.5315 ms/op 5.4448 ms/op 1.02
BLS verifyMultipleSignatures 32 - blst-native 20.843 ms/op 19.301 ms/op 1.08
BLS aggregatePubkeys 32 - blst-native 27.282 us/op 26.579 us/op 1.03
BLS aggregatePubkeys 128 - blst-native 106.11 us/op 103.18 us/op 1.03
getAttestationsForBlock 64.712 ms/op 60.828 ms/op 1.06
isKnown best case - 1 super set check 282.00 ns/op 271.00 ns/op 1.04
isKnown normal case - 2 super set checks 281.00 ns/op 269.00 ns/op 1.04
isKnown worse case - 16 super set checks 273.00 ns/op 259.00 ns/op 1.05
CheckpointStateCache - add get delete 6.5900 us/op 6.0480 us/op 1.09
validate gossip signedAggregateAndProof - struct 2.9335 ms/op 2.8671 ms/op 1.02
validate gossip attestation - struct 1.4029 ms/op 1.3655 ms/op 1.03
pickEth1Vote - no votes 1.5150 ms/op 1.3719 ms/op 1.10
pickEth1Vote - max votes 9.8766 ms/op 12.398 ms/op 0.80
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.0806 ms/op 10.031 ms/op 0.91
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.236 ms/op 17.300 ms/op 0.82
pickEth1Vote - Eth1Data fastSerialize value x2048 721.64 us/op 776.71 us/op 0.93
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.8435 ms/op 7.8109 ms/op 0.62
bytes32 toHexString 514.00 ns/op 774.00 ns/op 0.66
bytes32 Buffer.toString(hex) 354.00 ns/op 444.00 ns/op 0.80
bytes32 Buffer.toString(hex) from Uint8Array 561.00 ns/op 682.00 ns/op 0.82
bytes32 Buffer.toString(hex) + 0x 360.00 ns/op 444.00 ns/op 0.81
Object access 1 prop 0.16200 ns/op 0.20900 ns/op 0.78
Map access 1 prop 0.15900 ns/op 0.18200 ns/op 0.87
Object get x1000 7.4960 ns/op 7.5710 ns/op 0.99
Map get x1000 0.57000 ns/op 0.62600 ns/op 0.91
Object set x1000 54.479 ns/op 70.608 ns/op 0.77
Map set x1000 44.306 ns/op 55.691 ns/op 0.80
Return object 10000 times 0.24360 ns/op 0.25540 ns/op 0.95
Throw Error 10000 times 4.3774 us/op 4.5821 us/op 0.96
fastMsgIdFn sha256 / 200 bytes 3.6180 us/op 3.7460 us/op 0.97
fastMsgIdFn h32 xxhash / 200 bytes 287.00 ns/op 324.00 ns/op 0.89
fastMsgIdFn h64 xxhash / 200 bytes 409.00 ns/op 516.00 ns/op 0.79
fastMsgIdFn sha256 / 1000 bytes 12.136 us/op 12.322 us/op 0.98
fastMsgIdFn h32 xxhash / 1000 bytes 425.00 ns/op 467.00 ns/op 0.91
fastMsgIdFn h64 xxhash / 1000 bytes 491.00 ns/op 605.00 ns/op 0.81
fastMsgIdFn sha256 / 10000 bytes 105.83 us/op 107.56 us/op 0.98
fastMsgIdFn h32 xxhash / 10000 bytes 2.0120 us/op 2.0770 us/op 0.97
fastMsgIdFn h64 xxhash / 10000 bytes 1.3780 us/op 1.5240 us/op 0.90
enrSubnets - fastDeserialize 64 bits 1.3280 us/op 1.8740 us/op 0.71
enrSubnets - ssz BitVector 64 bits 493.00 ns/op 656.00 ns/op 0.75
enrSubnets - fastDeserialize 4 bits 169.00 ns/op 201.00 ns/op 0.84
enrSubnets - ssz BitVector 4 bits 489.00 ns/op 651.00 ns/op 0.75
prioritizePeers score -10:0 att 32-0.1 sync 2-0 108.29 us/op 118.34 us/op 0.92
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 141.09 us/op 165.27 us/op 0.85
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 185.00 us/op 203.08 us/op 0.91
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 324.91 us/op 374.80 us/op 0.87
prioritizePeers score 0:0 att 64-1 sync 4-1 379.47 us/op 450.88 us/op 0.84
array of 16000 items push then shift 1.6955 us/op 1.8971 us/op 0.89
LinkedList of 16000 items push then shift 9.1010 ns/op 9.5800 ns/op 0.95
array of 16000 items push then pop 107.28 ns/op 94.354 ns/op 1.14
LinkedList of 16000 items push then pop 9.1660 ns/op 8.9520 ns/op 1.02
array of 24000 items push then shift 2.4482 us/op 2.4982 us/op 0.98
LinkedList of 24000 items push then shift 9.4680 ns/op 9.3630 ns/op 1.01
array of 24000 items push then pop 84.455 ns/op 85.103 ns/op 0.99
LinkedList of 24000 items push then pop 8.8410 ns/op 8.9360 ns/op 0.99
intersect bitArray bitLen 8 13.635 ns/op 13.720 ns/op 0.99
intersect array and set length 8 83.261 ns/op 82.889 ns/op 1.00
intersect bitArray bitLen 128 45.445 ns/op 45.369 ns/op 1.00
intersect array and set length 128 1.1629 us/op 1.3385 us/op 0.87
Buffer.concat 32 items 2.9770 us/op 3.1370 us/op 0.95
Uint8Array.set 32 items 2.2290 us/op 2.7050 us/op 0.82
transfer serialized Status (84 B) 2.0130 us/op 2.1380 us/op 0.94
copy serialized Status (84 B) 1.7050 us/op 1.8900 us/op 0.90
transfer serialized SignedVoluntaryExit (112 B) 2.1100 us/op 2.4180 us/op 0.87
copy serialized SignedVoluntaryExit (112 B) 1.7120 us/op 1.9860 us/op 0.86
transfer serialized ProposerSlashing (416 B) 3.2840 us/op 2.9410 us/op 1.12
copy serialized ProposerSlashing (416 B) 2.3060 us/op 3.0620 us/op 0.75
transfer serialized Attestation (485 B) 2.3950 us/op 3.2080 us/op 0.75
copy serialized Attestation (485 B) 2.0760 us/op 3.0170 us/op 0.69
transfer serialized AttesterSlashing (33232 B) 2.4810 us/op 2.7660 us/op 0.90
copy serialized AttesterSlashing (33232 B) 5.9890 us/op 7.6850 us/op 0.78
transfer serialized Small SignedBeaconBlock (128000 B) 2.8830 us/op 3.3560 us/op 0.86
copy serialized Small SignedBeaconBlock (128000 B) 14.758 us/op 20.747 us/op 0.71
transfer serialized Avg SignedBeaconBlock (200000 B) 3.1740 us/op 3.6680 us/op 0.87
copy serialized Avg SignedBeaconBlock (200000 B) 74.720 us/op 37.913 us/op 1.97
transfer serialized BlobsSidecar (524380 B) 3.2680 us/op 3.8930 us/op 0.84
copy serialized BlobsSidecar (524380 B) 165.56 us/op 112.17 us/op 1.48
transfer serialized Big SignedBeaconBlock (1000000 B) 3.4680 us/op 4.1470 us/op 0.84
copy serialized Big SignedBeaconBlock (1000000 B) 247.66 us/op 349.30 us/op 0.71
pass gossip attestations to forkchoice per slot 2.7537 ms/op 2.7778 ms/op 0.99
forkChoice updateHead vc 100000 bc 64 eq 0 2.1578 ms/op 2.1230 ms/op 1.02
forkChoice updateHead vc 600000 bc 64 eq 0 12.593 ms/op 12.436 ms/op 1.01
forkChoice updateHead vc 1000000 bc 64 eq 0 23.909 ms/op 22.953 ms/op 1.04
forkChoice updateHead vc 600000 bc 320 eq 0 17.701 ms/op 17.303 ms/op 1.02
forkChoice updateHead vc 600000 bc 1200 eq 0 87.715 ms/op 83.714 ms/op 1.05
forkChoice updateHead vc 600000 bc 64 eq 1000 21.891 ms/op 21.312 ms/op 1.03
forkChoice updateHead vc 600000 bc 64 eq 10000 23.837 ms/op 23.776 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 300000 32.855 ms/op 32.391 ms/op 1.01
computeDeltas 3.2527 ms/op 3.2513 ms/op 1.00
computeProposerBoostScoreFromBalances 1.8690 ms/op 1.8185 ms/op 1.03
altair processAttestation - 250000 vs - 7PWei normalcase 3.0321 ms/op 2.3767 ms/op 1.28
altair processAttestation - 250000 vs - 7PWei worstcase 4.6367 ms/op 3.9521 ms/op 1.17
altair processAttestation - setStatus - 1/6 committees join 149.65 us/op 142.75 us/op 1.05
altair processAttestation - setStatus - 1/3 committees join 289.33 us/op 286.90 us/op 1.01
altair processAttestation - setStatus - 1/2 committees join 497.63 us/op 379.64 us/op 1.31
altair processAttestation - setStatus - 2/3 committees join 592.01 us/op 460.50 us/op 1.29
altair processAttestation - setStatus - 4/5 committees join 1.1177 ms/op 676.88 us/op 1.65
altair processAttestation - setStatus - 100% committees join 1.4463 ms/op 773.38 us/op 1.87
altair processBlock - 250000 vs - 7PWei normalcase 35.088 ms/op 18.609 ms/op 1.89
altair processBlock - 250000 vs - 7PWei normalcase hashState 43.084 ms/op 26.982 ms/op 1.60
altair processBlock - 250000 vs - 7PWei worstcase 77.565 ms/op 55.509 ms/op 1.40
altair processBlock - 250000 vs - 7PWei worstcase hashState 86.305 ms/op 67.526 ms/op 1.28
phase0 processBlock - 250000 vs - 7PWei normalcase 2.3634 ms/op 2.4858 ms/op 0.95
phase0 processBlock - 250000 vs - 7PWei worstcase 32.419 ms/op 30.879 ms/op 1.05
altair processEth1Data - 250000 vs - 7PWei normalcase 577.19 us/op 518.28 us/op 1.11
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 9.9780 us/op 7.8150 us/op 1.28
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 32.897 us/op 25.004 us/op 1.32
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 11.516 us/op 8.5990 us/op 1.34
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 11.027 us/op 7.0090 us/op 1.57
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 147.45 us/op 89.547 us/op 1.65
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 676.43 us/op 663.73 us/op 1.02
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 932.13 us/op 913.87 us/op 1.02
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 886.87 us/op 920.34 us/op 0.96
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.7764 ms/op 2.3627 ms/op 1.18
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.5601 ms/op 1.5857 ms/op 0.98
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 7.0885 ms/op 4.1699 ms/op 1.70
Tree 40 250000 create 687.06 ms/op 307.40 ms/op 2.24
Tree 40 250000 get(125000) 224.67 ns/op 191.93 ns/op 1.17
Tree 40 250000 set(125000) 2.3516 us/op 955.60 ns/op 2.46
Tree 40 250000 toArray() 28.724 ms/op 25.072 ms/op 1.15
Tree 40 250000 iterate all - toArray() + loop 29.867 ms/op 24.375 ms/op 1.23
Tree 40 250000 iterate all - get(i) 93.764 ms/op 76.539 ms/op 1.23
MutableVector 250000 create 15.671 ms/op 11.285 ms/op 1.39
MutableVector 250000 get(125000) 8.0190 ns/op 6.5120 ns/op 1.23
MutableVector 250000 set(125000) 552.45 ns/op 285.58 ns/op 1.93
MutableVector 250000 toArray() 4.3278 ms/op 2.9891 ms/op 1.45
MutableVector 250000 iterate all - toArray() + loop 4.3898 ms/op 3.5214 ms/op 1.25
MutableVector 250000 iterate all - get(i) 1.8875 ms/op 1.5566 ms/op 1.21
Array 250000 create 3.9409 ms/op 3.1848 ms/op 1.24
Array 250000 clone - spread 1.9667 ms/op 1.1318 ms/op 1.74
Array 250000 get(125000) 1.1580 ns/op 0.54500 ns/op 2.12
Array 250000 set(125000) 1.3930 ns/op 0.63100 ns/op 2.21
Array 250000 iterate all - loop 100.75 us/op 114.48 us/op 0.88
effectiveBalanceIncrements clone Uint8Array 300000 56.830 us/op 36.853 us/op 1.54
effectiveBalanceIncrements clone MutableVector 300000 655.00 ns/op 339.00 ns/op 1.93
effectiveBalanceIncrements rw all Uint8Array 300000 205.46 us/op 173.41 us/op 1.18
effectiveBalanceIncrements rw all MutableVector 300000 203.44 ms/op 81.512 ms/op 2.50
phase0 afterProcessEpoch - 250000 vs - 7PWei 153.69 ms/op 117.83 ms/op 1.30
phase0 beforeProcessEpoch - 250000 vs - 7PWei 52.267 ms/op 45.461 ms/op 1.15
altair processEpoch - mainnet_e81889 399.31 ms/op 336.86 ms/op 1.19
mainnet_e81889 - altair beforeProcessEpoch 80.750 ms/op 70.733 ms/op 1.14
mainnet_e81889 - altair processJustificationAndFinalization 33.992 us/op 16.335 us/op 2.08
mainnet_e81889 - altair processInactivityUpdates 7.4844 ms/op 5.6912 ms/op 1.32
mainnet_e81889 - altair processRewardsAndPenalties 60.906 ms/op 49.196 ms/op 1.24
mainnet_e81889 - altair processRegistryUpdates 5.3350 us/op 2.3490 us/op 2.27
mainnet_e81889 - altair processSlashings 1.6140 us/op 536.00 ns/op 3.01
mainnet_e81889 - altair processEth1DataReset 1.6200 us/op 522.00 ns/op 3.10
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.0310 ms/op 1.2827 ms/op 1.58
mainnet_e81889 - altair processSlashingsReset 9.6630 us/op 6.3100 us/op 1.53
mainnet_e81889 - altair processRandaoMixesReset 12.290 us/op 6.7510 us/op 1.82
mainnet_e81889 - altair processHistoricalRootsUpdate 1.9350 us/op 801.00 ns/op 2.42
mainnet_e81889 - altair processParticipationFlagUpdates 6.8800 us/op 2.8170 us/op 2.44
mainnet_e81889 - altair processSyncCommitteeUpdates 1.4600 us/op 531.00 ns/op 2.75
mainnet_e81889 - altair afterProcessEpoch 148.39 ms/op 129.69 ms/op 1.14
phase0 processEpoch - mainnet_e58758 468.03 ms/op 372.09 ms/op 1.26
mainnet_e58758 - phase0 beforeProcessEpoch 182.61 ms/op 148.68 ms/op 1.23
mainnet_e58758 - phase0 processJustificationAndFinalization 30.432 us/op 20.379 us/op 1.49
mainnet_e58758 - phase0 processRewardsAndPenalties 75.421 ms/op 64.177 ms/op 1.18
mainnet_e58758 - phase0 processRegistryUpdates 13.400 us/op 8.7400 us/op 1.53
mainnet_e58758 - phase0 processSlashings 1.1000 us/op 687.00 ns/op 1.60
mainnet_e58758 - phase0 processEth1DataReset 1.1740 us/op 620.00 ns/op 1.89
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.6811 ms/op 1.0493 ms/op 1.60
mainnet_e58758 - phase0 processSlashingsReset 7.4170 us/op 4.3040 us/op 1.72
mainnet_e58758 - phase0 processRandaoMixesReset 10.969 us/op 5.2350 us/op 2.10
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.9150 us/op 802.00 ns/op 2.39
mainnet_e58758 - phase0 processParticipationRecordUpdates 11.588 us/op 4.2480 us/op 2.73
mainnet_e58758 - phase0 afterProcessEpoch 130.46 ms/op 103.02 ms/op 1.27
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.3320 ms/op 1.3011 ms/op 1.79
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.8400 ms/op 1.5992 ms/op 1.78
altair processInactivityUpdates - 250000 normalcase 39.245 ms/op 27.894 ms/op 1.41
altair processInactivityUpdates - 250000 worstcase 38.319 ms/op 29.394 ms/op 1.30
phase0 processRegistryUpdates - 250000 normalcase 15.060 us/op 8.9060 us/op 1.69
phase0 processRegistryUpdates - 250000 badcase_full_deposits 377.59 us/op 289.41 us/op 1.30
phase0 processRegistryUpdates - 250000 worstcase 0.5 174.19 ms/op 140.38 ms/op 1.24
altair processRewardsAndPenalties - 250000 normalcase 86.058 ms/op 72.609 ms/op 1.19
altair processRewardsAndPenalties - 250000 worstcase 85.312 ms/op 70.456 ms/op 1.21
phase0 getAttestationDeltas - 250000 normalcase 11.295 ms/op 7.3751 ms/op 1.53
phase0 getAttestationDeltas - 250000 worstcase 9.6947 ms/op 6.9353 ms/op 1.40
phase0 processSlashings - 250000 worstcase 4.3089 ms/op 3.7168 ms/op 1.16
altair processSyncCommitteeUpdates - 250000 202.26 ms/op 179.15 ms/op 1.13
BeaconState.hashTreeRoot - No change 398.00 ns/op 268.00 ns/op 1.49
BeaconState.hashTreeRoot - 1 full validator 56.942 us/op 55.211 us/op 1.03
BeaconState.hashTreeRoot - 32 full validator 666.86 us/op 570.05 us/op 1.17
BeaconState.hashTreeRoot - 512 full validator 7.1931 ms/op 4.9780 ms/op 1.44
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 77.833 us/op 64.412 us/op 1.21
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.0901 ms/op 909.06 us/op 1.20
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 13.851 ms/op 12.454 ms/op 1.11
BeaconState.hashTreeRoot - 1 balances 58.012 us/op 50.015 us/op 1.16
BeaconState.hashTreeRoot - 32 balances 508.44 us/op 467.28 us/op 1.09
BeaconState.hashTreeRoot - 512 balances 5.0622 ms/op 4.3703 ms/op 1.16
BeaconState.hashTreeRoot - 250000 balances 93.440 ms/op 80.227 ms/op 1.16
aggregationBits - 2048 els - zipIndexesInBitList 28.898 us/op 18.121 us/op 1.59
regular array get 100000 times 38.250 us/op 34.245 us/op 1.12
wrappedArray get 100000 times 38.198 us/op 34.273 us/op 1.11
arrayWithProxy get 100000 times 18.059 ms/op 18.005 ms/op 1.00
ssz.Root.equals 735.00 ns/op 586.00 ns/op 1.25
byteArrayEquals 713.00 ns/op 553.00 ns/op 1.29
shuffle list - 16384 els 8.6797 ms/op 7.1093 ms/op 1.22
shuffle list - 250000 els 125.55 ms/op 105.04 ms/op 1.20
processSlot - 1 slots 10.515 us/op 9.9640 us/op 1.06
processSlot - 32 slots 1.5982 ms/op 1.4300 ms/op 1.12
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 45.994 ms/op 36.590 ms/op 1.26
getCommitteeAssignments - req 1 vs - 250000 vc 3.4174 ms/op 3.0375 ms/op 1.13
getCommitteeAssignments - req 100 vs - 250000 vc 4.5034 ms/op 4.3574 ms/op 1.03
getCommitteeAssignments - req 1000 vs - 250000 vc 5.1877 ms/op 4.6893 ms/op 1.11
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.5000 ns/op 5.9200 ns/op 0.93
state getBlockRootAtSlot - 250000 vs - 7PWei 807.21 ns/op 670.90 ns/op 1.20
computeProposers - vc 250000 12.974 ms/op 11.863 ms/op 1.09
computeEpochShuffling - vc 250000 124.29 ms/op 107.80 ms/op 1.15
getNextSyncCommittee - vc 250000 222.21 ms/op 186.64 ms/op 1.19
computeSigningRoot for AttestationData 17.471 us/op 13.573 us/op 1.29
hash AttestationData serialized data then Buffer.toString(base64) 2.7821 us/op 2.6198 us/op 1.06
toHexString serialized data 1.8952 us/op 1.1193 us/op 1.69
Buffer.toString(base64) 413.50 ns/op 334.53 ns/op 1.24

by benchmarkbot/action

@wemeetagain wemeetagain merged commit bb4151d into unstable Jun 13, 2023
@wemeetagain wemeetagain deleted the nflaig/deterministic-keymanager-e2e-tests branch June 13, 2023 17:14
g11tech
g11tech reviewed Jun 13, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.0 🎉

This was referenced Dec 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech left review comments

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nflaig @wemeetagain @g11tech