Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove winston from packages other than logger #5742

Merged
merged 1 commit into from
Jul 10, 2023
Merged

chore: remove winston from packages other than logger #5742

merged 1 commit into from
Jul 10, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jul 10, 2023 •
edited
Loading

Motivation

Noticed when installing @lodestar/api, it also installs winston and tons of other sub deps which are not required.

Description

Remove winston* dependencies from all packages other than @lodestar/logger.

@nflaig nflaig requested a review from a team as a code owner July 10, 2023 16:18
nflaig
nflaig commented Jul 10, 2023
View reviewed changes
packages/beacon-node/package.json
@@ -124,7 +124,6 @@
"@lodestar/db": "^1.9.1",
"@lodestar/fork-choice": "^1.9.1",
"@lodestar/light-client": "^1.9.1",
"@lodestar/logger": "^1.9.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lodestar/logger should only be a dependency of @lodestar/cli, other packages use dependency injection to get access to logger (could be different implementation)

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 3de36a4 Previous: b596000 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 785.88 us/op 894.21 us/op 0.88
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 67.722 us/op 46.348 us/op 1.46
BLS verify - blst-native 1.7074 ms/op 1.2125 ms/op 1.41
BLS verifyMultipleSignatures 3 - blst-native 3.3203 ms/op 2.4445 ms/op 1.36
BLS verifyMultipleSignatures 8 - blst-native 7.8557 ms/op 5.2173 ms/op 1.51
BLS verifyMultipleSignatures 32 - blst-native 25.756 ms/op 18.955 ms/op 1.36
BLS aggregatePubkeys 32 - blst-native 34.024 us/op 25.358 us/op 1.34
BLS aggregatePubkeys 128 - blst-native 133.10 us/op 98.422 us/op 1.35
getAttestationsForBlock 86.358 ms/op 52.984 ms/op 1.63
isKnown best case - 1 super set check 336.00 ns/op 254.00 ns/op 1.32
isKnown normal case - 2 super set checks 320.00 ns/op 248.00 ns/op 1.29
isKnown worse case - 16 super set checks 318.00 ns/op 243.00 ns/op 1.31
CheckpointStateCache - add get delete 7.4500 us/op 5.5590 us/op 1.34
validate gossip signedAggregateAndProof - struct 3.9906 ms/op 2.8109 ms/op 1.42
validate gossip attestation - struct 1.7422 ms/op 1.4150 ms/op 1.23
pickEth1Vote - no votes 1.9362 ms/op 1.4279 ms/op 1.36
pickEth1Vote - max votes 16.059 ms/op 12.656 ms/op 1.27
pickEth1Vote - Eth1Data hashTreeRoot value x2048 14.993 ms/op 8.8420 ms/op 1.70
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.028 ms/op 14.511 ms/op 1.52
pickEth1Vote - Eth1Data fastSerialize value x2048 934.04 us/op 677.02 us/op 1.38
pickEth1Vote - Eth1Data fastSerialize tree x2048 9.6876 ms/op 6.9445 ms/op 1.40
bytes32 toHexString 927.00 ns/op 540.00 ns/op 1.72
bytes32 Buffer.toString(hex) 631.00 ns/op 351.00 ns/op 1.80
bytes32 Buffer.toString(hex) from Uint8Array 929.00 ns/op 578.00 ns/op 1.61
bytes32 Buffer.toString(hex) + 0x 620.00 ns/op 359.00 ns/op 1.73
Object access 1 prop 0.27300 ns/op 0.15800 ns/op 1.73
Map access 1 prop 0.22100 ns/op 0.16000 ns/op 1.38
Object get x1000 10.014 ns/op 6.6640 ns/op 1.50
Map get x1000 0.94600 ns/op 0.63500 ns/op 1.49
Object set x1000 109.97 ns/op 55.116 ns/op 2.00
Map set x1000 79.152 ns/op 43.275 ns/op 1.83
Return object 10000 times 0.34510 ns/op 0.23980 ns/op 1.44
Throw Error 10000 times 6.6605 us/op 4.2545 us/op 1.57
fastMsgIdFn sha256 / 200 bytes 5.2190 us/op 3.4540 us/op 1.51
fastMsgIdFn h32 xxhash / 200 bytes 447.00 ns/op 291.00 ns/op 1.54
fastMsgIdFn h64 xxhash / 200 bytes 617.00 ns/op 392.00 ns/op 1.57
fastMsgIdFn sha256 / 1000 bytes 17.131 us/op 11.647 us/op 1.47
fastMsgIdFn h32 xxhash / 1000 bytes 708.00 ns/op 422.00 ns/op 1.68
fastMsgIdFn h64 xxhash / 1000 bytes 836.00 ns/op 492.00 ns/op 1.70
fastMsgIdFn sha256 / 10000 bytes 166.19 us/op 103.81 us/op 1.60
fastMsgIdFn h32 xxhash / 10000 bytes 3.5210 us/op 1.9870 us/op 1.77
fastMsgIdFn h64 xxhash / 10000 bytes 2.2570 us/op 1.4340 us/op 1.57
enrSubnets - fastDeserialize 64 bits 2.6490 us/op 1.3020 us/op 2.03
enrSubnets - ssz BitVector 64 bits 904.00 ns/op 493.00 ns/op 1.83
enrSubnets - fastDeserialize 4 bits 321.00 ns/op 165.00 ns/op 1.95
enrSubnets - ssz BitVector 4 bits 875.00 ns/op 485.00 ns/op 1.80
prioritizePeers score -10:0 att 32-0.1 sync 2-0 175.52 us/op 106.94 us/op 1.64
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 249.37 us/op 140.13 us/op 1.78
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 338.66 us/op 178.07 us/op 1.90
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 596.01 us/op 328.16 us/op 1.82
prioritizePeers score 0:0 att 64-1 sync 4-1 696.49 us/op 381.45 us/op 1.83
array of 16000 items push then shift 3.0085 us/op 1.6622 us/op 1.81
LinkedList of 16000 items push then shift 11.712 ns/op 8.8880 ns/op 1.32
array of 16000 items push then pop 138.49 ns/op 80.757 ns/op 1.71
LinkedList of 16000 items push then pop 11.888 ns/op 8.7510 ns/op 1.36
array of 24000 items push then shift 3.0733 us/op 2.3721 us/op 1.30
LinkedList of 24000 items push then shift 13.073 ns/op 9.1840 ns/op 1.42
array of 24000 items push then pop 113.81 ns/op 79.132 ns/op 1.44
LinkedList of 24000 items push then pop 12.188 ns/op 8.7370 ns/op 1.39
intersect bitArray bitLen 8 24.323 ns/op 13.430 ns/op 1.81
intersect array and set length 8 150.20 ns/op 80.221 ns/op 1.87
intersect bitArray bitLen 128 65.775 ns/op 44.947 ns/op 1.46
intersect array and set length 128 1.6162 us/op 1.0843 us/op 1.49
Buffer.concat 32 items 4.3300 us/op 2.9590 us/op 1.46
Uint8Array.set 32 items 3.9470 us/op 2.8450 us/op 1.39
transfer serialized Status (84 B) 2.8630 us/op 2.0510 us/op 1.40
copy serialized Status (84 B) 2.3180 us/op 1.6940 us/op 1.37
transfer serialized SignedVoluntaryExit (112 B) 2.8480 us/op 2.1370 us/op 1.33
copy serialized SignedVoluntaryExit (112 B) 2.7370 us/op 1.7110 us/op 1.60
transfer serialized ProposerSlashing (416 B) 2.9520 us/op 2.2570 us/op 1.31
copy serialized ProposerSlashing (416 B) 2.5660 us/op 2.1100 us/op 1.22
transfer serialized Attestation (485 B) 2.7710 us/op 2.2700 us/op 1.22
copy serialized Attestation (485 B) 2.6620 us/op 2.2330 us/op 1.19
transfer serialized AttesterSlashing (33232 B) 2.9160 us/op 2.4610 us/op 1.18
copy serialized AttesterSlashing (33232 B) 7.6250 us/op 7.3200 us/op 1.04
transfer serialized Small SignedBeaconBlock (128000 B) 3.4200 us/op 2.9710 us/op 1.15
copy serialized Small SignedBeaconBlock (128000 B) 20.306 us/op 14.894 us/op 1.36
transfer serialized Avg SignedBeaconBlock (200000 B) 4.1850 us/op 3.2040 us/op 1.31
copy serialized Avg SignedBeaconBlock (200000 B) 57.810 us/op 25.106 us/op 2.30
transfer serialized BlobsSidecar (524380 B) 4.4830 us/op 3.5040 us/op 1.28
copy serialized BlobsSidecar (524380 B) 87.767 us/op 184.83 us/op 0.47
transfer serialized Big SignedBeaconBlock (1000000 B) 4.6220 us/op 3.1600 us/op 1.46
copy serialized Big SignedBeaconBlock (1000000 B) 319.52 us/op 300.81 us/op 1.06
pass gossip attestations to forkchoice per slot 3.5035 ms/op 2.7129 ms/op 1.29
forkChoice updateHead vc 100000 bc 64 eq 0 2.5172 ms/op 2.1294 ms/op 1.18
forkChoice updateHead vc 600000 bc 64 eq 0 16.519 ms/op 11.822 ms/op 1.40
forkChoice updateHead vc 1000000 bc 64 eq 0 28.462 ms/op 23.326 ms/op 1.22
forkChoice updateHead vc 600000 bc 320 eq 0 21.163 ms/op 16.561 ms/op 1.28
forkChoice updateHead vc 600000 bc 1200 eq 0 109.70 ms/op 81.670 ms/op 1.34
forkChoice updateHead vc 600000 bc 64 eq 1000 29.157 ms/op 21.016 ms/op 1.39
forkChoice updateHead vc 600000 bc 64 eq 10000 29.858 ms/op 24.354 ms/op 1.23
forkChoice updateHead vc 600000 bc 64 eq 300000 57.617 ms/op 33.369 ms/op 1.73
computeDeltas 4.1145 ms/op 3.2849 ms/op 1.25
computeProposerBoostScoreFromBalances 2.1568 ms/op 1.7858 ms/op 1.21
altair processAttestation - 250000 vs - 7PWei normalcase 2.9858 ms/op 2.5199 ms/op 1.18
altair processAttestation - 250000 vs - 7PWei worstcase 4.6376 ms/op 3.6569 ms/op 1.27
altair processAttestation - setStatus - 1/6 committees join 160.29 us/op 141.02 us/op 1.14
altair processAttestation - setStatus - 1/3 committees join 350.41 us/op 276.84 us/op 1.27
altair processAttestation - setStatus - 1/2 committees join 464.74 us/op 375.02 us/op 1.24
altair processAttestation - setStatus - 2/3 committees join 591.76 us/op 489.26 us/op 1.21
altair processAttestation - setStatus - 4/5 committees join 899.94 us/op 666.25 us/op 1.35
altair processAttestation - setStatus - 100% committees join 1.0784 ms/op 754.01 us/op 1.43
altair processBlock - 250000 vs - 7PWei normalcase 23.542 ms/op 17.339 ms/op 1.36
altair processBlock - 250000 vs - 7PWei normalcase hashState 34.262 ms/op 27.327 ms/op 1.25
altair processBlock - 250000 vs - 7PWei worstcase 65.931 ms/op 51.672 ms/op 1.28
altair processBlock - 250000 vs - 7PWei worstcase hashState 99.040 ms/op 67.788 ms/op 1.46
phase0 processBlock - 250000 vs - 7PWei normalcase 3.2463 ms/op 2.0346 ms/op 1.60
phase0 processBlock - 250000 vs - 7PWei worstcase 42.578 ms/op 29.053 ms/op 1.47
altair processEth1Data - 250000 vs - 7PWei normalcase 810.88 us/op 498.49 us/op 1.63
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 13.439 us/op 8.8990 us/op 1.51
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 38.038 us/op 29.407 us/op 1.29
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 11.306 us/op 11.028 us/op 1.03
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 14.513 us/op 8.4700 us/op 1.71
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 108.93 us/op 107.00 us/op 1.02
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 947.91 us/op 656.85 us/op 1.44
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.1302 ms/op 944.33 us/op 1.20
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.6016 ms/op 913.38 us/op 1.75
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.1655 ms/op 2.3771 ms/op 1.33
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.2134 ms/op 1.5236 ms/op 1.45
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 6.9612 ms/op 3.8803 ms/op 1.79
Tree 40 250000 create 705.71 ms/op 328.43 ms/op 2.15
Tree 40 250000 get(125000) 272.69 ns/op 185.49 ns/op 1.47
Tree 40 250000 set(125000) 1.9994 us/op 888.89 ns/op 2.25
Tree 40 250000 toArray() 27.470 ms/op 17.955 ms/op 1.53
Tree 40 250000 iterate all - toArray() + loop 30.006 ms/op 18.153 ms/op 1.65
Tree 40 250000 iterate all - get(i) 97.170 ms/op 68.709 ms/op 1.41
MutableVector 250000 create 14.916 ms/op 10.559 ms/op 1.41
MutableVector 250000 get(125000) 8.1460 ns/op 6.3560 ns/op 1.28
MutableVector 250000 set(125000) 433.56 ns/op 241.99 ns/op 1.79
MutableVector 250000 toArray() 5.5263 ms/op 2.7173 ms/op 2.03
MutableVector 250000 iterate all - toArray() + loop 6.5030 ms/op 2.8381 ms/op 2.29
MutableVector 250000 iterate all - get(i) 2.2504 ms/op 1.5353 ms/op 1.47
Array 250000 create 4.5098 ms/op 2.5328 ms/op 1.78
Array 250000 clone - spread 1.5872 ms/op 1.1111 ms/op 1.43
Array 250000 get(125000) 0.83600 ns/op 0.55200 ns/op 1.51
Array 250000 set(125000) 1.7030 ns/op 0.60500 ns/op 2.81
Array 250000 iterate all - loop 163.86 us/op 83.499 us/op 1.96
effectiveBalanceIncrements clone Uint8Array 300000 67.699 us/op 32.746 us/op 2.07
effectiveBalanceIncrements clone MutableVector 300000 636.00 ns/op 337.00 ns/op 1.89
effectiveBalanceIncrements rw all Uint8Array 300000 311.76 us/op 169.54 us/op 1.84
effectiveBalanceIncrements rw all MutableVector 300000 185.30 ms/op 82.160 ms/op 2.26
phase0 afterProcessEpoch - 250000 vs - 7PWei 173.92 ms/op 116.70 ms/op 1.49
phase0 beforeProcessEpoch - 250000 vs - 7PWei 50.134 ms/op 44.061 ms/op 1.14
altair processEpoch - mainnet_e81889 443.10 ms/op 332.14 ms/op 1.33
mainnet_e81889 - altair beforeProcessEpoch 67.364 ms/op 70.853 ms/op 0.95
mainnet_e81889 - altair processJustificationAndFinalization 33.449 us/op 19.385 us/op 1.73
mainnet_e81889 - altair processInactivityUpdates 8.3204 ms/op 6.4702 ms/op 1.29
mainnet_e81889 - altair processRewardsAndPenalties 79.657 ms/op 70.083 ms/op 1.14
mainnet_e81889 - altair processRegistryUpdates 5.6720 us/op 3.0570 us/op 1.86
mainnet_e81889 - altair processSlashings 653.00 ns/op 581.00 ns/op 1.12
mainnet_e81889 - altair processEth1DataReset 1.0310 us/op 732.00 ns/op 1.41
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.8777 ms/op 1.2467 ms/op 1.51
mainnet_e81889 - altair processSlashingsReset 5.9690 us/op 4.4940 us/op 1.33
mainnet_e81889 - altair processRandaoMixesReset 16.117 us/op 6.2630 us/op 2.57
mainnet_e81889 - altair processHistoricalRootsUpdate 1.4590 us/op 1.3810 us/op 1.06
mainnet_e81889 - altair processParticipationFlagUpdates 3.5790 us/op 4.5230 us/op 0.79
mainnet_e81889 - altair processSyncCommitteeUpdates 700.00 ns/op 1.1080 us/op 0.63
mainnet_e81889 - altair afterProcessEpoch 164.27 ms/op 136.13 ms/op 1.21
phase0 processEpoch - mainnet_e58758 447.70 ms/op 378.89 ms/op 1.18
mainnet_e58758 - phase0 beforeProcessEpoch 166.12 ms/op 155.09 ms/op 1.07
mainnet_e58758 - phase0 processJustificationAndFinalization 24.715 us/op 24.645 us/op 1.00
mainnet_e58758 - phase0 processRewardsAndPenalties 80.556 ms/op 66.012 ms/op 1.22
mainnet_e58758 - phase0 processRegistryUpdates 12.315 us/op 12.056 us/op 1.02
mainnet_e58758 - phase0 processSlashings 648.00 ns/op 616.00 ns/op 1.05
mainnet_e58758 - phase0 processEth1DataReset 733.00 ns/op 655.00 ns/op 1.12
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.2057 ms/op 1.3112 ms/op 0.92
mainnet_e58758 - phase0 processSlashingsReset 4.9730 us/op 4.7080 us/op 1.06
mainnet_e58758 - phase0 processRandaoMixesReset 8.1040 us/op 5.4710 us/op 1.48
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.2350 us/op 912.00 ns/op 1.35
mainnet_e58758 - phase0 processParticipationRecordUpdates 7.3610 us/op 6.0940 us/op 1.21
mainnet_e58758 - phase0 afterProcessEpoch 102.95 ms/op 106.17 ms/op 0.97
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.2763 ms/op 1.3185 ms/op 1.73
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4919 ms/op 1.5630 ms/op 0.95
altair processInactivityUpdates - 250000 normalcase 31.502 ms/op 26.302 ms/op 1.20
altair processInactivityUpdates - 250000 worstcase 27.600 ms/op 27.284 ms/op 1.01
phase0 processRegistryUpdates - 250000 normalcase 9.1150 us/op 8.7550 us/op 1.04
phase0 processRegistryUpdates - 250000 badcase_full_deposits 369.31 us/op 437.79 us/op 0.84
phase0 processRegistryUpdates - 250000 worstcase 0.5 141.60 ms/op 131.54 ms/op 1.08
altair processRewardsAndPenalties - 250000 normalcase 76.073 ms/op 70.668 ms/op 1.08
altair processRewardsAndPenalties - 250000 worstcase 80.040 ms/op 68.480 ms/op 1.17
phase0 getAttestationDeltas - 250000 normalcase 7.2771 ms/op 7.1207 ms/op 1.02
phase0 getAttestationDeltas - 250000 worstcase 6.8500 ms/op 7.3137 ms/op 0.94
phase0 processSlashings - 250000 worstcase 3.7833 ms/op 3.6693 ms/op 1.03
altair processSyncCommitteeUpdates - 250000 190.97 ms/op 181.28 ms/op 1.05
BeaconState.hashTreeRoot - No change 290.00 ns/op 262.00 ns/op 1.11
BeaconState.hashTreeRoot - 1 full validator 63.143 us/op 53.395 us/op 1.18
BeaconState.hashTreeRoot - 32 full validator 645.52 us/op 535.74 us/op 1.20
BeaconState.hashTreeRoot - 512 full validator 6.3800 ms/op 5.2697 ms/op 1.21
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 71.856 us/op 62.093 us/op 1.16
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.0585 ms/op 1.0083 ms/op 1.05
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 14.298 ms/op 11.166 ms/op 1.28
BeaconState.hashTreeRoot - 1 balances 60.550 us/op 47.834 us/op 1.27
BeaconState.hashTreeRoot - 32 balances 517.24 us/op 465.61 us/op 1.11
BeaconState.hashTreeRoot - 512 balances 5.4253 ms/op 4.5960 ms/op 1.18
BeaconState.hashTreeRoot - 250000 balances 90.036 ms/op 74.149 ms/op 1.21
aggregationBits - 2048 els - zipIndexesInBitList 21.328 us/op 16.147 us/op 1.32
regular array get 100000 times 38.705 us/op 34.158 us/op 1.13
wrappedArray get 100000 times 38.516 us/op 33.576 us/op 1.15
arrayWithProxy get 100000 times 18.932 ms/op 15.648 ms/op 1.21
ssz.Root.equals 678.00 ns/op 552.00 ns/op 1.23
byteArrayEquals 749.00 ns/op 557.00 ns/op 1.34
shuffle list - 16384 els 8.2378 ms/op 6.8905 ms/op 1.20
shuffle list - 250000 els 120.24 ms/op 102.35 ms/op 1.17
processSlot - 1 slots 10.711 us/op 8.5590 us/op 1.25
processSlot - 32 slots 1.6429 ms/op 1.3530 ms/op 1.21
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 41.625 ms/op 36.577 ms/op 1.14
getCommitteeAssignments - req 1 vs - 250000 vc 3.1139 ms/op 2.9296 ms/op 1.06
getCommitteeAssignments - req 100 vs - 250000 vc 4.5005 ms/op 4.1747 ms/op 1.08
getCommitteeAssignments - req 1000 vs - 250000 vc 4.9254 ms/op 4.4769 ms/op 1.10
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.8200 ns/op 4.7100 ns/op 1.02
state getBlockRootAtSlot - 250000 vs - 7PWei 972.99 ns/op 564.93 ns/op 1.72
computeProposers - vc 250000 10.988 ms/op 10.297 ms/op 1.07
computeEpochShuffling - vc 250000 108.82 ms/op 103.82 ms/op 1.05
getNextSyncCommittee - vc 250000 179.75 ms/op 173.00 ms/op 1.04
computeSigningRoot for AttestationData 14.613 us/op 13.584 us/op 1.08
hash AttestationData serialized data then Buffer.toString(base64) 2.5625 us/op 2.5074 us/op 1.02
toHexString serialized data 1.1950 us/op 1.0796 us/op 1.11
Buffer.toString(base64) 356.84 ns/op 345.58 ns/op 1.03

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 7fc999e into unstable Jul 10, 2023
@wemeetagain wemeetagain deleted the nflaig/cleanup-winston branch July 10, 2023 19:43
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain