feat: add verifySignatureSetsSameMessage BLS api #5747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoeths
changed the title
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
reviewed
Jul 12, 2023
| const startNs = process.hrtime.bigint(); | ||
| const pubkey = bls.PublicKey.aggregate(sets.map((set) => set.publicKey)); | ||
| // validate signature = true | ||
| const signatures = sets.map((set) => bls.Signature.fromBytes(set.signature, CoordType.affine, true)); |
There was a problem hiding this comment.
Watch out, this can throw here and should be handled on a per-item basis
dapplion
reviewed
Jul 12, 2023
twoeths
force-pushed
the
tuyen/verifyManySignatureSetsSameMessage-lion-take
branch
from
b8491c7
to
52785b0
Compare
wemeetagain
reviewed
Jul 19, 2023
Comment on lines
468
to
477
| // Create new jobs for each pubkey set, and Promise.all all the results | ||
| for (const j of jobItemSameMessageToMultiSet(job)) { | ||
| if (j.opts.priority) { | ||
| this.jobs.unshift(j); | ||
| } else { | ||
| this.jobs.push(j); | ||
| } | ||
| } | ||
| this.metrics?.blsThreadPool.sameMessageRetryJobs.inc(1); | ||
| this.metrics?.blsThreadPool.sameMessageRetrySets.inc(job.sets.length); |
There was a problem hiding this comment.
Is it worth pulling this into a method since this block is repeated? eg: retryJobItemSameMessage
There was a problem hiding this comment.
👍 I extracted it to new method retryJobItemSameMessage
|
Tested on a mainnet node subscribing to all subnets
we'll likely have a flag to turn this batch attestation feature on/off later (to be done on another PR) |
wemeetagain
previously approved these changes
Jul 20, 2023
dapplion
approved these changes
Jul 20, 2023
|
🎉 This PR is included in v1.10.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
verifyMultipleSignatures()apicanAcceptWork()(if we should process a gossip message or not)Description
verifySignatureSetsSameMessage()bls apirunJob(), take that chance to aggregate pubkeys and signatures of JobQueueItemSameMessage and transform it to a regular BlsWorkReq, seejobItemWorkReqjobItemSameMessageToMultiSetpart of #5416