Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename data gas to blob gas for relevant deneb fields #5816

Merged
merged 2 commits into from
Aug 1, 2023
Merged

refactor: rename data gas to blob gas for relevant deneb fields #5816

merged 2 commits into from
Aug 1, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jul 28, 2023 •
edited
Loading

pursuant to

renaming data gas fields => blob gas

TODO:

  • spec tests update

@g11tech g11tech requested a review from a team as a code owner July 28, 2023 13:40
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 2b66e24 Previous: fef5c9c Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 494.07 us/op 715.27 us/op 0.69
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 78.158 us/op 74.015 us/op 1.06
BLS verify - blst-native 1.2324 ms/op 1.2081 ms/op 1.02
BLS verifyMultipleSignatures 3 - blst-native 2.5073 ms/op 2.4525 ms/op 1.02
BLS verifyMultipleSignatures 8 - blst-native 5.3761 ms/op 5.2769 ms/op 1.02
BLS verifyMultipleSignatures 32 - blst-native 19.388 ms/op 19.066 ms/op 1.02
BLS aggregatePubkeys 32 - blst-native 25.672 us/op 25.207 us/op 1.02
BLS aggregatePubkeys 128 - blst-native 100.89 us/op 99.091 us/op 1.02
getAttestationsForBlock 54.605 ms/op 49.390 ms/op 1.11
isKnown best case - 1 super set check 297.00 ns/op 260.00 ns/op 1.14
isKnown normal case - 2 super set checks 331.00 ns/op 259.00 ns/op 1.28
isKnown worse case - 16 super set checks 298.00 ns/op 263.00 ns/op 1.13
CheckpointStateCache - add get delete 5.1740 us/op 4.5260 us/op 1.14
validate api signedAggregateAndProof - struct 2.8314 ms/op 2.6169 ms/op 1.08
validate gossip signedAggregateAndProof - struct 2.8446 ms/op 2.6187 ms/op 1.09
validate api attestation - struct 1.3558 ms/op 1.2531 ms/op 1.08
validate gossip attestation - struct 1.3778 ms/op 1.2698 ms/op 1.09
pickEth1Vote - no votes 1.2561 ms/op 1.0887 ms/op 1.15
pickEth1Vote - max votes 8.5596 ms/op 10.024 ms/op 0.85
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.7542 ms/op 8.5839 ms/op 1.02
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 13.944 ms/op 17.939 ms/op 0.78
pickEth1Vote - Eth1Data fastSerialize value x2048 614.41 us/op 573.42 us/op 1.07
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.6845 ms/op 5.9540 ms/op 0.95
bytes32 toHexString 549.00 ns/op 495.00 ns/op 1.11
bytes32 Buffer.toString(hex) 331.00 ns/op 303.00 ns/op 1.09
bytes32 Buffer.toString(hex) from Uint8Array 490.00 ns/op 427.00 ns/op 1.15
bytes32 Buffer.toString(hex) + 0x 327.00 ns/op 296.00 ns/op 1.10
Object access 1 prop 0.18100 ns/op 0.16300 ns/op 1.11
Map access 1 prop 0.16200 ns/op 0.15700 ns/op 1.03
Object get x1000 7.5020 ns/op 7.5300 ns/op 1.00
Map get x1000 0.62500 ns/op 0.58200 ns/op 1.07
Object set x1000 54.298 ns/op 48.797 ns/op 1.11
Map set x1000 41.958 ns/op 39.030 ns/op 1.08
Return object 10000 times 0.25090 ns/op 0.23690 ns/op 1.06
Throw Error 10000 times 3.9947 us/op 3.8588 us/op 1.04
fastMsgIdFn sha256 / 200 bytes 3.4300 us/op 3.2510 us/op 1.06
fastMsgIdFn h32 xxhash / 200 bytes 332.00 ns/op 287.00 ns/op 1.16
fastMsgIdFn h64 xxhash / 200 bytes 386.00 ns/op 339.00 ns/op 1.14
fastMsgIdFn sha256 / 1000 bytes 11.530 us/op 11.327 us/op 1.02
fastMsgIdFn h32 xxhash / 1000 bytes 458.00 ns/op 428.00 ns/op 1.07
fastMsgIdFn h64 xxhash / 1000 bytes 439.00 ns/op 406.00 ns/op 1.08
fastMsgIdFn sha256 / 10000 bytes 104.19 us/op 102.36 us/op 1.02
fastMsgIdFn h32 xxhash / 10000 bytes 2.0130 us/op 1.9120 us/op 1.05
fastMsgIdFn h64 xxhash / 10000 bytes 1.3590 us/op 1.3020 us/op 1.04
enrSubnets - fastDeserialize 64 bits 1.3150 us/op 1.2410 us/op 1.06
enrSubnets - ssz BitVector 64 bits 444.00 ns/op 425.00 ns/op 1.04
enrSubnets - fastDeserialize 4 bits 193.00 ns/op 180.00 ns/op 1.07
enrSubnets - ssz BitVector 4 bits 475.00 ns/op 424.00 ns/op 1.12
prioritizePeers score -10:0 att 32-0.1 sync 2-0 104.11 us/op 100.17 us/op 1.04
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 129.87 us/op 117.94 us/op 1.10
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 187.42 us/op 153.97 us/op 1.22
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 304.38 us/op 274.29 us/op 1.11
prioritizePeers score 0:0 att 64-1 sync 4-1 360.72 us/op 321.27 us/op 1.12
array of 16000 items push then shift 1.6107 us/op 1.5389 us/op 1.05
LinkedList of 16000 items push then shift 9.0230 ns/op 8.6430 ns/op 1.04
array of 16000 items push then pop 58.227 ns/op 59.833 ns/op 0.97
LinkedList of 16000 items push then pop 8.9310 ns/op 8.7190 ns/op 1.02
array of 24000 items push then shift 2.8269 us/op 2.5833 us/op 1.09
LinkedList of 24000 items push then shift 14.866 ns/op 8.8800 ns/op 1.67
array of 24000 items push then pop 177.52 ns/op 116.82 ns/op 1.52
LinkedList of 24000 items push then pop 13.128 ns/op 8.5610 ns/op 1.53
intersect bitArray bitLen 8 8.3260 ns/op 6.7390 ns/op 1.24
intersect array and set length 8 127.53 ns/op 56.900 ns/op 2.24
intersect bitArray bitLen 128 35.106 ns/op 31.182 ns/op 1.13
intersect array and set length 128 1.1811 us/op 747.10 ns/op 1.58
bitArray.getTrueBitIndexes() bitLen 128 2.4590 us/op 1.3740 us/op 1.79
bitArray.getTrueBitIndexes() bitLen 248 4.3390 us/op 2.3980 us/op 1.81
bitArray.getTrueBitIndexes() bitLen 512 8.1650 us/op 4.9020 us/op 1.67
Buffer.concat 32 items 1.3600 us/op 1.0830 us/op 1.26
Uint8Array.set 32 items 2.1790 us/op 2.2230 us/op 0.98
transfer serialized Status (84 B) 2.0870 us/op 2.0090 us/op 1.04
copy serialized Status (84 B) 2.7480 us/op 1.6490 us/op 1.67
transfer serialized SignedVoluntaryExit (112 B) 3.3370 us/op 2.1380 us/op 1.56
copy serialized SignedVoluntaryExit (112 B) 2.5180 us/op 1.7750 us/op 1.42
transfer serialized ProposerSlashing (416 B) 3.1550 us/op 2.7530 us/op 1.15
copy serialized ProposerSlashing (416 B) 3.6180 us/op 2.3740 us/op 1.52
transfer serialized Attestation (485 B) 3.3350 us/op 2.5860 us/op 1.29
copy serialized Attestation (485 B) 3.2460 us/op 2.9290 us/op 1.11
transfer serialized AttesterSlashing (33232 B) 2.8140 us/op 2.7500 us/op 1.02
copy serialized AttesterSlashing (33232 B) 12.328 us/op 5.5840 us/op 2.21
transfer serialized Small SignedBeaconBlock (128000 B) 3.6170 us/op 2.8780 us/op 1.26
copy serialized Small SignedBeaconBlock (128000 B) 20.757 us/op 11.921 us/op 1.74
transfer serialized Avg SignedBeaconBlock (200000 B) 4.2950 us/op 3.0780 us/op 1.40
copy serialized Avg SignedBeaconBlock (200000 B) 27.945 us/op 17.052 us/op 1.64
transfer serialized BlobsSidecar (524380 B) 4.3950 us/op 2.9540 us/op 1.49
copy serialized BlobsSidecar (524380 B) 151.26 us/op 78.741 us/op 1.92
transfer serialized Big SignedBeaconBlock (1000000 B) 4.8490 us/op 2.9930 us/op 1.62
copy serialized Big SignedBeaconBlock (1000000 B) 180.41 us/op 152.30 us/op 1.18
pass gossip attestations to forkchoice per slot 2.2731 ms/op 2.1142 ms/op 1.08
forkChoice updateHead vc 100000 bc 64 eq 0 2.2247 ms/op 2.2301 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 0 15.173 ms/op 13.747 ms/op 1.10
forkChoice updateHead vc 1000000 bc 64 eq 0 24.138 ms/op 22.567 ms/op 1.07
forkChoice updateHead vc 600000 bc 320 eq 0 20.211 ms/op 17.576 ms/op 1.15
forkChoice updateHead vc 600000 bc 1200 eq 0 91.948 ms/op 84.080 ms/op 1.09
forkChoice updateHead vc 600000 bc 64 eq 1000 24.055 ms/op 22.513 ms/op 1.07
forkChoice updateHead vc 600000 bc 64 eq 10000 28.432 ms/op 24.683 ms/op 1.15
forkChoice updateHead vc 600000 bc 64 eq 300000 31.103 ms/op 29.585 ms/op 1.05
computeDeltas 3.8257 ms/op 3.0333 ms/op 1.26
computeProposerBoostScoreFromBalances 394.58 us/op 387.53 us/op 1.02
altair processAttestation - 250000 vs - 7PWei normalcase 2.3878 ms/op 2.1956 ms/op 1.09
altair processAttestation - 250000 vs - 7PWei worstcase 3.4819 ms/op 3.2832 ms/op 1.06
altair processAttestation - setStatus - 1/6 committees join 229.45 us/op 224.65 us/op 1.02
altair processAttestation - setStatus - 1/3 committees join 431.56 us/op 434.00 us/op 0.99
altair processAttestation - setStatus - 1/2 committees join 591.93 us/op 627.13 us/op 0.94
altair processAttestation - setStatus - 2/3 committees join 775.43 us/op 746.75 us/op 1.04
altair processAttestation - setStatus - 4/5 committees join 1.0412 ms/op 1.0428 ms/op 1.00
altair processAttestation - setStatus - 100% committees join 1.2220 ms/op 1.1594 ms/op 1.05
altair processBlock - 250000 vs - 7PWei normalcase 9.6352 ms/op 9.3046 ms/op 1.04
altair processBlock - 250000 vs - 7PWei normalcase hashState 17.000 ms/op 15.848 ms/op 1.07
altair processBlock - 250000 vs - 7PWei worstcase 39.225 ms/op 39.369 ms/op 1.00
altair processBlock - 250000 vs - 7PWei worstcase hashState 58.372 ms/op 60.596 ms/op 0.96
phase0 processBlock - 250000 vs - 7PWei normalcase 1.9250 ms/op 1.9590 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei worstcase 28.479 ms/op 28.183 ms/op 1.01
altair processEth1Data - 250000 vs - 7PWei normalcase 482.90 us/op 478.26 us/op 1.01
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 14.718 us/op 12.914 us/op 1.14
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 51.842 us/op 36.545 us/op 1.42
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 20.563 us/op 16.580 us/op 1.24
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 14.878 us/op 13.790 us/op 1.08
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 184.62 us/op 159.16 us/op 1.16
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.1444 ms/op 1.3835 ms/op 0.83
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.8716 ms/op 1.9218 ms/op 0.97
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.8426 ms/op 1.8984 ms/op 0.97
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.6358 ms/op 3.3106 ms/op 1.40
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.9442 ms/op 3.1082 ms/op 0.95
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 6.4760 ms/op 5.3042 ms/op 1.22
Tree 40 250000 create 373.50 ms/op 311.57 ms/op 1.20
Tree 40 250000 get(125000) 224.31 ns/op 194.98 ns/op 1.15
Tree 40 250000 set(125000) 1.0963 us/op 884.00 ns/op 1.24
Tree 40 250000 toArray() 22.457 ms/op 17.926 ms/op 1.25
Tree 40 250000 iterate all - toArray() + loop 22.797 ms/op 18.254 ms/op 1.25
Tree 40 250000 iterate all - get(i) 74.910 ms/op 67.388 ms/op 1.11
MutableVector 250000 create 13.783 ms/op 11.383 ms/op 1.21
MutableVector 250000 get(125000) 6.9760 ns/op 6.5640 ns/op 1.06
MutableVector 250000 set(125000) 274.26 ns/op 264.92 ns/op 1.04
MutableVector 250000 toArray() 2.7634 ms/op 3.0409 ms/op 0.91
MutableVector 250000 iterate all - toArray() + loop 2.9250 ms/op 3.0221 ms/op 0.97
MutableVector 250000 iterate all - get(i) 1.5742 ms/op 1.5503 ms/op 1.02
Array 250000 create 2.6485 ms/op 2.9133 ms/op 0.91
Array 250000 clone - spread 1.0678 ms/op 1.1838 ms/op 0.90
Array 250000 get(125000) 0.55200 ns/op 0.60600 ns/op 0.91
Array 250000 set(125000) 0.63400 ns/op 0.67600 ns/op 0.94
Array 250000 iterate all - loop 87.592 us/op 83.911 us/op 1.04
effectiveBalanceIncrements clone Uint8Array 300000 26.292 us/op 26.352 us/op 1.00
effectiveBalanceIncrements clone MutableVector 300000 314.00 ns/op 376.00 ns/op 0.84
effectiveBalanceIncrements rw all Uint8Array 300000 180.60 us/op 177.43 us/op 1.02
effectiveBalanceIncrements rw all MutableVector 300000 92.089 ms/op 83.247 ms/op 1.11
phase0 afterProcessEpoch - 250000 vs - 7PWei 115.65 ms/op 118.78 ms/op 0.97
phase0 beforeProcessEpoch - 250000 vs - 7PWei 41.214 ms/op 39.827 ms/op 1.03
altair processEpoch - mainnet_e81889 315.19 ms/op 344.75 ms/op 0.91
mainnet_e81889 - altair beforeProcessEpoch 59.772 ms/op 64.640 ms/op 0.92
mainnet_e81889 - altair processJustificationAndFinalization 16.136 us/op 15.135 us/op 1.07
mainnet_e81889 - altair processInactivityUpdates 6.8352 ms/op 5.3140 ms/op 1.29
mainnet_e81889 - altair processRewardsAndPenalties 64.137 ms/op 77.261 ms/op 0.83
mainnet_e81889 - altair processRegistryUpdates 2.8190 us/op 2.2360 us/op 1.26
mainnet_e81889 - altair processSlashings 475.00 ns/op 506.00 ns/op 0.94
mainnet_e81889 - altair processEth1DataReset 506.00 ns/op 562.00 ns/op 0.90
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3039 ms/op 1.5166 ms/op 0.86
mainnet_e81889 - altair processSlashingsReset 2.8980 us/op 2.4020 us/op 1.21
mainnet_e81889 - altair processRandaoMixesReset 7.1280 us/op 4.4720 us/op 1.59
mainnet_e81889 - altair processHistoricalRootsUpdate 862.00 ns/op 674.00 ns/op 1.28
mainnet_e81889 - altair processParticipationFlagUpdates 3.4560 us/op 1.9450 us/op 1.78
mainnet_e81889 - altair processSyncCommitteeUpdates 1.0430 us/op 726.00 ns/op 1.44
mainnet_e81889 - altair afterProcessEpoch 131.36 ms/op 126.14 ms/op 1.04
capella processEpoch - mainnet_e217614 1.0373 s/op 1.0805 s/op 0.96
mainnet_e217614 - capella beforeProcessEpoch 247.19 ms/op 240.15 ms/op 1.03
mainnet_e217614 - capella processJustificationAndFinalization 20.280 us/op 19.776 us/op 1.03
mainnet_e217614 - capella processInactivityUpdates 18.257 ms/op 15.575 ms/op 1.17
mainnet_e217614 - capella processRewardsAndPenalties 298.52 ms/op 333.85 ms/op 0.89
mainnet_e217614 - capella processRegistryUpdates 25.898 us/op 24.634 us/op 1.05
mainnet_e217614 - capella processSlashings 758.00 ns/op 539.00 ns/op 1.41
mainnet_e217614 - capella processEth1DataReset 800.00 ns/op 735.00 ns/op 1.09
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.3031 ms/op 4.1743 ms/op 1.03
mainnet_e217614 - capella processSlashingsReset 2.6600 us/op 2.4310 us/op 1.09
mainnet_e217614 - capella processRandaoMixesReset 11.018 us/op 5.6910 us/op 1.94
mainnet_e217614 - capella processHistoricalRootsUpdate 1.4450 us/op 669.00 ns/op 2.16
mainnet_e217614 - capella processParticipationFlagUpdates 4.2280 us/op 1.7940 us/op 2.36
mainnet_e217614 - capella afterProcessEpoch 290.95 ms/op 299.31 ms/op 0.97
phase0 processEpoch - mainnet_e58758 338.99 ms/op 394.63 ms/op 0.86
mainnet_e58758 - phase0 beforeProcessEpoch 102.45 ms/op 157.92 ms/op 0.65
mainnet_e58758 - phase0 processJustificationAndFinalization 14.843 us/op 21.354 us/op 0.70
mainnet_e58758 - phase0 processRewardsAndPenalties 54.805 ms/op 73.761 ms/op 0.74
mainnet_e58758 - phase0 processRegistryUpdates 9.1220 us/op 11.811 us/op 0.77
mainnet_e58758 - phase0 processSlashings 582.00 ns/op 1.0640 us/op 0.55
mainnet_e58758 - phase0 processEth1DataReset 425.00 ns/op 574.00 ns/op 0.74
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 976.74 us/op 1.0093 ms/op 0.97
mainnet_e58758 - phase0 processSlashingsReset 2.1040 us/op 2.1440 us/op 0.98
mainnet_e58758 - phase0 processRandaoMixesReset 3.7390 us/op 3.4570 us/op 1.08
mainnet_e58758 - phase0 processHistoricalRootsUpdate 701.00 ns/op 455.00 ns/op 1.54
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.8650 us/op 5.8680 us/op 0.66
mainnet_e58758 - phase0 afterProcessEpoch 100.13 ms/op 93.579 ms/op 1.07
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.9393 ms/op 1.2458 ms/op 1.56
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4599 ms/op 1.4680 ms/op 0.99
altair processInactivityUpdates - 250000 normalcase 25.458 ms/op 26.521 ms/op 0.96
altair processInactivityUpdates - 250000 worstcase 24.982 ms/op 22.990 ms/op 1.09
phase0 processRegistryUpdates - 250000 normalcase 10.625 us/op 10.078 us/op 1.05
phase0 processRegistryUpdates - 250000 badcase_full_deposits 349.26 us/op 499.36 us/op 0.70
phase0 processRegistryUpdates - 250000 worstcase 0.5 112.35 ms/op 138.22 ms/op 0.81
altair processRewardsAndPenalties - 250000 normalcase 71.650 ms/op 82.412 ms/op 0.87
altair processRewardsAndPenalties - 250000 worstcase 71.667 ms/op 81.491 ms/op 0.88
phase0 getAttestationDeltas - 250000 normalcase 7.5512 ms/op 7.9260 ms/op 0.95
phase0 getAttestationDeltas - 250000 worstcase 7.5952 ms/op 7.8286 ms/op 0.97
phase0 processSlashings - 250000 worstcase 2.2822 ms/op 2.3721 ms/op 0.96
altair processSyncCommitteeUpdates - 250000 156.56 ms/op 157.03 ms/op 1.00
BeaconState.hashTreeRoot - No change 294.00 ns/op 289.00 ns/op 1.02
BeaconState.hashTreeRoot - 1 full validator 50.411 us/op 49.681 us/op 1.01
BeaconState.hashTreeRoot - 32 full validator 496.03 us/op 488.14 us/op 1.02
BeaconState.hashTreeRoot - 512 full validator 5.1896 ms/op 5.3277 ms/op 0.97
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 61.674 us/op 63.486 us/op 0.97
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 857.99 us/op 856.79 us/op 1.00
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 10.423 ms/op 10.589 ms/op 0.98
BeaconState.hashTreeRoot - 1 balances 47.829 us/op 47.855 us/op 1.00
BeaconState.hashTreeRoot - 32 balances 432.43 us/op 424.18 us/op 1.02
BeaconState.hashTreeRoot - 512 balances 3.8344 ms/op 3.8896 ms/op 0.99
BeaconState.hashTreeRoot - 250000 balances 75.240 ms/op 80.260 ms/op 0.94
aggregationBits - 2048 els - zipIndexesInBitList 14.209 us/op 14.879 us/op 0.95
regular array get 100000 times 36.477 us/op 44.302 us/op 0.82
wrappedArray get 100000 times 32.754 us/op 43.741 us/op 0.75
arrayWithProxy get 100000 times 14.656 ms/op 14.584 ms/op 1.00
ssz.Root.equals 215.00 ns/op 234.00 ns/op 0.92
byteArrayEquals 219.00 ns/op 216.00 ns/op 1.01
shuffle list - 16384 els 6.7013 ms/op 6.9219 ms/op 0.97
shuffle list - 250000 els 98.240 ms/op 102.88 ms/op 0.95
processSlot - 1 slots 7.9670 us/op 7.7810 us/op 1.02
processSlot - 32 slots 1.3566 ms/op 1.3077 ms/op 1.04
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 54.873 ms/op 58.689 ms/op 0.93
getCommitteeAssignments - req 1 vs - 250000 vc 2.5050 ms/op 2.5317 ms/op 0.99
getCommitteeAssignments - req 100 vs - 250000 vc 3.7366 ms/op 3.7501 ms/op 1.00
getCommitteeAssignments - req 1000 vs - 250000 vc 4.0318 ms/op 4.1030 ms/op 0.98
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.0700 ns/op 5.5300 ns/op 0.92
state getBlockRootAtSlot - 250000 vs - 7PWei 712.54 ns/op 1.0136 us/op 0.70
computeProposers - vc 250000 9.0645 ms/op 9.3492 ms/op 0.97
computeEpochShuffling - vc 250000 100.94 ms/op 107.82 ms/op 0.94
getNextSyncCommittee - vc 250000 152.94 ms/op 154.23 ms/op 0.99
computeSigningRoot for AttestationData 13.927 us/op 12.848 us/op 1.08
hash AttestationData serialized data then Buffer.toString(base64) 2.3553 us/op 2.3958 us/op 0.98
toHexString serialized data 1.0569 us/op 1.1056 us/op 0.96
Buffer.toString(base64) 215.87 ns/op 242.94 ns/op 0.89

by benchmarkbot/action

dapplion
dapplion previously approved these changes Jul 28, 2023
View reviewed changes
@g11tech g11tech enabled auto-merge (squash) August 1, 2023 08:58
matthewkeil
matthewkeil approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm 🚀

I noticed that we do not have a test for
tests/core/pyspec/eth2spec/test/helpers/sharding.py from the spec. Is that the only spec we still need to add to our suite?

Also the question about the magic string for specVersion. Not sure if those would ever want to be different or not.

packages/beacon-node/test/spec/specTestVersioning.ts
@@ -15,7 +15,7 @@ import {DownloadTestsOptions} from "@lodestar/spec-test-util";
const __dirname = path.dirname(fileURLToPath(import.meta.url));

export const ethereumConsensusSpecsTests: DownloadTestsOptions = {
specVersion: "v1.4.0-beta.0",
specVersion: "v1.4.0-beta.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why do we have this magic string in this file and in packages/params/test/e2e/ensure-config-is-synced.test.ts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this corresponds to protocol spec test releases (which go hand in hand with spec releases) : https://github.com/ethereum/consensus-spec-tests/releases

@g11tech g11tech merged commit 67b6e79 into unstable Aug 1, 2023
12 checks passed
@g11tech g11tech deleted the rename-blobgas branch August 1, 2023 09:31
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewkeil matthewkeil matthewkeil approved these changes

@dapplion dapplion dapplion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g11tech @wemeetagain @matthewkeil @dapplion