Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make SLOTS_TO_SUBSCRIBE_IN_ADVANCE as hidden cli param #5819

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix: make SLOTS_TO_SUBSCRIBE_IN_ADVANCE as hidden cli param #5819

merged 1 commit into from
Jul 31, 2023

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jul 30, 2023

Motivation

See #5810 (comment)

Description

  • Introduce hidden cli flag slotsToSubscribeBeforeAggregatorDuty, default to 2, and use it in subnet services

@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 2121dca Previous: 19b723c Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 744.71 us/op 772.23 us/op 0.96
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 77.014 us/op 75.456 us/op 1.02
BLS verify - blst-native 1.1941 ms/op 1.2092 ms/op 0.99
BLS verifyMultipleSignatures 3 - blst-native 2.4360 ms/op 2.4736 ms/op 0.98
BLS verifyMultipleSignatures 8 - blst-native 5.2413 ms/op 5.3734 ms/op 0.98
BLS verifyMultipleSignatures 32 - blst-native 18.906 ms/op 19.118 ms/op 0.99
BLS aggregatePubkeys 32 - blst-native 25.063 us/op 25.582 us/op 0.98
BLS aggregatePubkeys 128 - blst-native 98.757 us/op 99.168 us/op 1.00
getAttestationsForBlock 49.726 ms/op 50.251 ms/op 0.99
isKnown best case - 1 super set check 281.00 ns/op 271.00 ns/op 1.04
isKnown normal case - 2 super set checks 278.00 ns/op 263.00 ns/op 1.06
isKnown worse case - 16 super set checks 276.00 ns/op 284.00 ns/op 0.97
CheckpointStateCache - add get delete 4.7690 us/op 4.7000 us/op 1.01
validate api signedAggregateAndProof - struct 2.7625 ms/op 2.7113 ms/op 1.02
validate gossip signedAggregateAndProof - struct 2.7868 ms/op 2.7131 ms/op 1.03
validate api attestation - struct 1.3271 ms/op 1.2954 ms/op 1.02
validate gossip attestation - struct 1.3463 ms/op 1.3149 ms/op 1.02
pickEth1Vote - no votes 1.1690 ms/op 1.1595 ms/op 1.01
pickEth1Vote - max votes 10.385 ms/op 10.659 ms/op 0.97
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.7915 ms/op 8.5414 ms/op 1.03
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 12.888 ms/op 14.207 ms/op 0.91
pickEth1Vote - Eth1Data fastSerialize value x2048 556.41 us/op 562.29 us/op 0.99
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.7004 ms/op 6.5854 ms/op 1.02
bytes32 toHexString 488.00 ns/op 486.00 ns/op 1.00
bytes32 Buffer.toString(hex) 291.00 ns/op 294.00 ns/op 0.99
bytes32 Buffer.toString(hex) from Uint8Array 433.00 ns/op 430.00 ns/op 1.01
bytes32 Buffer.toString(hex) + 0x 297.00 ns/op 298.00 ns/op 1.00
Object access 1 prop 0.16100 ns/op 0.15700 ns/op 1.03
Map access 1 prop 0.14500 ns/op 0.14300 ns/op 1.01
Object get x1000 7.1730 ns/op 7.7880 ns/op 0.92
Map get x1000 0.60800 ns/op 0.51400 ns/op 1.18
Object set x1000 48.047 ns/op 48.961 ns/op 0.98
Map set x1000 38.560 ns/op 38.750 ns/op 1.00
Return object 10000 times 0.23530 ns/op 0.23430 ns/op 1.00
Throw Error 10000 times 3.8152 us/op 3.8302 us/op 1.00
fastMsgIdFn sha256 / 200 bytes 3.2340 us/op 3.3130 us/op 0.98
fastMsgIdFn h32 xxhash / 200 bytes 295.00 ns/op 285.00 ns/op 1.04
fastMsgIdFn h64 xxhash / 200 bytes 340.00 ns/op 339.00 ns/op 1.00
fastMsgIdFn sha256 / 1000 bytes 11.444 us/op 11.251 us/op 1.02
fastMsgIdFn h32 xxhash / 1000 bytes 420.00 ns/op 414.00 ns/op 1.01
fastMsgIdFn h64 xxhash / 1000 bytes 413.00 ns/op 413.00 ns/op 1.00
fastMsgIdFn sha256 / 10000 bytes 103.39 us/op 103.33 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 1.9280 us/op 1.9110 us/op 1.01
fastMsgIdFn h64 xxhash / 10000 bytes 1.3280 us/op 1.2980 us/op 1.02
enrSubnets - fastDeserialize 64 bits 1.2160 us/op 1.2210 us/op 1.00
enrSubnets - ssz BitVector 64 bits 409.00 ns/op 417.00 ns/op 0.98
enrSubnets - fastDeserialize 4 bits 177.00 ns/op 169.00 ns/op 1.05
enrSubnets - ssz BitVector 4 bits 414.00 ns/op 419.00 ns/op 0.99
prioritizePeers score -10:0 att 32-0.1 sync 2-0 97.900 us/op 96.667 us/op 1.01
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 121.90 us/op 132.24 us/op 0.92
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 158.97 us/op 165.05 us/op 0.96
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 286.67 us/op 288.00 us/op 1.00
prioritizePeers score 0:0 att 64-1 sync 4-1 331.96 us/op 335.54 us/op 0.99
array of 16000 items push then shift 1.5728 us/op 1.5907 us/op 0.99
LinkedList of 16000 items push then shift 8.9080 ns/op 8.9420 ns/op 1.00
array of 16000 items push then pop 53.334 ns/op 50.794 ns/op 1.05
LinkedList of 16000 items push then pop 8.3600 ns/op 8.4350 ns/op 0.99
array of 24000 items push then shift 2.3848 us/op 2.3434 us/op 1.02
LinkedList of 24000 items push then shift 8.5420 ns/op 8.5630 ns/op 1.00
array of 24000 items push then pop 99.666 ns/op 68.658 ns/op 1.45
LinkedList of 24000 items push then pop 8.2480 ns/op 8.5060 ns/op 0.97
intersect bitArray bitLen 8 6.6430 ns/op 6.7400 ns/op 0.99
intersect array and set length 8 55.777 ns/op 57.759 ns/op 0.97
intersect bitArray bitLen 128 30.830 ns/op 31.584 ns/op 0.98
intersect array and set length 128 749.61 ns/op 784.92 ns/op 0.96
bitArray.getTrueBitIndexes() bitLen 128 1.5070 us/op 1.4950 us/op 1.01
bitArray.getTrueBitIndexes() bitLen 248 2.4040 us/op 2.5520 us/op 0.94
bitArray.getTrueBitIndexes() bitLen 512 4.7520 us/op 4.8640 us/op 0.98
Buffer.concat 32 items 1.0230 us/op 1.0250 us/op 1.00
Uint8Array.set 32 items 2.3370 us/op 1.8930 us/op 1.23
transfer serialized Status (84 B) 1.9440 us/op 1.8460 us/op 1.05
copy serialized Status (84 B) 1.5750 us/op 1.5110 us/op 1.04
transfer serialized SignedVoluntaryExit (112 B) 2.1140 us/op 1.9650 us/op 1.08
copy serialized SignedVoluntaryExit (112 B) 1.7280 us/op 1.5820 us/op 1.09
transfer serialized ProposerSlashing (416 B) 2.7180 us/op 2.3650 us/op 1.15
copy serialized ProposerSlashing (416 B) 2.1100 us/op 2.2130 us/op 0.95
transfer serialized Attestation (485 B) 2.6050 us/op 2.3860 us/op 1.09
copy serialized Attestation (485 B) 2.3860 us/op 2.1920 us/op 1.09
transfer serialized AttesterSlashing (33232 B) 2.7890 us/op 2.5160 us/op 1.11
copy serialized AttesterSlashing (33232 B) 5.7140 us/op 4.6540 us/op 1.23
transfer serialized Small SignedBeaconBlock (128000 B) 2.9320 us/op 2.5950 us/op 1.13
copy serialized Small SignedBeaconBlock (128000 B) 12.299 us/op 11.326 us/op 1.09
transfer serialized Avg SignedBeaconBlock (200000 B) 3.2540 us/op 2.8410 us/op 1.15
copy serialized Avg SignedBeaconBlock (200000 B) 17.525 us/op 16.421 us/op 1.07
transfer serialized BlobsSidecar (524380 B) 3.0130 us/op 2.6100 us/op 1.15
copy serialized BlobsSidecar (524380 B) 76.361 us/op 112.55 us/op 0.68
transfer serialized Big SignedBeaconBlock (1000000 B) 3.0880 us/op 2.6740 us/op 1.15
copy serialized Big SignedBeaconBlock (1000000 B) 144.13 us/op 143.95 us/op 1.00
pass gossip attestations to forkchoice per slot 2.0947 ms/op 2.0369 ms/op 1.03
forkChoice updateHead vc 100000 bc 64 eq 0 2.3155 ms/op 2.0181 ms/op 1.15
forkChoice updateHead vc 600000 bc 64 eq 0 13.657 ms/op 13.460 ms/op 1.01
forkChoice updateHead vc 1000000 bc 64 eq 0 22.438 ms/op 21.844 ms/op 1.03
forkChoice updateHead vc 600000 bc 320 eq 0 17.008 ms/op 17.198 ms/op 0.99
forkChoice updateHead vc 600000 bc 1200 eq 0 84.304 ms/op 80.755 ms/op 1.04
forkChoice updateHead vc 600000 bc 64 eq 1000 21.925 ms/op 22.175 ms/op 0.99
forkChoice updateHead vc 600000 bc 64 eq 10000 25.155 ms/op 24.339 ms/op 1.03
forkChoice updateHead vc 600000 bc 64 eq 300000 29.121 ms/op 29.180 ms/op 1.00
computeDeltas 2.9839 ms/op 2.9503 ms/op 1.01
computeProposerBoostScoreFromBalances 385.55 us/op 384.86 us/op 1.00
altair processAttestation - 250000 vs - 7PWei normalcase 2.1854 ms/op 2.0761 ms/op 1.05
altair processAttestation - 250000 vs - 7PWei worstcase 3.2123 ms/op 3.1726 ms/op 1.01
altair processAttestation - setStatus - 1/6 committees join 216.60 us/op 238.06 us/op 0.91
altair processAttestation - setStatus - 1/3 committees join 394.34 us/op 416.74 us/op 0.95
altair processAttestation - setStatus - 1/2 committees join 562.45 us/op 593.36 us/op 0.95
altair processAttestation - setStatus - 2/3 committees join 700.02 us/op 754.87 us/op 0.93
altair processAttestation - setStatus - 4/5 committees join 1.0332 ms/op 991.22 us/op 1.04
altair processAttestation - setStatus - 100% committees join 1.1461 ms/op 1.1930 ms/op 0.96
altair processBlock - 250000 vs - 7PWei normalcase 9.4174 ms/op 9.2007 ms/op 1.02
altair processBlock - 250000 vs - 7PWei normalcase hashState 17.526 ms/op 16.968 ms/op 1.03
altair processBlock - 250000 vs - 7PWei worstcase 38.060 ms/op 36.412 ms/op 1.05
altair processBlock - 250000 vs - 7PWei worstcase hashState 59.689 ms/op 57.850 ms/op 1.03
phase0 processBlock - 250000 vs - 7PWei normalcase 1.9988 ms/op 1.9233 ms/op 1.04
phase0 processBlock - 250000 vs - 7PWei worstcase 28.617 ms/op 27.850 ms/op 1.03
altair processEth1Data - 250000 vs - 7PWei normalcase 473.11 us/op 487.17 us/op 0.97
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 9.9730 us/op 9.1750 us/op 1.09
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 64.331 us/op 49.336 us/op 1.30
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 11.173 us/op 15.560 us/op 0.72
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 10.593 us/op 7.1280 us/op 1.49
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 156.63 us/op 126.64 us/op 1.24
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.1510 ms/op 1.0489 ms/op 1.10
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.8374 ms/op 1.4673 ms/op 1.25
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.6208 ms/op 1.4084 ms/op 1.15
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.0845 ms/op 2.8806 ms/op 1.42
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.5298 ms/op 2.3301 ms/op 1.09
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 5.5037 ms/op 4.9232 ms/op 1.12
Tree 40 250000 create 357.42 ms/op 291.91 ms/op 1.22
Tree 40 250000 get(125000) 216.07 ns/op 192.20 ns/op 1.12
Tree 40 250000 set(125000) 1.0600 us/op 840.51 ns/op 1.26
Tree 40 250000 toArray() 22.461 ms/op 17.658 ms/op 1.27
Tree 40 250000 iterate all - toArray() + loop 23.037 ms/op 18.109 ms/op 1.27
Tree 40 250000 iterate all - get(i) 76.361 ms/op 65.648 ms/op 1.16
MutableVector 250000 create 10.863 ms/op 11.733 ms/op 0.93
MutableVector 250000 get(125000) 6.6770 ns/op 6.4960 ns/op 1.03
MutableVector 250000 set(125000) 279.77 ns/op 252.85 ns/op 1.11
MutableVector 250000 toArray() 2.8289 ms/op 2.7413 ms/op 1.03
MutableVector 250000 iterate all - toArray() + loop 2.9833 ms/op 2.9264 ms/op 1.02
MutableVector 250000 iterate all - get(i) 1.5557 ms/op 1.5347 ms/op 1.01
Array 250000 create 2.6067 ms/op 2.5461 ms/op 1.02
Array 250000 clone - spread 951.40 us/op 1.1248 ms/op 0.85
Array 250000 get(125000) 0.50100 ns/op 0.55600 ns/op 0.90
Array 250000 set(125000) 0.58400 ns/op 0.62900 ns/op 0.93
Array 250000 iterate all - loop 83.957 us/op 79.735 us/op 1.05
effectiveBalanceIncrements clone Uint8Array 300000 21.869 us/op 25.705 us/op 0.85
effectiveBalanceIncrements clone MutableVector 300000 268.00 ns/op 335.00 ns/op 0.80
effectiveBalanceIncrements rw all Uint8Array 300000 181.71 us/op 173.48 us/op 1.05
effectiveBalanceIncrements rw all MutableVector 300000 74.478 ms/op 78.684 ms/op 0.95
phase0 afterProcessEpoch - 250000 vs - 7PWei 115.17 ms/op 112.18 ms/op 1.03
phase0 beforeProcessEpoch - 250000 vs - 7PWei 37.148 ms/op 30.511 ms/op 1.22
altair processEpoch - mainnet_e81889 304.31 ms/op 315.03 ms/op 0.97
mainnet_e81889 - altair beforeProcessEpoch 60.941 ms/op 58.395 ms/op 1.04
mainnet_e81889 - altair processJustificationAndFinalization 13.355 us/op 13.324 us/op 1.00
mainnet_e81889 - altair processInactivityUpdates 5.2032 ms/op 5.3442 ms/op 0.97
mainnet_e81889 - altair processRewardsAndPenalties 65.614 ms/op 62.663 ms/op 1.05
mainnet_e81889 - altair processRegistryUpdates 2.2390 us/op 2.3690 us/op 0.95
mainnet_e81889 - altair processSlashings 505.00 ns/op 400.00 ns/op 1.26
mainnet_e81889 - altair processEth1DataReset 430.00 ns/op 507.00 ns/op 0.85
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2331 ms/op 1.2134 ms/op 1.02
mainnet_e81889 - altair processSlashingsReset 3.0650 us/op 2.7880 us/op 1.10
mainnet_e81889 - altair processRandaoMixesReset 4.3970 us/op 4.9070 us/op 0.90
mainnet_e81889 - altair processHistoricalRootsUpdate 852.00 ns/op 852.00 ns/op 1.00
mainnet_e81889 - altair processParticipationFlagUpdates 1.7850 us/op 1.9910 us/op 0.90
mainnet_e81889 - altair processSyncCommitteeUpdates 615.00 ns/op 543.00 ns/op 1.13
mainnet_e81889 - altair afterProcessEpoch 123.71 ms/op 124.65 ms/op 0.99
capella processEpoch - mainnet_e217614 1.0008 s/op 1.0235 s/op 0.98
mainnet_e217614 - capella beforeProcessEpoch 226.72 ms/op 218.86 ms/op 1.04
mainnet_e217614 - capella processJustificationAndFinalization 12.509 us/op 14.202 us/op 0.88
mainnet_e217614 - capella processInactivityUpdates 15.745 ms/op 19.071 ms/op 0.83
mainnet_e217614 - capella processRewardsAndPenalties 278.48 ms/op 282.90 ms/op 0.98
mainnet_e217614 - capella processRegistryUpdates 16.969 us/op 16.740 us/op 1.01
mainnet_e217614 - capella processSlashings 463.00 ns/op 475.00 ns/op 0.97
mainnet_e217614 - capella processEth1DataReset 411.00 ns/op 452.00 ns/op 0.91
mainnet_e217614 - capella processEffectiveBalanceUpdates 3.9604 ms/op 3.9466 ms/op 1.00
mainnet_e217614 - capella processSlashingsReset 2.2660 us/op 2.1860 us/op 1.04
mainnet_e217614 - capella processRandaoMixesReset 3.9940 us/op 3.6940 us/op 1.08
mainnet_e217614 - capella processHistoricalRootsUpdate 379.00 ns/op 546.00 ns/op 0.69
mainnet_e217614 - capella processParticipationFlagUpdates 1.9100 us/op 1.6230 us/op 1.18
mainnet_e217614 - capella afterProcessEpoch 291.83 ms/op 294.70 ms/op 0.99
phase0 processEpoch - mainnet_e58758 327.67 ms/op 320.02 ms/op 1.02
mainnet_e58758 - phase0 beforeProcessEpoch 115.44 ms/op 114.76 ms/op 1.01
mainnet_e58758 - phase0 processJustificationAndFinalization 15.189 us/op 14.577 us/op 1.04
mainnet_e58758 - phase0 processRewardsAndPenalties 57.293 ms/op 53.374 ms/op 1.07
mainnet_e58758 - phase0 processRegistryUpdates 8.6230 us/op 9.4150 us/op 0.92
mainnet_e58758 - phase0 processSlashings 511.00 ns/op 504.00 ns/op 1.01
mainnet_e58758 - phase0 processEth1DataReset 417.00 ns/op 424.00 ns/op 0.98
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 968.87 us/op 940.48 us/op 1.03
mainnet_e58758 - phase0 processSlashingsReset 2.2420 us/op 2.0910 us/op 1.07
mainnet_e58758 - phase0 processRandaoMixesReset 3.7000 us/op 3.7730 us/op 0.98
mainnet_e58758 - phase0 processHistoricalRootsUpdate 413.00 ns/op 587.00 ns/op 0.70
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.3210 us/op 3.3140 us/op 1.00
mainnet_e58758 - phase0 afterProcessEpoch 96.851 ms/op 100.72 ms/op 0.96
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2081 ms/op 1.1883 ms/op 1.02
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4002 ms/op 1.4424 ms/op 0.97
altair processInactivityUpdates - 250000 normalcase 18.425 ms/op 18.413 ms/op 1.00
altair processInactivityUpdates - 250000 worstcase 18.314 ms/op 20.601 ms/op 0.89
phase0 processRegistryUpdates - 250000 normalcase 7.6530 us/op 8.6520 us/op 0.88
phase0 processRegistryUpdates - 250000 badcase_full_deposits 313.62 us/op 307.09 us/op 1.02
phase0 processRegistryUpdates - 250000 worstcase 0.5 121.06 ms/op 123.62 ms/op 0.98
altair processRewardsAndPenalties - 250000 normalcase 56.541 ms/op 57.403 ms/op 0.98
altair processRewardsAndPenalties - 250000 worstcase 57.555 ms/op 56.468 ms/op 1.02
phase0 getAttestationDeltas - 250000 normalcase 7.6368 ms/op 7.5840 ms/op 1.01
phase0 getAttestationDeltas - 250000 worstcase 7.8342 ms/op 7.6661 ms/op 1.02
phase0 processSlashings - 250000 worstcase 2.3469 ms/op 2.1955 ms/op 1.07
altair processSyncCommitteeUpdates - 250000 147.64 ms/op 139.13 ms/op 1.06
BeaconState.hashTreeRoot - No change 288.00 ns/op 278.00 ns/op 1.04
BeaconState.hashTreeRoot - 1 full validator 50.131 us/op 47.548 us/op 1.05
BeaconState.hashTreeRoot - 32 full validator 490.36 us/op 462.29 us/op 1.06
BeaconState.hashTreeRoot - 512 full validator 5.0671 ms/op 4.8522 ms/op 1.04
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 60.472 us/op 57.723 us/op 1.05
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 818.39 us/op 790.89 us/op 1.03
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 10.204 ms/op 9.7362 ms/op 1.05
BeaconState.hashTreeRoot - 1 balances 47.804 us/op 44.944 us/op 1.06
BeaconState.hashTreeRoot - 32 balances 431.00 us/op 400.38 us/op 1.08
BeaconState.hashTreeRoot - 512 balances 3.9069 ms/op 3.6808 ms/op 1.06
BeaconState.hashTreeRoot - 250000 balances 75.573 ms/op 73.866 ms/op 1.02
aggregationBits - 2048 els - zipIndexesInBitList 15.283 us/op 14.156 us/op 1.08
regular array get 100000 times 33.483 us/op 31.925 us/op 1.05
wrappedArray get 100000 times 33.483 us/op 42.530 us/op 0.79
arrayWithProxy get 100000 times 14.673 ms/op 13.905 ms/op 1.06
ssz.Root.equals 211.00 ns/op 202.00 ns/op 1.04
byteArrayEquals 209.00 ns/op 197.00 ns/op 1.06
shuffle list - 16384 els 6.9070 ms/op 6.7637 ms/op 1.02
shuffle list - 250000 els 101.34 ms/op 99.316 ms/op 1.02
processSlot - 1 slots 7.3530 us/op 7.4210 us/op 0.99
processSlot - 32 slots 1.2892 ms/op 1.2950 ms/op 1.00
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 49.805 ms/op 53.001 ms/op 0.94
getCommitteeAssignments - req 1 vs - 250000 vc 2.4864 ms/op 2.5032 ms/op 0.99
getCommitteeAssignments - req 100 vs - 250000 vc 3.6697 ms/op 3.6998 ms/op 0.99
getCommitteeAssignments - req 1000 vs - 250000 vc 3.9952 ms/op 4.0178 ms/op 0.99
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.5400 ns/op 4.4500 ns/op 1.02
state getBlockRootAtSlot - 250000 vs - 7PWei 807.91 ns/op 703.29 ns/op 1.15
computeProposers - vc 250000 9.2282 ms/op 8.4577 ms/op 1.09
computeEpochShuffling - vc 250000 105.23 ms/op 101.50 ms/op 1.04
getNextSyncCommittee - vc 250000 152.72 ms/op 140.68 ms/op 1.09
computeSigningRoot for AttestationData 13.698 us/op 12.793 us/op 1.07
hash AttestationData serialized data then Buffer.toString(base64) 2.3354 us/op 2.3185 us/op 1.01
toHexString serialized data 1.0748 us/op 1.0698 us/op 1.00
Buffer.toString(base64) 212.23 ns/op 215.96 ns/op 0.98

by benchmarkbot/action

@twoeths twoeths marked this pull request as ready for review July 31, 2023 02:45
@twoeths twoeths requested a review from a team as a code owner July 31, 2023 02:45
@twoeths twoeths mentioned this pull request Jul 31, 2023
Merged
@twoeths twoeths merged commit 487aef9 into unstable Jul 31, 2023
11 checks passed
@twoeths twoeths deleted the tuyen/slotsToSubscribeBeforeAggregatorDuty_cli_flag branch July 31, 2023 07:18
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twoeths @wemeetagain @dapplion