chore: add peer discovery metrics to grafana #5827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoeths
commented
Aug 1, 2023
| }, | ||
| "editorMode": "code", | ||
| "exemplar": false, | ||
| "expr": "(\n sum(rate(\n lodestar_network_worker_wire_events_on_worker_thread_latency_sum[$rate_interval]\n )) \n +\n sum(rate(\n lodestar_network_worker_wire_events_on_main_thread_latency_sum[$rate_interval]\n ))\n)\n/\n(\n sum(rate(\n lodestar_network_worker_wire_events_on_worker_thread_latency_count[$rate_interval]\n ))\n +\n sum(rate(\n lodestar_network_worker_wire_events_on_main_thread_latency_count[$rate_interval]\n ))\n)", |
There was a problem hiding this comment.
@matthewkeil I found this metric from #5800, do you want it to be part of this PR too?
There was a problem hiding this comment.
I leave that up to you @tuyennhv. I changed them around a few times so they may be a bit different from the last time you checked. Feel free to either pull the updated ones into this PR or I can merge the additions from yours into mine. Whichever works for me. I leave the decision with you. @wemeetagain mentioned this to me as well so just let me know how to help because I think he wants to get these into 1.10
Here is a screenshot of the updated version I made. I would go with your overall average because my calculation seems incorrect, but I kinda prefer the layout I settled on with one panel broken out by eventName and the other panel with just the three averages on it. Average, average of workerToMain and mainToWorker because they seem to be pretty different in the two directions and the individual metrics are also quite distinct in value for each event type so there will be a lot of opportunity to tune the individual events but they are hard to glance at to see if the averages is changing.
There was a problem hiding this comment.
ok then let's also add your panels to grafana, you can change them later @matthewkeil
Performance Report✔️ no performance regression detected Full benchmark results
|
|
this also include new panels from @matthewkeil , ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To know more about
PeerDiscoverystatusDescription