Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add produced aggregate metrics to dashboard #5828

Merged
merged 2 commits into from
Aug 1, 2023
Merged

chore: add produced aggregate metrics to dashboard #5828

merged 2 commits into from
Aug 1, 2023

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Aug 1, 2023

Motivation

We want to know quality of our produced aggregates

Description

  • Add "Produced Aggregate" row to "Block Production" dashboard
  • Add average and histogram metrics when we produce aggregates
Screenshot 2023-08-01 at 14 49 02

@twoeths twoeths requested a review from a team as a code owner August 1, 2023 07:49
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: ce85aa4 Previous: 67b6e79 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 554.87 us/op 572.84 us/op 0.97
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 95.339 us/op 79.848 us/op 1.19
BLS verify - blst-native 1.2720 ms/op 1.2480 ms/op 1.02
BLS verifyMultipleSignatures 3 - blst-native 2.6244 ms/op 2.5381 ms/op 1.03
BLS verifyMultipleSignatures 8 - blst-native 5.6325 ms/op 5.4505 ms/op 1.03
BLS verifyMultipleSignatures 32 - blst-native 20.751 ms/op 19.720 ms/op 1.05
BLS aggregatePubkeys 32 - blst-native 27.090 us/op 26.179 us/op 1.03
BLS aggregatePubkeys 128 - blst-native 105.85 us/op 102.40 us/op 1.03
getAttestationsForBlock 65.442 ms/op 59.183 ms/op 1.11
isKnown best case - 1 super set check 488.00 ns/op 315.00 ns/op 1.55
isKnown normal case - 2 super set checks 453.00 ns/op 305.00 ns/op 1.49
isKnown worse case - 16 super set checks 461.00 ns/op 330.00 ns/op 1.40
CheckpointStateCache - add get delete 6.2730 us/op 5.2820 us/op 1.19
validate api signedAggregateAndProof - struct 3.0039 ms/op 2.7952 ms/op 1.07
validate gossip signedAggregateAndProof - struct 3.0080 ms/op 2.7849 ms/op 1.08
validate api attestation - struct 1.4819 ms/op 1.3349 ms/op 1.11
validate gossip attestation - struct 1.6306 ms/op 1.3537 ms/op 1.20
pickEth1Vote - no votes 1.4313 ms/op 1.2999 ms/op 1.10
pickEth1Vote - max votes 11.579 ms/op 10.321 ms/op 1.12
pickEth1Vote - Eth1Data hashTreeRoot value x2048 10.139 ms/op 9.2862 ms/op 1.09
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.079 ms/op 17.013 ms/op 1.30
pickEth1Vote - Eth1Data fastSerialize value x2048 809.95 us/op 711.32 us/op 1.14
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.3587 ms/op 6.0092 ms/op 1.06
bytes32 toHexString 872.00 ns/op 669.00 ns/op 1.30
bytes32 Buffer.toString(hex) 339.00 ns/op 322.00 ns/op 1.05
bytes32 Buffer.toString(hex) from Uint8Array 627.00 ns/op 561.00 ns/op 1.12
bytes32 Buffer.toString(hex) + 0x 352.00 ns/op 339.00 ns/op 1.04
Object access 1 prop 0.24100 ns/op 0.21200 ns/op 1.14
Map access 1 prop 0.17100 ns/op 0.16200 ns/op 1.06
Object get x1000 10.833 ns/op 7.4530 ns/op 1.45
Map get x1000 0.73000 ns/op 0.61000 ns/op 1.20
Object set x1000 81.816 ns/op 54.681 ns/op 1.50
Map set x1000 52.060 ns/op 49.899 ns/op 1.04
Return object 10000 times 0.28910 ns/op 0.25890 ns/op 1.12
Throw Error 10000 times 4.1360 us/op 4.0102 us/op 1.03
fastMsgIdFn sha256 / 200 bytes 3.6090 us/op 3.3980 us/op 1.06
fastMsgIdFn h32 xxhash / 200 bytes 390.00 ns/op 303.00 ns/op 1.29
fastMsgIdFn h64 xxhash / 200 bytes 446.00 ns/op 363.00 ns/op 1.23
fastMsgIdFn sha256 / 1000 bytes 12.720 us/op 11.810 us/op 1.08
fastMsgIdFn h32 xxhash / 1000 bytes 532.00 ns/op 474.00 ns/op 1.12
fastMsgIdFn h64 xxhash / 1000 bytes 524.00 ns/op 460.00 ns/op 1.14
fastMsgIdFn sha256 / 10000 bytes 109.41 us/op 104.65 us/op 1.05
fastMsgIdFn h32 xxhash / 10000 bytes 2.1280 us/op 2.0240 us/op 1.05
fastMsgIdFn h64 xxhash / 10000 bytes 1.4700 us/op 1.3590 us/op 1.08
enrSubnets - fastDeserialize 64 bits 1.7580 us/op 1.3220 us/op 1.33
enrSubnets - ssz BitVector 64 bits 603.00 ns/op 553.00 ns/op 1.09
enrSubnets - fastDeserialize 4 bits 261.00 ns/op 205.00 ns/op 1.27
enrSubnets - ssz BitVector 4 bits 654.00 ns/op 507.00 ns/op 1.29
prioritizePeers score -10:0 att 32-0.1 sync 2-0 161.10 us/op 119.95 us/op 1.34
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 200.74 us/op 153.19 us/op 1.31
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 197.03 us/op 209.30 us/op 0.94
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 432.85 us/op 354.21 us/op 1.22
prioritizePeers score 0:0 att 64-1 sync 4-1 571.40 us/op 382.75 us/op 1.49
array of 16000 items push then shift 2.3483 us/op 1.6202 us/op 1.45
LinkedList of 16000 items push then shift 14.575 ns/op 9.3000 ns/op 1.57
array of 16000 items push then pop 114.40 ns/op 60.985 ns/op 1.88
LinkedList of 16000 items push then pop 16.089 ns/op 9.0530 ns/op 1.78
array of 24000 items push then shift 3.0757 us/op 2.4558 us/op 1.25
LinkedList of 24000 items push then shift 18.312 ns/op 9.5180 ns/op 1.92
array of 24000 items push then pop 295.48 ns/op 121.46 ns/op 2.43
LinkedList of 24000 items push then pop 13.838 ns/op 8.9670 ns/op 1.54
intersect bitArray bitLen 8 8.6640 ns/op 6.8880 ns/op 1.26
intersect array and set length 8 96.654 ns/op 64.257 ns/op 1.50
intersect bitArray bitLen 128 42.106 ns/op 31.717 ns/op 1.33
intersect array and set length 128 992.58 ns/op 823.26 ns/op 1.21
bitArray.getTrueBitIndexes() bitLen 128 1.8840 us/op 1.4790 us/op 1.27
bitArray.getTrueBitIndexes() bitLen 248 3.7590 us/op 2.6850 us/op 1.40
bitArray.getTrueBitIndexes() bitLen 512 7.3160 us/op 5.2780 us/op 1.39
Buffer.concat 32 items 1.2880 us/op 978.00 ns/op 1.32
Uint8Array.set 32 items 3.2460 us/op 1.7800 us/op 1.82
transfer serialized Status (84 B) 2.6320 us/op 1.8350 us/op 1.43
copy serialized Status (84 B) 2.3270 us/op 1.5600 us/op 1.49
transfer serialized SignedVoluntaryExit (112 B) 3.2430 us/op 1.9440 us/op 1.67
copy serialized SignedVoluntaryExit (112 B) 2.9010 us/op 1.7520 us/op 1.66
transfer serialized ProposerSlashing (416 B) 4.6980 us/op 3.3750 us/op 1.39
copy serialized ProposerSlashing (416 B) 3.8540 us/op 3.3250 us/op 1.16
transfer serialized Attestation (485 B) 3.8340 us/op 3.5160 us/op 1.09
copy serialized Attestation (485 B) 4.2120 us/op 3.3320 us/op 1.26
transfer serialized AttesterSlashing (33232 B) 3.8400 us/op 3.0420 us/op 1.26
copy serialized AttesterSlashing (33232 B) 13.595 us/op 7.1420 us/op 1.90
transfer serialized Small SignedBeaconBlock (128000 B) 5.8550 us/op 3.0190 us/op 1.94
copy serialized Small SignedBeaconBlock (128000 B) 44.708 us/op 19.543 us/op 2.29
transfer serialized Avg SignedBeaconBlock (200000 B) 5.2100 us/op 3.3400 us/op 1.56
copy serialized Avg SignedBeaconBlock (200000 B) 62.630 us/op 31.215 us/op 2.01
transfer serialized BlobsSidecar (524380 B) 6.1960 us/op 3.3420 us/op 1.85
copy serialized BlobsSidecar (524380 B) 211.02 us/op 98.255 us/op 2.15
transfer serialized Big SignedBeaconBlock (1000000 B) 7.3160 us/op 3.4050 us/op 2.15
copy serialized Big SignedBeaconBlock (1000000 B) 346.76 us/op 258.04 us/op 1.34
pass gossip attestations to forkchoice per slot 3.6649 ms/op 2.1712 ms/op 1.69
forkChoice updateHead vc 100000 bc 64 eq 0 3.5571 ms/op 2.2766 ms/op 1.56
forkChoice updateHead vc 600000 bc 64 eq 0 16.000 ms/op 11.432 ms/op 1.40
forkChoice updateHead vc 1000000 bc 64 eq 0 23.770 ms/op 18.678 ms/op 1.27
forkChoice updateHead vc 600000 bc 320 eq 0 20.091 ms/op 16.195 ms/op 1.24
forkChoice updateHead vc 600000 bc 1200 eq 0 113.40 ms/op 87.587 ms/op 1.29
forkChoice updateHead vc 600000 bc 64 eq 1000 26.036 ms/op 21.934 ms/op 1.19
forkChoice updateHead vc 600000 bc 64 eq 10000 28.460 ms/op 24.954 ms/op 1.14
forkChoice updateHead vc 600000 bc 64 eq 300000 88.244 ms/op 31.782 ms/op 2.78
computeDeltas 4.4189 ms/op 3.3544 ms/op 1.32
computeProposerBoostScoreFromBalances 487.09 us/op 391.10 us/op 1.25
altair processAttestation - 250000 vs - 7PWei normalcase 3.7893 ms/op 2.5330 ms/op 1.50
altair processAttestation - 250000 vs - 7PWei worstcase 5.5210 ms/op 3.7114 ms/op 1.49
altair processAttestation - setStatus - 1/6 committees join 225.00 us/op 145.07 us/op 1.55
altair processAttestation - setStatus - 1/3 committees join 402.43 us/op 298.95 us/op 1.35
altair processAttestation - setStatus - 1/2 committees join 597.21 us/op 394.95 us/op 1.51
altair processAttestation - setStatus - 2/3 committees join 701.26 us/op 494.66 us/op 1.42
altair processAttestation - setStatus - 4/5 committees join 1.2340 ms/op 681.84 us/op 1.81
altair processAttestation - setStatus - 100% committees join 1.1093 ms/op 829.27 us/op 1.34
altair processBlock - 250000 vs - 7PWei normalcase 12.514 ms/op 9.7194 ms/op 1.29
altair processBlock - 250000 vs - 7PWei normalcase hashState 21.086 ms/op 18.861 ms/op 1.12
altair processBlock - 250000 vs - 7PWei worstcase 49.026 ms/op 42.458 ms/op 1.15
altair processBlock - 250000 vs - 7PWei worstcase hashState 77.040 ms/op 64.981 ms/op 1.19
phase0 processBlock - 250000 vs - 7PWei normalcase 3.9612 ms/op 3.0569 ms/op 1.30
phase0 processBlock - 250000 vs - 7PWei worstcase 44.006 ms/op 35.063 ms/op 1.26
altair processEth1Data - 250000 vs - 7PWei normalcase 920.87 us/op 681.06 us/op 1.35
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 13.964 us/op 11.990 us/op 1.16
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 82.504 us/op 74.741 us/op 1.10
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 28.564 us/op 18.713 us/op 1.53
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 24.922 us/op 9.8050 us/op 2.54
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 309.93 us/op 177.81 us/op 1.74
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 2.1891 ms/op 1.3836 ms/op 1.58
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.7192 ms/op 1.7713 ms/op 1.54
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.1865 ms/op 1.9640 ms/op 1.11
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 5.1565 ms/op 3.7170 ms/op 1.39
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 3.8963 ms/op 3.3019 ms/op 1.18
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 12.261 ms/op 5.4924 ms/op 2.23
Tree 40 250000 create 969.02 ms/op 332.42 ms/op 2.91
Tree 40 250000 get(125000) 239.93 ns/op 203.64 ns/op 1.18
Tree 40 250000 set(125000) 2.7618 us/op 964.10 ns/op 2.86
Tree 40 250000 toArray() 36.008 ms/op 19.665 ms/op 1.83
Tree 40 250000 iterate all - toArray() + loop 38.476 ms/op 19.049 ms/op 2.02
Tree 40 250000 iterate all - get(i) 93.880 ms/op 69.603 ms/op 1.35
MutableVector 250000 create 19.302 ms/op 14.723 ms/op 1.31
MutableVector 250000 get(125000) 7.6560 ns/op 6.8040 ns/op 1.13
MutableVector 250000 set(125000) 584.25 ns/op 250.20 ns/op 2.34
MutableVector 250000 toArray() 6.1901 ms/op 3.4497 ms/op 1.79
MutableVector 250000 iterate all - toArray() + loop 6.2247 ms/op 3.4838 ms/op 1.79
MutableVector 250000 iterate all - get(i) 1.9087 ms/op 1.5449 ms/op 1.24
Array 250000 create 5.7303 ms/op 3.0199 ms/op 1.90
Array 250000 clone - spread 1.4928 ms/op 1.0725 ms/op 1.39
Array 250000 get(125000) 0.69900 ns/op 0.53600 ns/op 1.30
Array 250000 set(125000) 1.6390 ns/op 0.60800 ns/op 2.70
Array 250000 iterate all - loop 103.05 us/op 84.146 us/op 1.22
effectiveBalanceIncrements clone Uint8Array 300000 82.178 us/op 37.393 us/op 2.20
effectiveBalanceIncrements clone MutableVector 300000 337.00 ns/op 297.00 ns/op 1.13
effectiveBalanceIncrements rw all Uint8Array 300000 209.45 us/op 181.50 us/op 1.15
effectiveBalanceIncrements rw all MutableVector 300000 145.77 ms/op 83.778 ms/op 1.74
phase0 afterProcessEpoch - 250000 vs - 7PWei 138.80 ms/op 117.53 ms/op 1.18
phase0 beforeProcessEpoch - 250000 vs - 7PWei 65.958 ms/op 42.546 ms/op 1.55
altair processEpoch - mainnet_e81889 446.84 ms/op 339.95 ms/op 1.31
mainnet_e81889 - altair beforeProcessEpoch 87.784 ms/op 53.883 ms/op 1.63
mainnet_e81889 - altair processJustificationAndFinalization 26.889 us/op 18.428 us/op 1.46
mainnet_e81889 - altair processInactivityUpdates 6.4530 ms/op 5.3392 ms/op 1.21
mainnet_e81889 - altair processRewardsAndPenalties 87.303 ms/op 86.391 ms/op 1.01
mainnet_e81889 - altair processRegistryUpdates 8.7980 us/op 3.7700 us/op 2.33
mainnet_e81889 - altair processSlashings 1.6800 us/op 838.00 ns/op 2.00
mainnet_e81889 - altair processEth1DataReset 1.9930 us/op 537.00 ns/op 3.71
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.4619 ms/op 2.3654 ms/op 1.04
mainnet_e81889 - altair processSlashingsReset 6.4250 us/op 4.6500 us/op 1.38
mainnet_e81889 - altair processRandaoMixesReset 11.784 us/op 7.4090 us/op 1.59
mainnet_e81889 - altair processHistoricalRootsUpdate 2.3920 us/op 604.00 ns/op 3.96
mainnet_e81889 - altair processParticipationFlagUpdates 6.8790 us/op 1.7190 us/op 4.00
mainnet_e81889 - altair processSyncCommitteeUpdates 2.2080 us/op 688.00 ns/op 3.21
mainnet_e81889 - altair afterProcessEpoch 166.63 ms/op 124.04 ms/op 1.34
capella processEpoch - mainnet_e217614 1.5662 s/op 1.0617 s/op 1.48
mainnet_e217614 - capella beforeProcessEpoch 324.73 ms/op 233.17 ms/op 1.39
mainnet_e217614 - capella processJustificationAndFinalization 21.144 us/op 15.765 us/op 1.34
mainnet_e217614 - capella processInactivityUpdates 25.146 ms/op 18.589 ms/op 1.35
mainnet_e217614 - capella processRewardsAndPenalties 388.32 ms/op 307.96 ms/op 1.26
mainnet_e217614 - capella processRegistryUpdates 33.511 us/op 24.121 us/op 1.39
mainnet_e217614 - capella processSlashings 1.0750 us/op 719.00 ns/op 1.50
mainnet_e217614 - capella processEth1DataReset 686.00 ns/op 756.00 ns/op 0.91
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.4339 ms/op 4.1647 ms/op 1.06
mainnet_e217614 - capella processSlashingsReset 3.9320 us/op 3.5150 us/op 1.12
mainnet_e217614 - capella processRandaoMixesReset 7.9270 us/op 4.7920 us/op 1.65
mainnet_e217614 - capella processHistoricalRootsUpdate 1.0260 us/op 883.00 ns/op 1.16
mainnet_e217614 - capella processParticipationFlagUpdates 5.1240 us/op 2.3270 us/op 2.20
mainnet_e217614 - capella afterProcessEpoch 384.94 ms/op 311.78 ms/op 1.23
phase0 processEpoch - mainnet_e58758 381.92 ms/op 375.44 ms/op 1.02
mainnet_e58758 - phase0 beforeProcessEpoch 173.82 ms/op 122.19 ms/op 1.42
mainnet_e58758 - phase0 processJustificationAndFinalization 18.718 us/op 17.672 us/op 1.06
mainnet_e58758 - phase0 processRewardsAndPenalties 49.716 ms/op 63.833 ms/op 0.78
mainnet_e58758 - phase0 processRegistryUpdates 12.492 us/op 8.7460 us/op 1.43
mainnet_e58758 - phase0 processSlashings 605.00 ns/op 537.00 ns/op 1.13
mainnet_e58758 - phase0 processEth1DataReset 572.00 ns/op 716.00 ns/op 0.80
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.2833 ms/op 1.2552 ms/op 1.02
mainnet_e58758 - phase0 processSlashingsReset 2.6190 us/op 2.2030 us/op 1.19
mainnet_e58758 - phase0 processRandaoMixesReset 8.4140 us/op 3.5200 us/op 2.39
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.1370 us/op 453.00 ns/op 2.51
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.5460 us/op 5.2860 us/op 0.86
mainnet_e58758 - phase0 afterProcessEpoch 112.70 ms/op 102.51 ms/op 1.10
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.5411 ms/op 1.3324 ms/op 1.16
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.0038 ms/op 2.5858 ms/op 0.77
altair processInactivityUpdates - 250000 normalcase 29.427 ms/op 23.910 ms/op 1.23
altair processInactivityUpdates - 250000 worstcase 33.453 ms/op 23.519 ms/op 1.42
phase0 processRegistryUpdates - 250000 normalcase 12.911 us/op 14.200 us/op 0.91
phase0 processRegistryUpdates - 250000 badcase_full_deposits 455.05 us/op 588.93 us/op 0.77
phase0 processRegistryUpdates - 250000 worstcase 0.5 141.20 ms/op 128.19 ms/op 1.10
altair processRewardsAndPenalties - 250000 normalcase 74.156 ms/op 67.415 ms/op 1.10
altair processRewardsAndPenalties - 250000 worstcase 77.605 ms/op 69.724 ms/op 1.11
phase0 getAttestationDeltas - 250000 normalcase 9.3216 ms/op 7.9235 ms/op 1.18
phase0 getAttestationDeltas - 250000 worstcase 8.5973 ms/op 7.8237 ms/op 1.10
phase0 processSlashings - 250000 worstcase 2.5391 ms/op 2.3355 ms/op 1.09
altair processSyncCommitteeUpdates - 250000 170.44 ms/op 150.66 ms/op 1.13
BeaconState.hashTreeRoot - No change 298.00 ns/op 260.00 ns/op 1.15
BeaconState.hashTreeRoot - 1 full validator 58.928 us/op 59.131 us/op 1.00
BeaconState.hashTreeRoot - 32 full validator 605.92 us/op 649.04 us/op 0.93
BeaconState.hashTreeRoot - 512 full validator 7.0259 ms/op 6.1401 ms/op 1.14
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 73.384 us/op 67.383 us/op 1.09
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.0485 ms/op 972.57 us/op 1.08
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 12.832 ms/op 12.760 ms/op 1.01
BeaconState.hashTreeRoot - 1 balances 55.484 us/op 53.131 us/op 1.04
BeaconState.hashTreeRoot - 32 balances 554.10 us/op 518.68 us/op 1.07
BeaconState.hashTreeRoot - 512 balances 5.0566 ms/op 4.6609 ms/op 1.08
BeaconState.hashTreeRoot - 250000 balances 75.702 ms/op 87.502 ms/op 0.87
aggregationBits - 2048 els - zipIndexesInBitList 18.219 us/op 16.406 us/op 1.11
regular array get 100000 times 39.709 us/op 32.855 us/op 1.21
wrappedArray get 100000 times 38.388 us/op 43.844 us/op 0.88
arrayWithProxy get 100000 times 15.149 ms/op 15.138 ms/op 1.00
ssz.Root.equals 250.00 ns/op 202.00 ns/op 1.24
byteArrayEquals 255.00 ns/op 209.00 ns/op 1.22
shuffle list - 16384 els 7.4591 ms/op 6.9276 ms/op 1.08
shuffle list - 250000 els 109.14 ms/op 102.00 ms/op 1.07
processSlot - 1 slots 9.0740 us/op 8.7900 us/op 1.03
processSlot - 32 slots 1.4725 ms/op 1.4139 ms/op 1.04
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 58.549 ms/op 51.692 ms/op 1.13
getCommitteeAssignments - req 1 vs - 250000 vc 2.6390 ms/op 2.6071 ms/op 1.01
getCommitteeAssignments - req 100 vs - 250000 vc 3.8878 ms/op 3.8601 ms/op 1.01
getCommitteeAssignments - req 1000 vs - 250000 vc 4.2680 ms/op 4.1449 ms/op 1.03
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.1200 ns/op 5.1000 ns/op 1.00
state getBlockRootAtSlot - 250000 vs - 7PWei 667.17 ns/op 714.03 ns/op 0.93
computeProposers - vc 250000 9.7470 ms/op 9.3963 ms/op 1.04
computeEpochShuffling - vc 250000 111.21 ms/op 107.68 ms/op 1.03
getNextSyncCommittee - vc 250000 159.66 ms/op 161.39 ms/op 0.99
computeSigningRoot for AttestationData 15.202 us/op 13.246 us/op 1.15
hash AttestationData serialized data then Buffer.toString(base64) 2.4456 us/op 2.3835 us/op 1.03
toHexString serialized data 1.1658 us/op 1.2092 us/op 0.96
Buffer.toString(base64) 256.93 ns/op 253.04 ns/op 1.02

by benchmarkbot/action

dapplion
dapplion previously approved these changes Aug 1, 2023
View reviewed changes
@nflaig
Copy link
Member

nflaig commented Aug 1, 2023

@tuyennhv I am curious, how did you update the dashboard / from where was it downloaded? The diff in the __inputs should not have been there if it was downloaded from our cloud instance, I am guessing depends on the grafana version.

There seems to be an issue with formatting of __inputs in the lint script, should be addressed by #5830.

@wemeetagain wemeetagain merged commit c3d1862 into unstable Aug 1, 2023
11 checks passed
@wemeetagain wemeetagain deleted the tuyen/add_produced_aggregate_metrics_to_grafana branch August 1, 2023 14:07
@twoeths
Copy link
Contributor Author

twoeths commented Aug 2, 2023

@tuyennhv I am curious, how did you update the dashboard / from where was it downloaded? The diff in the __inputs should not have been there if it was downloaded from our cloud instance, I am guessing depends on the grafana version.

I just do node scripts/download_dashboards.mjs, just saw you enforce the format of inputs so 👍 @nflaig

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

@dapplion dapplion dapplion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twoeths @nflaig @wemeetagain @dapplion