-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly persist states based on archive epoch frequency #5979
Merged
wemeetagain
merged 1 commit into
unstable
from
nflaig/fix-archive-state-epoch-frequency
Sep 22, 2023
Merged
fix: correctly persist states based on archive epoch frequency #5979
wemeetagain
merged 1 commit into
unstable
from
nflaig/fix-archive-state-epoch-frequency
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
force-pushed
the
nflaig/fix-archive-state-epoch-frequency
branch
from
September 21, 2023 21:03
d988974
to
b9eae24
Compare
nflaig
changed the title
fix: correctly persist states based on configured epoch frequency
fix: correctly persist states based on archive epoch frequency
Sep 21, 2023
wemeetagain
approved these changes
Sep 22, 2023
wemeetagain
approved these changes
Sep 22, 2023
🎉 This PR is included in v1.12.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5976
Description
Setting
--chain.archiveStateEpochFrequency 1
should persist a state every epoch and not prune any previously stored states. This allows to download finalized states (#5846) by providing the start slot of the epoch (epoch * SLOTS_PER_EPOCH
).