Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for utils #6109

Merged
merged 7 commits into from
Nov 23, 2023
Merged

test: add tests for utils #6109

merged 7 commits into from
Nov 23, 2023

Conversation

murrayee
Copy link
Contributor

Added test coverage for utils bytes.ts

toHex
fromHex
toHexString

Current coverage: 87.5%

@murrayee murrayee requested a review from a team as a code owner November 14, 2023 12:12
@CLAassistant
Copy link

CLAassistant commented Nov 14, 2023

CLA assistant check
All committers have signed the CLA.

@murrayee murrayee changed the title Added test for utils test: Added tests for utils Nov 14, 2023
@murrayee murrayee changed the title test: Added tests for utils test: add tests for utils Nov 14, 2023
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you write the tests in a TestCase[] pattern to reduce boilerplate and make it easier to audit?

See example

const testCases: TestCase[] = [

@murrayee
Copy link
Contributor Author

Thanks! Can you write the tests in a TestCase[] pattern to reduce boilerplate and make it easier to audit?

See example

const testCases: TestCase[] = [

Thanks! I've never written tests like this before, So perfect !!

dapplion
dapplion previously approved these changes Nov 22, 2023
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for the contribution

packages/utils/test/unit/bytes.test.ts Outdated Show resolved Hide resolved
packages/utils/test/unit/bytes.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the updates!

@nflaig nflaig enabled auto-merge (squash) November 23, 2023 10:08
@nflaig nflaig merged commit a8767da into ChainSafe:unstable Nov 23, 2023
14 of 15 checks passed
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.13.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants