Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update broken annotated spec link #6126

Merged
merged 1 commit into from
Nov 25, 2023
Merged

docs: update broken annotated spec link #6126

merged 1 commit into from
Nov 25, 2023

Conversation

jeluard
Copy link
Contributor

@jeluard jeluard commented Nov 23, 2023

Motivation

Fix broken link

Description

annotated-spec repository doesn't have any tag/branch anymore.
It might be worth updating the consensus-specs link to so that they both point to their respective master branches.

@jeluard jeluard requested a review from a team as a code owner November 23, 2023 12:43
@CLAassistant
Copy link

CLAassistant commented Nov 23, 2023

CLA assistant check
All committers have signed the CLA.

@jeluard jeluard changed the title Update broken link fix: Update broken link Nov 23, 2023
@jeluard jeluard changed the title fix: Update broken link fix: update broken link Nov 23, 2023
@nflaig nflaig changed the title fix: update broken link docs: update broken annotated spec link Nov 23, 2023
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nflaig
Copy link
Member

nflaig commented Nov 23, 2023

It might be worth updating the consensus-specs link to so that they both point to their respective master branches.

I don't think it good to point to master branch unless there are no tagged versions. We have a bunch of references to the consensus spec, e.g. in the README

[![Ethereum Consensus Spec v1.1.10](https://img.shields.io/badge/ETH%20consensus--spec-1.1.10-blue)](https://github.com/ethereum/consensus-specs/releases/tag/v1.1.10)

All those references are kinda outdated as we already test against v1.4.0 (which has no major release yet) but could at least update to v1.3.0

specVersion: "v1.4.0-beta.2-hotfix",

@nflaig nflaig merged commit 8afbc98 into ChainSafe:unstable Nov 25, 2023
16 of 18 checks passed
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.13.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants