feat: support remote signer in voluntary exit command #6132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nflaig
reviewed
Nov 27, 2023
nflaig
reviewed
Nov 27, 2023
nflaig
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Thanks @eth2353 for the updates. The refactoring looks great, I pushed a few changes to clean up some minor things (hope you don't mind).
Generally, looks good to me. Let's mark this as ready for review to get feedback from the team
nflaig
reviewed
Nov 30, 2023
Co-authored-by: Nico Flaig <[email protected]>
|
I don't mind at all, I am not that experienced within the TypeScript ecosystem so I expected to have done a few things suboptimally. When I made this change initially, I actually wanted to skip writing a test for this since the actual changes in the code are so minimal (and trivial) 😄 But in the end I'm glad I didn't skip it, I think the refactored external signer test-util came out nice indeed! |
nflaig
previously approved these changes
Nov 30, 2023
nflaig
previously approved these changes
Nov 30, 2023
dapplion
previously approved these changes
Dec 1, 2023
nflaig
approved these changes
Dec 1, 2023
|
🎉 This PR is included in v1.13.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The desire to submit voluntary exit messages for validators loaded not directly in the Lodestar VC, but loaded in a remote signer.
Description
Voluntary exits were only possible for validators imported locally. It was not possible to sign or submit voluntary exit messages for validators loaded in a remote signer.
This PR makes it possible to exit validators loaded in a remote signer.
The command to run looks like this, it supports all the flags for local signers (e.g. --pubkeys) as well:
validator voluntary-exit --network=goerli --externalSigner.url=http://signer:9000 --externalSigner.fetch=true --beaconNodes=http://beacon:9596This was much easier to implement than I'd expected, speaks to the quality of your codebase!
Testing
Added an e2e test for this.
I have also manually tested running the command on Goerli and mainnet successfully.
I had to create a keystore for the interop validator secret keys. I used the Holesky genesis fork version & validators root because I couldn't locate the values to use. I don't think that should cause any issues but I can update that if needed if you point me to the values to use.
This is a draft PR, even though it's ready for review, I wanted to ask you guys if you even want to support thos.