ci: update the core-dump pattern with a path suffix #6142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
changed the title
wemeetagain
previously approved these changes
Nov 29, 2023
nflaig
previously approved these changes
Nov 29, 2023
Performance Report✔️ no performance regression detected Full benchmark results
|
|
It appears that in github runner there is no On Linux this approach do created the core dump. Need to figure out what directory is accessible to write in the github runner. |
nazarhussain
dismissed stale reviews from matthewkeil, nflaig, and wemeetagain
via
68a3ef0
Update core dump path Update core dump path Update the core dump file path Update the core dump file path Remove node-modules from core dump Log node features to verify debug is enabled Revert "Add manual segfault" This reverts commit 3021866. Update the path for the core-dump Add comment for the naming convention Update the core dump path Trigger segfault to verify Update the core path command Update limit order to be in same task Run every command in one action Run every command in one action Run yarn with a given node binary Run the tests with sudo Run the tests with sudo Change the order of runs for quick feedback Change the order of runs for quick feedback Change the order of runs for quick feedback Copy node for the sudo user Update the node path Restructure node debug tasks Add exec permission to node debug Revert "Trigger segfault to verify" This reverts commit 68a3ef0.
nazarhussain
force-pushed
the
nh/segfault-test
branch
from
10ecacd
to
a0c6e01
Compare
nflaig
approved these changes
Nov 30, 2023
|
🎉 This PR is included in v1.13.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the tests more stable.
Description
Capture the coredump for the segfaults.
Steps to test or reproduce