Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consistently include code in block error metadata #6148

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Dec 1, 2023

Motivation

Follow up to #6146, noticed we are omitting error code in some block errors but those add more context to the error message itself without having to look into the stack trace which does not show up when filtering logs by slot in grafana.

Description

Consistently include code in block error metadata

By default would render type which always include code

default:
return type;

This aligns the implementation with what is currently done for AttestationError

case AttestationErrorCode.UNKNOWN_TARGET_ROOT:
return {code: type.code, root: toHexString(type.root)};

@nflaig nflaig requested a review from a team as a code owner December 1, 2023 09:38
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 8c24bb5 Previous: 3631ae2 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 725.71 us/op 774.25 us/op 0.94
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 51.584 us/op 93.451 us/op 0.55
BLS verify - blst-native 1.1029 ms/op 1.2749 ms/op 0.87
BLS verifyMultipleSignatures 3 - blst-native 2.3499 ms/op 2.7220 ms/op 0.86
BLS verifyMultipleSignatures 8 - blst-native 5.1867 ms/op 5.9262 ms/op 0.88
BLS verifyMultipleSignatures 32 - blst-native 19.052 ms/op 20.796 ms/op 0.92
BLS verifyMultipleSignatures 64 - blst-native 37.544 ms/op 41.921 ms/op 0.90
BLS verifyMultipleSignatures 128 - blst-native 74.523 ms/op 84.626 ms/op 0.88
BLS deserializing 10000 signatures 796.48 ms/op 875.51 ms/op 0.91
BLS deserializing 100000 signatures 7.6553 s/op 8.8728 s/op 0.86
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.0779 ms/op 1.3129 ms/op 0.82
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.1614 ms/op 1.4813 ms/op 0.78
BLS verifyMultipleSignatures - same message - 32 - blst-native 1.9773 ms/op 2.2662 ms/op 0.87
BLS verifyMultipleSignatures - same message - 64 - blst-native 2.7502 ms/op 3.9965 ms/op 0.69
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.8444 ms/op 5.5420 ms/op 1.05
BLS aggregatePubkeys 32 - blst-native 23.226 us/op 25.423 us/op 0.91
BLS aggregatePubkeys 128 - blst-native 87.220 us/op 98.436 us/op 0.89
getAttestationsForBlock 35.685 ms/op 47.432 ms/op 0.75
isKnown best case - 1 super set check 310.00 ns/op 433.00 ns/op 0.72
isKnown normal case - 2 super set checks 302.00 ns/op 437.00 ns/op 0.69
isKnown worse case - 16 super set checks 303.00 ns/op 377.00 ns/op 0.80
CheckpointStateCache - add get delete 3.6050 us/op 5.7580 us/op 0.63
validate api signedAggregateAndProof - struct 2.3368 ms/op 2.7612 ms/op 0.85
validate gossip signedAggregateAndProof - struct 2.2949 ms/op 2.7627 ms/op 0.83
validate gossip attestation - vc 640000 1.1170 ms/op 1.3259 ms/op 0.84
batch validate gossip attestation - vc 640000 - chunk 32 150.29 us/op 159.51 us/op 0.94
batch validate gossip attestation - vc 640000 - chunk 64 121.87 us/op 141.63 us/op 0.86
batch validate gossip attestation - vc 640000 - chunk 128 110.44 us/op 130.33 us/op 0.85
batch validate gossip attestation - vc 640000 - chunk 256 108.87 us/op 131.66 us/op 0.83
pickEth1Vote - no votes 859.78 us/op 1.3712 ms/op 0.63
pickEth1Vote - max votes 8.8342 ms/op 11.849 ms/op 0.75
pickEth1Vote - Eth1Data hashTreeRoot value x2048 15.681 ms/op 25.748 ms/op 0.61
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 27.211 ms/op 29.184 ms/op 0.93
pickEth1Vote - Eth1Data fastSerialize value x2048 425.26 us/op 601.94 us/op 0.71
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.9833 ms/op 4.1508 ms/op 1.68
bytes32 toHexString 455.00 ns/op 572.00 ns/op 0.80
bytes32 Buffer.toString(hex) 314.00 ns/op 288.00 ns/op 1.09
bytes32 Buffer.toString(hex) from Uint8Array 421.00 ns/op 435.00 ns/op 0.97
bytes32 Buffer.toString(hex) + 0x 310.00 ns/op 290.00 ns/op 1.07
Object access 1 prop 0.19300 ns/op 0.15500 ns/op 1.25
Map access 1 prop 0.18800 ns/op 0.14500 ns/op 1.30
Object get x1000 5.6610 ns/op 7.3600 ns/op 0.77
Map get x1000 0.74500 ns/op 0.75800 ns/op 0.98
Object set x1000 24.963 ns/op 52.661 ns/op 0.47
Map set x1000 17.308 ns/op 37.982 ns/op 0.46
Return object 10000 times 0.22760 ns/op 0.23090 ns/op 0.99
Throw Error 10000 times 2.8008 us/op 3.8508 us/op 0.73
fastMsgIdFn sha256 / 200 bytes 2.0300 us/op 3.3270 us/op 0.61
fastMsgIdFn h32 xxhash / 200 bytes 308.00 ns/op 312.00 ns/op 0.99
fastMsgIdFn h64 xxhash / 200 bytes 379.00 ns/op 412.00 ns/op 0.92
fastMsgIdFn sha256 / 1000 bytes 6.2890 us/op 11.662 us/op 0.54
fastMsgIdFn h32 xxhash / 1000 bytes 418.00 ns/op 470.00 ns/op 0.89
fastMsgIdFn h64 xxhash / 1000 bytes 414.00 ns/op 498.00 ns/op 0.83
fastMsgIdFn sha256 / 10000 bytes 53.842 us/op 103.13 us/op 0.52
fastMsgIdFn h32 xxhash / 10000 bytes 1.8810 us/op 2.0040 us/op 0.94
fastMsgIdFn h64 xxhash / 10000 bytes 1.2890 us/op 1.4010 us/op 0.92
send data - 1000 256B messages 11.689 ms/op 22.034 ms/op 0.53
send data - 1000 512B messages 15.084 ms/op 26.267 ms/op 0.57
send data - 1000 1024B messages 22.432 ms/op 40.801 ms/op 0.55
send data - 1000 1200B messages 18.004 ms/op 35.289 ms/op 0.51
send data - 1000 2048B messages 31.193 ms/op 39.826 ms/op 0.78
send data - 1000 4096B messages 31.666 ms/op 38.954 ms/op 0.81
send data - 1000 16384B messages 70.380 ms/op 106.53 ms/op 0.66
send data - 1000 65536B messages 320.65 ms/op 368.07 ms/op 0.87
enrSubnets - fastDeserialize 64 bits 1.0430 us/op 1.2470 us/op 0.84
enrSubnets - ssz BitVector 64 bits 462.00 ns/op 485.00 ns/op 0.95
enrSubnets - fastDeserialize 4 bits 214.00 ns/op 187.00 ns/op 1.14
enrSubnets - ssz BitVector 4 bits 440.00 ns/op 429.00 ns/op 1.03
prioritizePeers score -10:0 att 32-0.1 sync 2-0 71.269 us/op 105.12 us/op 0.68
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 81.553 us/op 137.59 us/op 0.59
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 102.81 us/op 184.49 us/op 0.56
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 190.32 us/op 294.30 us/op 0.65
prioritizePeers score 0:0 att 64-1 sync 4-1 241.83 us/op 336.64 us/op 0.72
array of 16000 items push then shift 1.3213 us/op 1.6888 us/op 0.78
LinkedList of 16000 items push then shift 5.9940 ns/op 9.1560 ns/op 0.65
array of 16000 items push then pop 51.466 ns/op 109.03 ns/op 0.47
LinkedList of 16000 items push then pop 5.5440 ns/op 9.0700 ns/op 0.61
array of 24000 items push then shift 1.8747 us/op 2.4261 us/op 0.77
LinkedList of 24000 items push then shift 7.0650 ns/op 9.5930 ns/op 0.74
array of 24000 items push then pop 101.31 ns/op 146.60 ns/op 0.69
LinkedList of 24000 items push then pop 5.8050 ns/op 8.7260 ns/op 0.67
intersect bitArray bitLen 8 4.9660 ns/op 6.4370 ns/op 0.77
intersect array and set length 8 46.959 ns/op 69.087 ns/op 0.68
intersect bitArray bitLen 128 27.427 ns/op 35.315 ns/op 0.78
intersect array and set length 128 683.65 ns/op 860.62 ns/op 0.79
bitArray.getTrueBitIndexes() bitLen 128 1.1860 us/op 1.7450 us/op 0.68
bitArray.getTrueBitIndexes() bitLen 248 1.9220 us/op 2.8090 us/op 0.68
bitArray.getTrueBitIndexes() bitLen 512 3.4850 us/op 5.4030 us/op 0.65
Buffer.concat 32 items 984.00 ns/op 960.00 ns/op 1.02
Uint8Array.set 32 items 2.0120 us/op 1.8070 us/op 1.11
Set add up to 64 items then delete first 1.7631 us/op 4.8044 us/op 0.37
OrderedSet add up to 64 items then delete first 2.6240 us/op 5.8032 us/op 0.45
Set add up to 64 items then delete last 1.9372 us/op 5.1112 us/op 0.38
OrderedSet add up to 64 items then delete last 3.5135 us/op 6.6010 us/op 0.53
Set add up to 64 items then delete middle 2.0890 us/op 4.6560 us/op 0.45
OrderedSet add up to 64 items then delete middle 4.1983 us/op 7.3340 us/op 0.57
Set add up to 128 items then delete first 3.7764 us/op 9.7983 us/op 0.39
OrderedSet add up to 128 items then delete first 5.7549 us/op 12.727 us/op 0.45
Set add up to 128 items then delete last 4.5755 us/op 9.9792 us/op 0.46
OrderedSet add up to 128 items then delete last 5.5790 us/op 12.861 us/op 0.43
Set add up to 128 items then delete middle 3.7869 us/op 9.4174 us/op 0.40
OrderedSet add up to 128 items then delete middle 10.425 us/op 17.247 us/op 0.60
Set add up to 256 items then delete first 7.7852 us/op 18.906 us/op 0.41
OrderedSet add up to 256 items then delete first 12.139 us/op 29.300 us/op 0.41
Set add up to 256 items then delete last 7.4590 us/op 21.753 us/op 0.34
OrderedSet add up to 256 items then delete last 11.707 us/op 26.910 us/op 0.44
Set add up to 256 items then delete middle 7.7075 us/op 19.801 us/op 0.39
OrderedSet add up to 256 items then delete middle 32.528 us/op 47.589 us/op 0.68
transfer serialized Status (84 B) 1.5250 us/op 1.9630 us/op 0.78
copy serialized Status (84 B) 1.4360 us/op 1.6510 us/op 0.87
transfer serialized SignedVoluntaryExit (112 B) 1.7770 us/op 2.0110 us/op 0.88
copy serialized SignedVoluntaryExit (112 B) 1.5950 us/op 1.6900 us/op 0.94
transfer serialized ProposerSlashing (416 B) 2.7980 us/op 2.7980 us/op 1.00
copy serialized ProposerSlashing (416 B) 3.0360 us/op 2.4290 us/op 1.25
transfer serialized Attestation (485 B) 2.8830 us/op 2.4620 us/op 1.17
copy serialized Attestation (485 B) 3.0730 us/op 2.0330 us/op 1.51
transfer serialized AttesterSlashing (33232 B) 2.8940 us/op 2.2390 us/op 1.29
copy serialized AttesterSlashing (33232 B) 7.0250 us/op 6.0420 us/op 1.16
transfer serialized Small SignedBeaconBlock (128000 B) 2.4690 us/op 2.5550 us/op 0.97
copy serialized Small SignedBeaconBlock (128000 B) 9.1970 us/op 16.135 us/op 0.57
transfer serialized Avg SignedBeaconBlock (200000 B) 2.5150 us/op 3.1030 us/op 0.81
copy serialized Avg SignedBeaconBlock (200000 B) 12.725 us/op 24.283 us/op 0.52
transfer serialized BlobsSidecar (524380 B) 2.6510 us/op 3.5320 us/op 0.75
copy serialized BlobsSidecar (524380 B) 134.44 us/op 238.04 us/op 0.56
transfer serialized Big SignedBeaconBlock (1000000 B) 2.6490 us/op 4.1150 us/op 0.64
copy serialized Big SignedBeaconBlock (1000000 B) 132.88 us/op 293.93 us/op 0.45
pass gossip attestations to forkchoice per slot 2.8045 ms/op 4.3176 ms/op 0.65
forkChoice updateHead vc 100000 bc 64 eq 0 437.75 us/op 749.08 us/op 0.58
forkChoice updateHead vc 600000 bc 64 eq 0 2.6216 ms/op 4.9231 ms/op 0.53
forkChoice updateHead vc 1000000 bc 64 eq 0 4.4036 ms/op 7.6146 ms/op 0.58
forkChoice updateHead vc 600000 bc 320 eq 0 2.6187 ms/op 4.4104 ms/op 0.59
forkChoice updateHead vc 600000 bc 1200 eq 0 2.7616 ms/op 4.6330 ms/op 0.60
forkChoice updateHead vc 600000 bc 7200 eq 0 3.5122 ms/op 5.4019 ms/op 0.65
forkChoice updateHead vc 600000 bc 64 eq 1000 10.255 ms/op 11.485 ms/op 0.89
forkChoice updateHead vc 600000 bc 64 eq 10000 9.9588 ms/op 12.370 ms/op 0.81
forkChoice updateHead vc 600000 bc 64 eq 300000 11.980 ms/op 18.593 ms/op 0.64
computeDeltas 500000 validators 300 proto nodes 3.2747 ms/op 6.6325 ms/op 0.49
computeDeltas 500000 validators 1200 proto nodes 3.1644 ms/op 6.5173 ms/op 0.49
computeDeltas 500000 validators 7200 proto nodes 3.2291 ms/op 6.5018 ms/op 0.50
computeDeltas 750000 validators 300 proto nodes 4.8998 ms/op 10.047 ms/op 0.49
computeDeltas 750000 validators 1200 proto nodes 4.9540 ms/op 9.7207 ms/op 0.51
computeDeltas 750000 validators 7200 proto nodes 5.0297 ms/op 9.7800 ms/op 0.51
computeDeltas 1400000 validators 300 proto nodes 9.8977 ms/op 18.636 ms/op 0.53
computeDeltas 1400000 validators 1200 proto nodes 9.6986 ms/op 19.033 ms/op 0.51
computeDeltas 1400000 validators 7200 proto nodes 10.337 ms/op 18.881 ms/op 0.55
computeDeltas 2100000 validators 300 proto nodes 15.134 ms/op 27.867 ms/op 0.54
computeDeltas 2100000 validators 1200 proto nodes 14.790 ms/op 30.004 ms/op 0.49
computeDeltas 2100000 validators 7200 proto nodes 14.450 ms/op 30.791 ms/op 0.47
computeProposerBoostScoreFromBalances 500000 validators 3.3092 ms/op 4.0491 ms/op 0.82
computeProposerBoostScoreFromBalances 750000 validators 3.2214 ms/op 3.9043 ms/op 0.83
computeProposerBoostScoreFromBalances 1400000 validators 3.3396 ms/op 3.7790 ms/op 0.88
computeProposerBoostScoreFromBalances 2100000 validators 3.2381 ms/op 3.8035 ms/op 0.85
altair processAttestation - 250000 vs - 7PWei normalcase 2.2605 ms/op 2.6750 ms/op 0.85
altair processAttestation - 250000 vs - 7PWei worstcase 3.6428 ms/op 3.7421 ms/op 0.97
altair processAttestation - setStatus - 1/6 committees join 109.98 us/op 148.65 us/op 0.74
altair processAttestation - setStatus - 1/3 committees join 210.71 us/op 287.48 us/op 0.73
altair processAttestation - setStatus - 1/2 committees join 278.32 us/op 371.39 us/op 0.75
altair processAttestation - setStatus - 2/3 committees join 383.76 us/op 462.59 us/op 0.83
altair processAttestation - setStatus - 4/5 committees join 503.04 us/op 668.86 us/op 0.75
altair processAttestation - setStatus - 100% committees join 612.03 us/op 785.10 us/op 0.78
altair processBlock - 250000 vs - 7PWei normalcase 9.0476 ms/op 9.9171 ms/op 0.91
altair processBlock - 250000 vs - 7PWei normalcase hashState 31.293 ms/op 33.052 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase 33.386 ms/op 39.108 ms/op 0.85
altair processBlock - 250000 vs - 7PWei worstcase hashState 92.894 ms/op 90.079 ms/op 1.03
phase0 processBlock - 250000 vs - 7PWei normalcase 2.3533 ms/op 3.0887 ms/op 0.76
phase0 processBlock - 250000 vs - 7PWei worstcase 27.622 ms/op 33.606 ms/op 0.82
altair processEth1Data - 250000 vs - 7PWei normalcase 414.48 us/op 697.57 us/op 0.59
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 10.190 us/op 14.878 us/op 0.68
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 33.719 us/op 66.991 us/op 0.50
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 18.201 us/op 19.016 us/op 0.96
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 6.7860 us/op 13.274 us/op 0.51
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 138.45 us/op 207.27 us/op 0.67
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.5015 ms/op 1.2974 ms/op 1.16
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.0300 ms/op 1.6930 ms/op 0.61
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.4059 ms/op 1.6526 ms/op 0.85
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.3169 ms/op 4.0248 ms/op 0.58
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.2302 ms/op 3.0373 ms/op 0.73
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.7603 ms/op 6.3481 ms/op 0.59
Tree 40 250000 create 256.52 ms/op 401.72 ms/op 0.64
Tree 40 250000 get(125000) 116.69 ns/op 205.32 ns/op 0.57
Tree 40 250000 set(125000) 800.73 ns/op 1.0214 us/op 0.78
Tree 40 250000 toArray() 19.034 ms/op 21.591 ms/op 0.88
Tree 40 250000 iterate all - toArray() + loop 19.868 ms/op 20.411 ms/op 0.97
Tree 40 250000 iterate all - get(i) 48.284 ms/op 68.169 ms/op 0.71
MutableVector 250000 create 12.647 ms/op 14.863 ms/op 0.85
MutableVector 250000 get(125000) 5.6330 ns/op 6.5010 ns/op 0.87
MutableVector 250000 set(125000) 219.81 ns/op 270.72 ns/op 0.81
MutableVector 250000 toArray() 3.2654 ms/op 3.1707 ms/op 1.03
MutableVector 250000 iterate all - toArray() + loop 3.6292 ms/op 4.1340 ms/op 0.88
MutableVector 250000 iterate all - get(i) 1.3290 ms/op 1.5052 ms/op 0.88
Array 250000 create 2.7013 ms/op 3.4283 ms/op 0.79
Array 250000 clone - spread 1.0442 ms/op 1.3795 ms/op 0.76
Array 250000 get(125000) 0.99800 ns/op 1.0920 ns/op 0.91
Array 250000 set(125000) 1.1860 ns/op 4.2540 ns/op 0.28
Array 250000 iterate all - loop 151.89 us/op 164.20 us/op 0.93
effectiveBalanceIncrements clone Uint8Array 300000 23.887 us/op 36.006 us/op 0.66
effectiveBalanceIncrements clone MutableVector 300000 372.00 ns/op 389.00 ns/op 0.96
effectiveBalanceIncrements rw all Uint8Array 300000 180.52 us/op 193.11 us/op 0.93
effectiveBalanceIncrements rw all MutableVector 300000 64.749 ms/op 88.916 ms/op 0.73
phase0 afterProcessEpoch - 250000 vs - 7PWei 77.858 ms/op 113.86 ms/op 0.68
phase0 beforeProcessEpoch - 250000 vs - 7PWei 46.116 ms/op 53.349 ms/op 0.86
altair processEpoch - mainnet_e81889 415.01 ms/op 554.44 ms/op 0.75
mainnet_e81889 - altair beforeProcessEpoch 71.822 ms/op 88.268 ms/op 0.81
mainnet_e81889 - altair processJustificationAndFinalization 11.007 us/op 17.712 us/op 0.62
mainnet_e81889 - altair processInactivityUpdates 3.9357 ms/op 7.2070 ms/op 0.55
mainnet_e81889 - altair processRewardsAndPenalties 72.297 ms/op 71.617 ms/op 1.01
mainnet_e81889 - altair processRegistryUpdates 1.8820 us/op 2.6550 us/op 0.71
mainnet_e81889 - altair processSlashings 643.00 ns/op 507.00 ns/op 1.27
mainnet_e81889 - altair processEth1DataReset 642.00 ns/op 787.00 ns/op 0.82
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.6897 ms/op 1.3713 ms/op 1.23
mainnet_e81889 - altair processSlashingsReset 2.2330 us/op 4.0540 us/op 0.55
mainnet_e81889 - altair processRandaoMixesReset 2.9570 us/op 5.0860 us/op 0.58
mainnet_e81889 - altair processHistoricalRootsUpdate 772.00 ns/op 863.00 ns/op 0.89
mainnet_e81889 - altair processParticipationFlagUpdates 1.8010 us/op 3.1800 us/op 0.57
mainnet_e81889 - altair processSyncCommitteeUpdates 768.00 ns/op 950.00 ns/op 0.81
mainnet_e81889 - altair afterProcessEpoch 96.235 ms/op 119.29 ms/op 0.81
capella processEpoch - mainnet_e217614 1.7849 s/op 2.3724 s/op 0.75
mainnet_e217614 - capella beforeProcessEpoch 450.74 ms/op 553.92 ms/op 0.81
mainnet_e217614 - capella processJustificationAndFinalization 23.062 us/op 19.550 us/op 1.18
mainnet_e217614 - capella processInactivityUpdates 28.251 ms/op 19.310 ms/op 1.46
mainnet_e217614 - capella processRewardsAndPenalties 559.49 ms/op 629.22 ms/op 0.89
mainnet_e217614 - capella processRegistryUpdates 16.925 us/op 27.046 us/op 0.63
mainnet_e217614 - capella processSlashings 792.00 ns/op 633.00 ns/op 1.25
mainnet_e217614 - capella processEth1DataReset 674.00 ns/op 469.00 ns/op 1.44
mainnet_e217614 - capella processEffectiveBalanceUpdates 3.3290 ms/op 16.297 ms/op 0.20
mainnet_e217614 - capella processSlashingsReset 2.7230 us/op 6.7030 us/op 0.41
mainnet_e217614 - capella processRandaoMixesReset 3.4150 us/op 7.1820 us/op 0.48
mainnet_e217614 - capella processHistoricalRootsUpdate 625.00 ns/op 1.6470 us/op 0.38
mainnet_e217614 - capella processParticipationFlagUpdates 1.4260 us/op 2.4300 us/op 0.59
mainnet_e217614 - capella afterProcessEpoch 217.74 ms/op 324.32 ms/op 0.67
phase0 processEpoch - mainnet_e58758 403.60 ms/op 484.30 ms/op 0.83
mainnet_e58758 - phase0 beforeProcessEpoch 124.99 ms/op 145.66 ms/op 0.86
mainnet_e58758 - phase0 processJustificationAndFinalization 12.729 us/op 16.655 us/op 0.76
mainnet_e58758 - phase0 processRewardsAndPenalties 60.273 ms/op 46.860 ms/op 1.29
mainnet_e58758 - phase0 processRegistryUpdates 8.5570 us/op 11.753 us/op 0.73
mainnet_e58758 - phase0 processSlashings 648.00 ns/op 586.00 ns/op 1.11
mainnet_e58758 - phase0 processEth1DataReset 581.00 ns/op 693.00 ns/op 0.84
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 973.50 us/op 1.1388 ms/op 0.85
mainnet_e58758 - phase0 processSlashingsReset 1.9530 us/op 3.4740 us/op 0.56
mainnet_e58758 - phase0 processRandaoMixesReset 4.7930 us/op 4.9470 us/op 0.97
mainnet_e58758 - phase0 processHistoricalRootsUpdate 716.00 ns/op 635.00 ns/op 1.13
mainnet_e58758 - phase0 processParticipationRecordUpdates 2.8040 us/op 4.5420 us/op 0.62
mainnet_e58758 - phase0 afterProcessEpoch 65.906 ms/op 99.674 ms/op 0.66
phase0 processEffectiveBalanceUpdates - 250000 normalcase 999.41 us/op 1.3609 ms/op 0.73
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.1418 ms/op 1.5100 ms/op 0.76
altair processInactivityUpdates - 250000 normalcase 16.795 ms/op 25.824 ms/op 0.65
altair processInactivityUpdates - 250000 worstcase 16.386 ms/op 26.783 ms/op 0.61
phase0 processRegistryUpdates - 250000 normalcase 6.9960 us/op 10.186 us/op 0.69
phase0 processRegistryUpdates - 250000 badcase_full_deposits 325.25 us/op 390.84 us/op 0.83
phase0 processRegistryUpdates - 250000 worstcase 0.5 109.31 ms/op 145.43 ms/op 0.75
altair processRewardsAndPenalties - 250000 normalcase 68.186 ms/op 76.108 ms/op 0.90
altair processRewardsAndPenalties - 250000 worstcase 60.031 ms/op 75.168 ms/op 0.80
phase0 getAttestationDeltas - 250000 normalcase 5.4629 ms/op 10.178 ms/op 0.54
phase0 getAttestationDeltas - 250000 worstcase 5.4713 ms/op 10.273 ms/op 0.53
phase0 processSlashings - 250000 worstcase 1.3851 ms/op 2.3352 ms/op 0.59
altair processSyncCommitteeUpdates - 250000 102.62 ms/op 166.10 ms/op 0.62
BeaconState.hashTreeRoot - No change 328.00 ns/op 262.00 ns/op 1.25
BeaconState.hashTreeRoot - 1 full validator 122.71 us/op 167.29 us/op 0.73
BeaconState.hashTreeRoot - 32 full validator 1.1992 ms/op 1.7793 ms/op 0.67
BeaconState.hashTreeRoot - 512 full validator 9.6793 ms/op 20.792 ms/op 0.47
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 107.74 us/op 216.26 us/op 0.50
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.2229 ms/op 2.8346 ms/op 0.78
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 32.304 ms/op 36.075 ms/op 0.90
BeaconState.hashTreeRoot - 1 balances 134.98 us/op 172.32 us/op 0.78
BeaconState.hashTreeRoot - 32 balances 869.53 us/op 1.2994 ms/op 0.67
BeaconState.hashTreeRoot - 512 balances 7.6604 ms/op 13.067 ms/op 0.59
BeaconState.hashTreeRoot - 250000 balances 143.59 ms/op 222.64 ms/op 0.64
aggregationBits - 2048 els - zipIndexesInBitList 12.731 us/op 19.783 us/op 0.64
byteArrayEquals 32 60.455 ns/op 74.377 ns/op 0.81
Buffer.compare 32 35.722 ns/op 55.015 ns/op 0.65
byteArrayEquals 1024 1.6165 us/op 2.0326 us/op 0.80
Buffer.compare 1024 40.778 ns/op 71.542 ns/op 0.57
byteArrayEquals 16384 25.629 us/op 32.465 us/op 0.79
Buffer.compare 16384 195.90 ns/op 276.02 ns/op 0.71
byteArrayEquals 123687377 202.83 ms/op 249.38 ms/op 0.81
Buffer.compare 123687377 3.8295 ms/op 8.1175 ms/op 0.47
byteArrayEquals 32 - diff last byte 62.214 ns/op 72.222 ns/op 0.86
Buffer.compare 32 - diff last byte 40.064 ns/op 56.455 ns/op 0.71
byteArrayEquals 1024 - diff last byte 1.7308 us/op 2.0666 us/op 0.84
Buffer.compare 1024 - diff last byte 47.250 ns/op 72.703 ns/op 0.65
byteArrayEquals 16384 - diff last byte 25.850 us/op 33.005 us/op 0.78
Buffer.compare 16384 - diff last byte 213.61 ns/op 281.00 ns/op 0.76
byteArrayEquals 123687377 - diff last byte 205.90 ms/op 248.09 ms/op 0.83
Buffer.compare 123687377 - diff last byte 3.9265 ms/op 7.8612 ms/op 0.50
byteArrayEquals 32 - random bytes 4.4820 ns/op 5.8000 ns/op 0.77
Buffer.compare 32 - random bytes 39.801 ns/op 61.324 ns/op 0.65
byteArrayEquals 1024 - random bytes 4.4390 ns/op 5.9200 ns/op 0.75
Buffer.compare 1024 - random bytes 37.510 ns/op 61.327 ns/op 0.61
byteArrayEquals 16384 - random bytes 4.4330 ns/op 5.6880 ns/op 0.78
Buffer.compare 16384 - random bytes 37.475 ns/op 61.578 ns/op 0.61
byteArrayEquals 123687377 - random bytes 7.9100 ns/op 8.7000 ns/op 0.91
Buffer.compare 123687377 - random bytes 41.420 ns/op 65.790 ns/op 0.63
regular array get 100000 times 40.933 us/op 45.169 us/op 0.91
wrappedArray get 100000 times 40.879 us/op 45.529 us/op 0.90
arrayWithProxy get 100000 times 9.9737 ms/op 15.757 ms/op 0.63
ssz.Root.equals 54.197 ns/op 54.583 ns/op 0.99
byteArrayEquals 53.864 ns/op 53.816 ns/op 1.00
Buffer.compare 10.078 ns/op 11.531 ns/op 0.87
shuffle list - 16384 els 4.5533 ms/op 7.0435 ms/op 0.65
shuffle list - 250000 els 62.199 ms/op 103.03 ms/op 0.60
processSlot - 1 slots 14.146 us/op 17.966 us/op 0.79
processSlot - 32 slots 3.0914 ms/op 3.6728 ms/op 0.84
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 52.653 ms/op 58.533 ms/op 0.90
getCommitteeAssignments - req 1 vs - 250000 vc 2.2411 ms/op 2.5000 ms/op 0.90
getCommitteeAssignments - req 100 vs - 250000 vc 3.3934 ms/op 3.6836 ms/op 0.92
getCommitteeAssignments - req 1000 vs - 250000 vc 3.5898 ms/op 4.0737 ms/op 0.88
findModifiedValidators - 10000 modified validators 433.11 ms/op 507.06 ms/op 0.85
findModifiedValidators - 1000 modified validators 308.42 ms/op 446.15 ms/op 0.69
findModifiedValidators - 100 modified validators 262.12 ms/op 428.86 ms/op 0.61
findModifiedValidators - 10 modified validators 314.72 ms/op 408.71 ms/op 0.77
findModifiedValidators - 1 modified validators 309.40 ms/op 392.10 ms/op 0.79
findModifiedValidators - no difference 322.58 ms/op 398.40 ms/op 0.81
compare ViewDUs 3.9473 s/op 4.5912 s/op 0.86
compare each validator Uint8Array 1.2786 s/op 1.7539 s/op 0.73
compare ViewDU to Uint8Array 770.40 ms/op 1.1912 s/op 0.65
migrate state 1000000 validators, 24 modified, 0 new 724.88 ms/op 790.25 ms/op 0.92
migrate state 1000000 validators, 1700 modified, 1000 new 1.0142 s/op 1.1347 s/op 0.89
migrate state 1000000 validators, 3400 modified, 2000 new 1.1293 s/op 1.5503 s/op 0.73
migrate state 1500000 validators, 24 modified, 0 new 704.83 ms/op 941.70 ms/op 0.75
migrate state 1500000 validators, 1700 modified, 1000 new 964.08 ms/op 1.2093 s/op 0.80
migrate state 1500000 validators, 3400 modified, 2000 new 1.2340 s/op 1.5459 s/op 0.80
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.5100 ns/op 5.6400 ns/op 0.80
state getBlockRootAtSlot - 250000 vs - 7PWei 893.58 ns/op 838.64 ns/op 1.07
computeProposers - vc 250000 6.9946 ms/op 10.344 ms/op 0.68
computeEpochShuffling - vc 250000 70.168 ms/op 125.94 ms/op 0.56
getNextSyncCommittee - vc 250000 103.59 ms/op 183.90 ms/op 0.56
computeSigningRoot for AttestationData 25.004 us/op 34.074 us/op 0.73
hash AttestationData serialized data then Buffer.toString(base64) 1.2410 us/op 2.4537 us/op 0.51
toHexString serialized data 846.39 ns/op 1.4035 us/op 0.60
Buffer.toString(base64) 153.27 ns/op 268.62 ns/op 0.57

by benchmarkbot/action

@wemeetagain wemeetagain merged commit e6708f8 into unstable Dec 1, 2023
15 checks passed
@wemeetagain wemeetagain deleted the nflaig/code-in-block-errors branch December 1, 2023 19:01
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.13.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants