Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use self-hosted runner for sim tests #6282

Closed
wants to merge 1 commit into from

Conversation

wemeetagain
Copy link
Member

Motivation

sim tests are consistently flaky

Description

use newly provisioned self-hosted runner for sim tests

@wemeetagain wemeetagain requested a review from a team as a code owner January 10, 2024 20:05
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!! Should we put a note somewhere about where the self hosted runner is located so the user can go find the logs and what not? Not sure where the best place to put that is though...

@@ -24,7 +24,7 @@ env:
jobs:
sim-merge-tests:
name: Sim merge tests
runs-on: buildjet-4vcpu-ubuntu-2204
runs-on: Sim-Test-Github-runner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this in the runners tab. How does it wire through to point to Hetzner?

@dapplion
Copy link
Contributor

dapplion commented Jan 12, 2024

Note that external contributions won't run sim tests anymore, would be good to note that somewhere or make the host a dynamic

@nflaig
Copy link
Member

nflaig commented Jan 12, 2024

Before going ahead with this, should there be another attempt to make sim tests stable without changing runners? Based on my observation before #6163 they at least passed if the CI was not overloaded but now they fail basically all the time. If it is really just the unknown block sync node we might be able to fix it.

Where I think we definitely need a self-hosted runner is for the benchmarks, they take around 45 minutes at the moment and produce random false positives all the time.

@wemeetagain
Copy link
Member Author

@wemeetagain wemeetagain deleted the cayman/update-sim-test-runner branch August 26, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants