chore: install same vitest version across packages #6306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
commented
Jan 16, 2024
| @@ -112,7 +112,7 @@ export function describeDirectorySpecTest<TestCase extends {meta?: any}, Result> | |||
| continue; | |||
| } | |||
|
|
|||
| // Use full path here, not just `testSubDirname` to allow usage of `vitest --grep` | |||
| // Use full path here, not just `testSubDirname` to allow usage of `vitest -t` | |||
There was a problem hiding this comment.
completely unrelated change, picked that up while reviewing #6222 and since this is a fixup of that PR, might as well include that here
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6306 +/- ##
=========================================
Coverage 80.38% 80.38%
=========================================
Files 202 202
Lines 19620 19620
Branches 1176 1176
=========================================
Hits 15771 15771
Misses 3821 3821
Partials 28 28 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Jan 16, 2024
|
🎉 This PR is included in v1.15.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Noticed when running
yarn installlocally on unstable branch it produces a lock file diff. This is due to the fact that we install different vitest versions.I reviewed #6222 and seems to be the issue as the branch was open before we upgraded vitest in #6237.
There is a way to enforce that a branch is rebased / merged against target branch before the PR can be merged. While I don't think this is strictly necessary, we should keep in mind to rebase long lived branches before merging.
Description
Install same vitest version across packages