fix: update withdrawal request container to match consensus spec #6797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
commented
May 16, 2024
| @@ -419,7 +419,7 @@ export function serializeExecutionLayerWithdrawalRequest( | |||
| ): ExecutionLayerWithdrawalRequestRpc { | |||
| return { | |||
| sourceAddress: bytesToData(withdrawalRequest.sourceAddress), | |||
| validatorPublicKey: bytesToData(withdrawalRequest.validatorPublicKey), | |||
| validatorPublicKey: bytesToData(withdrawalRequest.validatorPubkey), | |||
There was a problem hiding this comment.
There is a inconsistency in the execution apis, right now all EL clients besides Besu use validatorPublicKey, this means pairing with Besu will not work right now if execution layer withdrawals requests are submitted to the network.
For now, we should just follow the spec
I opened a PR to potentially address this inconsistency
nflaig
force-pushed
the
nflaig/fix-withdrawal-request
branch
from
a7d26dc
to
9d1d263
Compare
wemeetagain
approved these changes
May 16, 2024
|
Confirmed this fixes issues with other clients, only remaining issue is block production with Besu but that needs to be either fixed on their end or the spec. |
g11tech
pushed a commit
that referenced
this pull request
May 24, 2024
g11tech
pushed a commit
to g11tech/lodestar
that referenced
this pull request
Jun 19, 2024
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
g11tech
pushed a commit
that referenced
this pull request
Jul 1, 2024
g11tech
pushed a commit
that referenced
this pull request
Jul 30, 2024
g11tech
pushed a commit
that referenced
this pull request
Jul 31, 2024
g11tech
pushed a commit
that referenced
this pull request
Aug 2, 2024
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
g11tech
pushed a commit
that referenced
this pull request
Aug 9, 2024
g11tech
pushed a commit
that referenced
this pull request
Aug 23, 2024
g11tech
pushed a commit
that referenced
this pull request
Aug 27, 2024
philknows
pushed a commit
that referenced
this pull request
Sep 3, 2024
|
🎉 This PR is included in v1.22.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Noticed we are no longer following the consensus spec since #6789, the ssz_static tests are failing and there are issues if execution layer withdrawals are submitted to the network.
Description
Update withdrawal request container to match consensus spec