Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: review debugging section PR #6807

Merged
merged 1 commit into from
May 22, 2024
Merged

chore: review debugging section PR #6807

merged 1 commit into from
May 22, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented May 22, 2024

Motivation

Pending review from my side on #6743 (which is merged already)

Description

Review debugging section PR

  • rephrased a few sentences
  • removed reference to non-existent launch.json file

@nflaig nflaig requested a review from a team as a code owner May 22, 2024 09:54
@codecov Codecov
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.20%. Comparing base (992fdd4) to head (5a6e71d).

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #6807      +/-   ##
============================================
- Coverage     62.20%   62.20%   -0.01%     
============================================
  Files           570      570              
  Lines         59987    59987              
  Branches       1975     1972       -3     
============================================
- Hits          37317    37316       -1     
- Misses        22627    22628       +1     
  Partials         43       43

@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 6822bfc Previous: bda2c20 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 930.08 us/op 1.0280 ms/op 0.90
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 92.368 us/op 97.815 us/op 0.94
BLS verify - blst-native 1.3293 ms/op 1.4836 ms/op 0.90
BLS verifyMultipleSignatures 3 - blst-native 2.5692 ms/op 2.8774 ms/op 0.89
BLS verifyMultipleSignatures 8 - blst-native 5.4642 ms/op 6.0476 ms/op 0.90
BLS verifyMultipleSignatures 32 - blst-native 19.728 ms/op 21.631 ms/op 0.91
BLS verifyMultipleSignatures 64 - blst-native 39.014 ms/op 41.856 ms/op 0.93
BLS verifyMultipleSignatures 128 - blst-native 78.087 ms/op 85.476 ms/op 0.91
BLS deserializing 10000 signatures 887.73 ms/op 1.0139 s/op 0.88
BLS deserializing 100000 signatures 8.9996 s/op 9.8490 s/op 0.91
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3250 ms/op 1.5297 ms/op 0.87
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.4916 ms/op 1.7664 ms/op 0.84
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.3091 ms/op 2.6651 ms/op 0.87
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.4091 ms/op 3.8540 ms/op 0.88
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.6362 ms/op 6.4085 ms/op 0.88
BLS aggregatePubkeys 32 - blst-native 29.483 us/op 32.586 us/op 0.90
BLS aggregatePubkeys 128 - blst-native 113.04 us/op 126.27 us/op 0.90
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 57.737 ms/op 69.181 ms/op 0.83
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 58.062 ms/op 75.029 ms/op 0.77
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 35.467 ms/op 49.316 ms/op 0.72
getSlashingsAndExits - default max 181.85 us/op 188.86 us/op 0.96
getSlashingsAndExits - 2k 485.46 us/op 696.83 us/op 0.70
proposeBlockBody type=full, size=empty 6.0935 ms/op 10.813 ms/op 0.56
isKnown best case - 1 super set check 422.00 ns/op 860.00 ns/op 0.49
isKnown normal case - 2 super set checks 412.00 ns/op 765.00 ns/op 0.54
isKnown worse case - 16 super set checks 338.00 ns/op 769.00 ns/op 0.44
InMemoryCheckpointStateCache - add get delete 6.4800 us/op 9.8320 us/op 0.66
validate api signedAggregateAndProof - struct 2.4129 ms/op 3.0154 ms/op 0.80
validate gossip signedAggregateAndProof - struct 2.4088 ms/op 3.2012 ms/op 0.75
validate gossip attestation - vc 640000 1.3948 ms/op 1.8874 ms/op 0.74
batch validate gossip attestation - vc 640000 - chunk 32 169.18 us/op 237.78 us/op 0.71
batch validate gossip attestation - vc 640000 - chunk 64 154.47 us/op 205.67 us/op 0.75
batch validate gossip attestation - vc 640000 - chunk 128 149.68 us/op 188.00 us/op 0.80
batch validate gossip attestation - vc 640000 - chunk 256 142.96 us/op 173.61 us/op 0.82
pickEth1Vote - no votes 1.3471 ms/op 1.6748 ms/op 0.80
pickEth1Vote - max votes 7.7888 ms/op 14.820 ms/op 0.53
pickEth1Vote - Eth1Data hashTreeRoot value x2048 15.974 ms/op 23.765 ms/op 0.67
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 20.720 ms/op 27.615 ms/op 0.75
pickEth1Vote - Eth1Data fastSerialize value x2048 634.66 us/op 774.04 us/op 0.82
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.1401 ms/op 5.8052 ms/op 0.89
bytes32 toHexString 572.00 ns/op 614.00 ns/op 0.93
bytes32 Buffer.toString(hex) 295.00 ns/op 363.00 ns/op 0.81
bytes32 Buffer.toString(hex) from Uint8Array 468.00 ns/op 553.00 ns/op 0.85
bytes32 Buffer.toString(hex) + 0x 305.00 ns/op 369.00 ns/op 0.83
Object access 1 prop 0.15800 ns/op 0.20800 ns/op 0.76
Map access 1 prop 0.15700 ns/op 0.18300 ns/op 0.86
Object get x1000 7.7360 ns/op 8.9130 ns/op 0.87
Map get x1000 0.77800 ns/op 1.0410 ns/op 0.75
Object set x1000 51.828 ns/op 70.838 ns/op 0.73
Map set x1000 43.722 ns/op 57.311 ns/op 0.76
Return object 10000 times 0.24360 ns/op 0.30860 ns/op 0.79
Throw Error 10000 times 4.0325 us/op 4.7234 us/op 0.85
fastMsgIdFn sha256 / 200 bytes 3.3970 us/op 4.1320 us/op 0.82
fastMsgIdFn h32 xxhash / 200 bytes 295.00 ns/op 395.00 ns/op 0.75
fastMsgIdFn h64 xxhash / 200 bytes 368.00 ns/op 461.00 ns/op 0.80
fastMsgIdFn sha256 / 1000 bytes 11.759 us/op 14.783 us/op 0.80
fastMsgIdFn h32 xxhash / 1000 bytes 429.00 ns/op 578.00 ns/op 0.74
fastMsgIdFn h64 xxhash / 1000 bytes 429.00 ns/op 541.00 ns/op 0.79
fastMsgIdFn sha256 / 10000 bytes 106.10 us/op 127.37 us/op 0.83
fastMsgIdFn h32 xxhash / 10000 bytes 2.0430 us/op 2.4880 us/op 0.82
fastMsgIdFn h64 xxhash / 10000 bytes 1.3810 us/op 1.6860 us/op 0.82
send data - 1000 256B messages 19.414 ms/op 23.417 ms/op 0.83
send data - 1000 512B messages 27.547 ms/op 31.030 ms/op 0.89
send data - 1000 1024B messages 40.723 ms/op 50.357 ms/op 0.81
send data - 1000 1200B messages 32.418 ms/op 39.446 ms/op 0.82
send data - 1000 2048B messages 39.593 ms/op 46.570 ms/op 0.85
send data - 1000 4096B messages 39.903 ms/op 41.613 ms/op 0.96
send data - 1000 16384B messages 94.331 ms/op 120.53 ms/op 0.78
send data - 1000 65536B messages 390.92 ms/op 441.44 ms/op 0.89
enrSubnets - fastDeserialize 64 bits 1.4110 us/op 1.8170 us/op 0.78
enrSubnets - ssz BitVector 64 bits 513.00 ns/op 573.00 ns/op 0.90
enrSubnets - fastDeserialize 4 bits 227.00 ns/op 246.00 ns/op 0.92
enrSubnets - ssz BitVector 4 bits 490.00 ns/op 576.00 ns/op 0.85
prioritizePeers score -10:0 att 32-0.1 sync 2-0 225.31 us/op 284.89 us/op 0.79
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 305.71 us/op 390.29 us/op 0.78
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 363.45 us/op 473.60 us/op 0.77
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 606.43 us/op 744.12 us/op 0.81
prioritizePeers score 0:0 att 64-1 sync 4-1 715.35 us/op 876.99 us/op 0.82
array of 16000 items push then shift 1.6512 us/op 1.9561 us/op 0.84
LinkedList of 16000 items push then shift 9.1560 ns/op 11.132 ns/op 0.82
array of 16000 items push then pop 97.679 ns/op 121.94 ns/op 0.80
LinkedList of 16000 items push then pop 8.8690 ns/op 10.615 ns/op 0.84
array of 24000 items push then shift 2.4911 us/op 3.0049 us/op 0.83
LinkedList of 24000 items push then shift 9.0630 ns/op 10.991 ns/op 0.82
array of 24000 items push then pop 120.36 ns/op 169.15 ns/op 0.71
LinkedList of 24000 items push then pop 8.8150 ns/op 10.714 ns/op 0.82
intersect bitArray bitLen 8 5.9990 ns/op 7.4910 ns/op 0.80
intersect array and set length 8 66.282 ns/op 85.705 ns/op 0.77
intersect bitArray bitLen 128 36.797 ns/op 46.141 ns/op 0.80
intersect array and set length 128 890.52 ns/op 1.2106 us/op 0.74
bitArray.getTrueBitIndexes() bitLen 128 1.4730 us/op 2.1430 us/op 0.69
bitArray.getTrueBitIndexes() bitLen 248 2.4950 us/op 3.6030 us/op 0.69
bitArray.getTrueBitIndexes() bitLen 512 4.8440 us/op 7.3500 us/op 0.66
Buffer.concat 32 items 971.00 ns/op 1.2390 us/op 0.78
Uint8Array.set 32 items 1.7200 us/op 2.4480 us/op 0.70
Set add up to 64 items then delete first 4.3548 us/op 5.6799 us/op 0.77
OrderedSet add up to 64 items then delete first 5.4597 us/op 7.6711 us/op 0.71
Set add up to 64 items then delete last 4.6616 us/op 6.3299 us/op 0.74
OrderedSet add up to 64 items then delete last 5.7436 us/op 8.0812 us/op 0.71
Set add up to 64 items then delete middle 4.6436 us/op 6.1279 us/op 0.76
OrderedSet add up to 64 items then delete middle 7.0884 us/op 9.7936 us/op 0.72
Set add up to 128 items then delete first 9.2777 us/op 13.301 us/op 0.70
OrderedSet add up to 128 items then delete first 12.404 us/op 17.061 us/op 0.73
Set add up to 128 items then delete last 9.1477 us/op 12.806 us/op 0.71
OrderedSet add up to 128 items then delete last 11.551 us/op 17.026 us/op 0.68
Set add up to 128 items then delete middle 9.0748 us/op 14.079 us/op 0.64
OrderedSet add up to 128 items then delete middle 17.702 us/op 24.409 us/op 0.73
Set add up to 256 items then delete first 18.965 us/op 26.261 us/op 0.72
OrderedSet add up to 256 items then delete first 25.175 us/op 34.526 us/op 0.73
Set add up to 256 items then delete last 18.227 us/op 25.304 us/op 0.72
OrderedSet add up to 256 items then delete last 23.509 us/op 32.252 us/op 0.73
Set add up to 256 items then delete middle 18.311 us/op 24.913 us/op 0.74
OrderedSet add up to 256 items then delete middle 45.125 us/op 61.285 us/op 0.74
transfer serialized Status (84 B) 1.6690 us/op 2.0620 us/op 0.81
copy serialized Status (84 B) 1.2030 us/op 1.4810 us/op 0.81
transfer serialized SignedVoluntaryExit (112 B) 1.7520 us/op 2.3850 us/op 0.73
copy serialized SignedVoluntaryExit (112 B) 1.2520 us/op 1.5310 us/op 0.82
transfer serialized ProposerSlashing (416 B) 1.9600 us/op 2.4340 us/op 0.81
copy serialized ProposerSlashing (416 B) 1.6680 us/op 2.0270 us/op 0.82
transfer serialized Attestation (485 B) 1.9930 us/op 2.8460 us/op 0.70
copy serialized Attestation (485 B) 1.6890 us/op 2.0710 us/op 0.82
transfer serialized AttesterSlashing (33232 B) 2.1080 us/op 2.5230 us/op 0.84
copy serialized AttesterSlashing (33232 B) 4.9970 us/op 7.7610 us/op 0.64
transfer serialized Small SignedBeaconBlock (128000 B) 2.6960 us/op 3.3980 us/op 0.79
copy serialized Small SignedBeaconBlock (128000 B) 13.763 us/op 24.143 us/op 0.57
transfer serialized Avg SignedBeaconBlock (200000 B) 3.2700 us/op 3.6470 us/op 0.90
copy serialized Avg SignedBeaconBlock (200000 B) 20.205 us/op 25.895 us/op 0.78
transfer serialized BlobsSidecar (524380 B) 2.9360 us/op 3.4510 us/op 0.85
copy serialized BlobsSidecar (524380 B) 85.621 us/op 131.87 us/op 0.65
transfer serialized Big SignedBeaconBlock (1000000 B) 3.0700 us/op 3.4440 us/op 0.89
copy serialized Big SignedBeaconBlock (1000000 B) 190.04 us/op 187.53 us/op 1.01
pass gossip attestations to forkchoice per slot 3.8241 ms/op 4.2118 ms/op 0.91
forkChoice updateHead vc 100000 bc 64 eq 0 718.98 us/op 758.97 us/op 0.95
forkChoice updateHead vc 600000 bc 64 eq 0 5.4521 ms/op 5.1508 ms/op 1.06
forkChoice updateHead vc 1000000 bc 64 eq 0 7.1922 ms/op 8.2162 ms/op 0.88
forkChoice updateHead vc 600000 bc 320 eq 0 4.2246 ms/op 4.7738 ms/op 0.88
forkChoice updateHead vc 600000 bc 1200 eq 0 4.4482 ms/op 5.0611 ms/op 0.88
forkChoice updateHead vc 600000 bc 7200 eq 0 5.5729 ms/op 6.6806 ms/op 0.83
forkChoice updateHead vc 600000 bc 64 eq 1000 11.352 ms/op 13.019 ms/op 0.87
forkChoice updateHead vc 600000 bc 64 eq 10000 12.146 ms/op 14.598 ms/op 0.83
forkChoice updateHead vc 600000 bc 64 eq 300000 15.728 ms/op 21.401 ms/op 0.73
computeDeltas 500000 validators 300 proto nodes 6.5332 ms/op 7.7241 ms/op 0.85
computeDeltas 500000 validators 1200 proto nodes 6.6929 ms/op 6.9762 ms/op 0.96
computeDeltas 500000 validators 7200 proto nodes 6.6088 ms/op 7.0436 ms/op 0.94
computeDeltas 750000 validators 300 proto nodes 9.7429 ms/op 10.356 ms/op 0.94
computeDeltas 750000 validators 1200 proto nodes 9.6638 ms/op 10.104 ms/op 0.96
computeDeltas 750000 validators 7200 proto nodes 9.1216 ms/op 10.197 ms/op 0.89
computeDeltas 1400000 validators 300 proto nodes 17.507 ms/op 18.824 ms/op 0.93
computeDeltas 1400000 validators 1200 proto nodes 17.685 ms/op 19.301 ms/op 0.92
computeDeltas 1400000 validators 7200 proto nodes 17.352 ms/op 19.465 ms/op 0.89
computeDeltas 2100000 validators 300 proto nodes 26.578 ms/op 30.498 ms/op 0.87
computeDeltas 2100000 validators 1200 proto nodes 26.702 ms/op 30.803 ms/op 0.87
computeDeltas 2100000 validators 7200 proto nodes 27.034 ms/op 30.882 ms/op 0.88
altair processAttestation - 250000 vs - 7PWei normalcase 2.2411 ms/op 2.9446 ms/op 0.76
altair processAttestation - 250000 vs - 7PWei worstcase 3.4106 ms/op 4.2961 ms/op 0.79
altair processAttestation - setStatus - 1/6 committees join 173.45 us/op 227.39 us/op 0.76
altair processAttestation - setStatus - 1/3 committees join 340.60 us/op 450.39 us/op 0.76
altair processAttestation - setStatus - 1/2 committees join 431.45 us/op 551.03 us/op 0.78
altair processAttestation - setStatus - 2/3 committees join 543.66 us/op 627.73 us/op 0.87
altair processAttestation - setStatus - 4/5 committees join 751.12 us/op 966.08 us/op 0.78
altair processAttestation - setStatus - 100% committees join 917.78 us/op 1.1483 ms/op 0.80
altair processBlock - 250000 vs - 7PWei normalcase 10.531 ms/op 9.5288 ms/op 1.11
altair processBlock - 250000 vs - 7PWei normalcase hashState 36.842 ms/op 42.614 ms/op 0.86
altair processBlock - 250000 vs - 7PWei worstcase 35.427 ms/op 47.112 ms/op 0.75
altair processBlock - 250000 vs - 7PWei worstcase hashState 139.19 ms/op 113.55 ms/op 1.23
phase0 processBlock - 250000 vs - 7PWei normalcase 3.3075 ms/op 3.3875 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei worstcase 36.044 ms/op 40.077 ms/op 0.90
altair processEth1Data - 250000 vs - 7PWei normalcase 769.03 us/op 876.40 us/op 0.88
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 22.366 us/op 21.059 us/op 1.06
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 112.35 us/op 82.945 us/op 1.35
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 24.858 us/op 33.890 us/op 0.73
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 19.128 us/op 28.305 us/op 0.68
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 201.91 us/op 199.01 us/op 1.01
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 2.0168 ms/op 1.7625 ms/op 1.14
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.3880 ms/op 2.3786 ms/op 1.00
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.5605 ms/op 2.6798 ms/op 0.58
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.4464 ms/op 6.8510 ms/op 0.50
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 3.0533 ms/op 3.9977 ms/op 0.76
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.4037 ms/op 9.6546 ms/op 0.46
Tree 40 250000 create 236.94 ms/op 738.11 ms/op 0.32
Tree 40 250000 get(125000) 203.69 ns/op 333.57 ns/op 0.61
Tree 40 250000 set(125000) 720.92 ns/op 2.5951 us/op 0.28
Tree 40 250000 toArray() 17.587 ms/op 31.337 ms/op 0.56
Tree 40 250000 iterate all - toArray() + loop 17.230 ms/op 29.089 ms/op 0.59
Tree 40 250000 iterate all - get(i) 64.771 ms/op 108.56 ms/op 0.60
MutableVector 250000 create 11.366 ms/op 20.659 ms/op 0.55
MutableVector 250000 get(125000) 6.4130 ns/op 17.789 ns/op 0.36
MutableVector 250000 set(125000) 267.36 ns/op 736.60 ns/op 0.36
MutableVector 250000 toArray() 3.2769 ms/op 5.5765 ms/op 0.59
MutableVector 250000 iterate all - toArray() + loop 3.4250 ms/op 5.8660 ms/op 0.58
MutableVector 250000 iterate all - get(i) 1.6634 ms/op 2.1849 ms/op 0.76
Array 250000 create 2.7670 ms/op 5.3455 ms/op 0.52
Array 250000 clone - spread 1.3079 ms/op 2.6729 ms/op 0.49
Array 250000 get(125000) 1.0680 ns/op 2.6080 ns/op 0.41
Array 250000 set(125000) 4.1420 ns/op 7.3230 ns/op 0.57
Array 250000 iterate all - loop 165.96 us/op 265.43 us/op 0.63
effectiveBalanceIncrements clone Uint8Array 300000 30.949 us/op 78.852 us/op 0.39
effectiveBalanceIncrements clone MutableVector 300000 408.00 ns/op 1.3310 us/op 0.31
effectiveBalanceIncrements rw all Uint8Array 300000 200.04 us/op 318.42 us/op 0.63
effectiveBalanceIncrements rw all MutableVector 300000 87.449 ms/op 203.70 ms/op 0.43
phase0 afterProcessEpoch - 250000 vs - 7PWei 112.46 ms/op 147.95 ms/op 0.76
phase0 beforeProcessEpoch - 250000 vs - 7PWei 34.983 ms/op 79.708 ms/op 0.44
altair processEpoch - mainnet_e81889 464.99 ms/op 688.61 ms/op 0.68
mainnet_e81889 - altair beforeProcessEpoch 68.500 ms/op 94.388 ms/op 0.73
mainnet_e81889 - altair processJustificationAndFinalization 14.084 us/op 35.979 us/op 0.39
mainnet_e81889 - altair processInactivityUpdates 6.1605 ms/op 7.1616 ms/op 0.86
mainnet_e81889 - altair processRewardsAndPenalties 56.549 ms/op 65.599 ms/op 0.86
mainnet_e81889 - altair processRegistryUpdates 2.3390 us/op 4.1660 us/op 0.56
mainnet_e81889 - altair processSlashings 527.00 ns/op 1.1270 us/op 0.47
mainnet_e81889 - altair processEth1DataReset 554.00 ns/op 825.00 ns/op 0.67
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3199 ms/op 1.7236 ms/op 0.77
mainnet_e81889 - altair processSlashingsReset 3.7820 us/op 7.0520 us/op 0.54
mainnet_e81889 - altair processRandaoMixesReset 5.0860 us/op 7.4580 us/op 0.68
mainnet_e81889 - altair processHistoricalRootsUpdate 554.00 ns/op 1.3410 us/op 0.41
mainnet_e81889 - altair processParticipationFlagUpdates 1.3800 us/op 4.4060 us/op 0.31
mainnet_e81889 - altair processSyncCommitteeUpdates 645.00 ns/op 1.7740 us/op 0.36
mainnet_e81889 - altair afterProcessEpoch 120.83 ms/op 166.06 ms/op 0.73
capella processEpoch - mainnet_e217614 1.5844 s/op 2.3599 s/op 0.67
mainnet_e217614 - capella beforeProcessEpoch 287.13 ms/op 387.57 ms/op 0.74
mainnet_e217614 - capella processJustificationAndFinalization 15.354 us/op 36.283 us/op 0.42
mainnet_e217614 - capella processInactivityUpdates 15.874 ms/op 20.204 ms/op 0.79
mainnet_e217614 - capella processRewardsAndPenalties 272.37 ms/op 375.74 ms/op 0.72
mainnet_e217614 - capella processRegistryUpdates 20.786 us/op 27.302 us/op 0.76
mainnet_e217614 - capella processSlashings 552.00 ns/op 955.00 ns/op 0.58
mainnet_e217614 - capella processEth1DataReset 408.00 ns/op 727.00 ns/op 0.56
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.0265 ms/op 17.970 ms/op 0.22
mainnet_e217614 - capella processSlashingsReset 3.2540 us/op 4.0570 us/op 0.80
mainnet_e217614 - capella processRandaoMixesReset 4.4270 us/op 6.4480 us/op 0.69
mainnet_e217614 - capella processHistoricalRootsUpdate 578.00 ns/op 1.3240 us/op 0.44
mainnet_e217614 - capella processParticipationFlagUpdates 1.6270 us/op 3.4080 us/op 0.48
mainnet_e217614 - capella afterProcessEpoch 330.18 ms/op 437.35 ms/op 0.75
phase0 processEpoch - mainnet_e58758 487.64 ms/op 661.40 ms/op 0.74
mainnet_e58758 - phase0 beforeProcessEpoch 137.18 ms/op 164.74 ms/op 0.83
mainnet_e58758 - phase0 processJustificationAndFinalization 15.582 us/op 33.064 us/op 0.47
mainnet_e58758 - phase0 processRewardsAndPenalties 24.366 ms/op 33.445 ms/op 0.73
mainnet_e58758 - phase0 processRegistryUpdates 9.3000 us/op 18.492 us/op 0.50
mainnet_e58758 - phase0 processSlashings 422.00 ns/op 1.0650 us/op 0.40
mainnet_e58758 - phase0 processEth1DataReset 414.00 ns/op 1.0470 us/op 0.40
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0752 ms/op 1.5683 ms/op 0.69
mainnet_e58758 - phase0 processSlashingsReset 3.0650 us/op 3.6960 us/op 0.83
mainnet_e58758 - phase0 processRandaoMixesReset 4.8770 us/op 6.2030 us/op 0.79
mainnet_e58758 - phase0 processHistoricalRootsUpdate 551.00 ns/op 989.00 ns/op 0.56
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.1080 us/op 12.173 us/op 0.26
mainnet_e58758 - phase0 afterProcessEpoch 96.070 ms/op 131.28 ms/op 0.73
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3096 ms/op 2.2135 ms/op 0.59
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.8608 ms/op 1.9301 ms/op 0.96
altair processInactivityUpdates - 250000 normalcase 16.806 ms/op 24.922 ms/op 0.67
altair processInactivityUpdates - 250000 worstcase 17.177 ms/op 23.558 ms/op 0.73
phase0 processRegistryUpdates - 250000 normalcase 9.6590 us/op 13.094 us/op 0.74
phase0 processRegistryUpdates - 250000 badcase_full_deposits 355.57 us/op 632.48 us/op 0.56
phase0 processRegistryUpdates - 250000 worstcase 0.5 143.46 ms/op 156.58 ms/op 0.92
altair processRewardsAndPenalties - 250000 normalcase 50.644 ms/op 58.668 ms/op 0.86
altair processRewardsAndPenalties - 250000 worstcase 51.045 ms/op 61.523 ms/op 0.83
phase0 getAttestationDeltas - 250000 normalcase 8.6254 ms/op 13.329 ms/op 0.65
phase0 getAttestationDeltas - 250000 worstcase 8.8369 ms/op 12.640 ms/op 0.70
phase0 processSlashings - 250000 worstcase 81.793 us/op 100.26 us/op 0.82
altair processSyncCommitteeUpdates - 250000 148.22 ms/op 176.16 ms/op 0.84
BeaconState.hashTreeRoot - No change 354.00 ns/op 651.00 ns/op 0.54
BeaconState.hashTreeRoot - 1 full validator 134.25 us/op 136.93 us/op 0.98
BeaconState.hashTreeRoot - 32 full validator 1.5140 ms/op 1.3951 ms/op 1.09
BeaconState.hashTreeRoot - 512 full validator 16.061 ms/op 22.057 ms/op 0.73
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 165.54 us/op 242.63 us/op 0.68
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.0657 ms/op 3.3629 ms/op 0.61
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 25.024 ms/op 42.432 ms/op 0.59
BeaconState.hashTreeRoot - 1 balances 125.26 us/op 165.32 us/op 0.76
BeaconState.hashTreeRoot - 32 balances 1.3103 ms/op 1.4239 ms/op 0.92
BeaconState.hashTreeRoot - 512 balances 11.080 ms/op 13.696 ms/op 0.81
BeaconState.hashTreeRoot - 250000 balances 215.33 ms/op 276.34 ms/op 0.78
aggregationBits - 2048 els - zipIndexesInBitList 26.687 us/op 35.469 us/op 0.75
byteArrayEquals 32 74.776 ns/op 82.570 ns/op 0.91
Buffer.compare 32 55.338 ns/op 65.967 ns/op 0.84
byteArrayEquals 1024 2.0383 us/op 2.5250 us/op 0.81
Buffer.compare 1024 73.508 ns/op 96.468 ns/op 0.76
byteArrayEquals 16384 32.427 us/op 44.611 us/op 0.73
Buffer.compare 16384 256.06 ns/op 372.77 ns/op 0.69
byteArrayEquals 123687377 244.30 ms/op 382.41 ms/op 0.64
Buffer.compare 123687377 6.1028 ms/op 12.828 ms/op 0.48
byteArrayEquals 32 - diff last byte 72.758 ns/op 113.59 ns/op 0.64
Buffer.compare 32 - diff last byte 54.363 ns/op 98.165 ns/op 0.55
byteArrayEquals 1024 - diff last byte 2.0069 us/op 3.0415 us/op 0.66
Buffer.compare 1024 - diff last byte 69.605 ns/op 102.79 ns/op 0.68
byteArrayEquals 16384 - diff last byte 32.251 us/op 53.301 us/op 0.61
Buffer.compare 16384 - diff last byte 270.60 ns/op 410.55 ns/op 0.66
byteArrayEquals 123687377 - diff last byte 243.35 ms/op 354.56 ms/op 0.69
Buffer.compare 123687377 - diff last byte 6.4767 ms/op 12.115 ms/op 0.53
byteArrayEquals 32 - random bytes 5.1900 ns/op 9.6410 ns/op 0.54
Buffer.compare 32 - random bytes 60.206 ns/op 88.772 ns/op 0.68
byteArrayEquals 1024 - random bytes 5.1130 ns/op 8.3710 ns/op 0.61
Buffer.compare 1024 - random bytes 59.214 ns/op 86.231 ns/op 0.69
byteArrayEquals 16384 - random bytes 5.1130 ns/op 8.3800 ns/op 0.61
Buffer.compare 16384 - random bytes 59.329 ns/op 77.879 ns/op 0.76
byteArrayEquals 123687377 - random bytes 8.0800 ns/op 24.140 ns/op 0.33
Buffer.compare 123687377 - random bytes 62.380 ns/op 102.20 ns/op 0.61
regular array get 100000 times 43.884 us/op 65.299 us/op 0.67
wrappedArray get 100000 times 43.784 us/op 63.525 us/op 0.69
arrayWithProxy get 100000 times 14.154 ms/op 24.092 ms/op 0.59
ssz.Root.equals 53.057 ns/op 95.795 ns/op 0.55
byteArrayEquals 52.118 ns/op 85.491 ns/op 0.61
Buffer.compare 10.708 ns/op 16.763 ns/op 0.64
shuffle list - 16384 els 8.2414 ms/op 12.979 ms/op 0.64
shuffle list - 250000 els 121.03 ms/op 171.34 ms/op 0.71
processSlot - 1 slots 15.105 us/op 22.460 us/op 0.67
processSlot - 32 slots 3.2278 ms/op 4.4067 ms/op 0.73
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 56.465 ms/op 70.684 ms/op 0.80
getCommitteeAssignments - req 1 vs - 250000 vc 2.7309 ms/op 3.0715 ms/op 0.89
getCommitteeAssignments - req 100 vs - 250000 vc 3.9692 ms/op 4.6620 ms/op 0.85
getCommitteeAssignments - req 1000 vs - 250000 vc 4.4183 ms/op 4.9715 ms/op 0.89
findModifiedValidators - 10000 modified validators 324.66 ms/op 455.15 ms/op 0.71
findModifiedValidators - 1000 modified validators 211.07 ms/op 331.11 ms/op 0.64
findModifiedValidators - 100 modified validators 194.19 ms/op 344.07 ms/op 0.56
findModifiedValidators - 10 modified validators 203.42 ms/op 316.65 ms/op 0.64
findModifiedValidators - 1 modified validators 186.78 ms/op 315.73 ms/op 0.59
findModifiedValidators - no difference 199.27 ms/op 309.49 ms/op 0.64
compare ViewDUs 3.7069 s/op 5.1598 s/op 0.72
compare each validator Uint8Array 1.6137 s/op 2.0902 s/op 0.77
compare ViewDU to Uint8Array 1.1655 s/op 1.6704 s/op 0.70
migrate state 1000000 validators, 24 modified, 0 new 654.76 ms/op 982.13 ms/op 0.67
migrate state 1000000 validators, 1700 modified, 1000 new 1.1091 s/op 1.5627 s/op 0.71
migrate state 1000000 validators, 3400 modified, 2000 new 1.4440 s/op 1.9558 s/op 0.74
migrate state 1500000 validators, 24 modified, 0 new 716.99 ms/op 1.1103 s/op 0.65
migrate state 1500000 validators, 1700 modified, 1000 new 1.0880 s/op 1.6349 s/op 0.67
migrate state 1500000 validators, 3400 modified, 2000 new 1.4683 s/op 2.0502 s/op 0.72
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.3800 ns/op 6.4700 ns/op 0.68
state getBlockRootAtSlot - 250000 vs - 7PWei 903.82 ns/op 991.77 ns/op 0.91
computeProposers - vc 250000 9.2068 ms/op 13.286 ms/op 0.69
computeEpochShuffling - vc 250000 130.43 ms/op 194.32 ms/op 0.67
getNextSyncCommittee - vc 250000 159.12 ms/op 232.52 ms/op 0.68
computeSigningRoot for AttestationData 25.348 us/op 37.877 us/op 0.67
hash AttestationData serialized data then Buffer.toString(base64) 2.3274 us/op 3.2190 us/op 0.72
toHexString serialized data 1.0751 us/op 2.1661 us/op 0.50
Buffer.toString(base64) 227.01 ns/op 425.92 ns/op 0.53

by benchmarkbot/action

matthewkeil
matthewkeil approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🎸

@wemeetagain wemeetagain merged commit 3c5bb15 into unstable May 22, 2024
20 checks passed
@wemeetagain wemeetagain deleted the nflaig/review-6743 branch May 22, 2024 12:45
wemeetagain added a commit that referenced this pull request Jun 7, 2024
@wemeetagain @twoeths
@jeluard @nflaig @matthewkeil @ensi321 @g11tech @nazarhussain @dependabot
chore: release v1.19.0 (#6854)
903672a 
* chore: n-historical state - track state persist count per epoch (#6699)

* feat: add lodestar binaries to release (#6666)

* feat: added binaries creation support

* feat: added sanity checks

* chore: define reusable workflow

* chore: fix sanity check,; disable arm64

* chore: added workflow_dispatch

* fix: needs cleanup

* chore: update old space size

Co-authored-by: Nico Flaig <[email protected]>

* chore: address comments

* chore: address comments

* chore: fixed typo

* chore: typo

Co-authored-by: Nico Flaig <[email protected]>

* chore: address comments

* chore: wording

Co-authored-by: Nico Flaig <[email protected]>

* chore: use frozen lock file

Co-authored-by: Nico Flaig <[email protected]>

---------

Co-authored-by: Nico Flaig <[email protected]>

* feat: switch bls to napi rebuild (#6616)

* chore: update package.json deps and run yarn

* feat: remove unused blst config from vitest.browser.*.config.ts

* test: move G2@INF test to base blst repo.  No longer exported.

* fix: add Uint8Array.from for Buffer return value in unit test so type matches for toEqual

* refactor: update imports of CoordType to use bls instead of blst

* feat: add blsAddVerificationRandomness cli option

* feat: add randomBytesNonZero to utils

* feat: implement verification randomness for same message

* feat: implement napi blst and switch to libuv worker pool

* chore: lint

* fix: update comments for availableParallelism

* feat: set UV_THREADPOOL_SIZE for perf tests

* feat: set UV_THREADPOOL_SIZE=$(nproc) in lodestar entrance script

* feat: remove case for serialized PublicKey in deserializeSet

* feat: add back workBusy count logic to canAcceptWork

* feat: automatically set threadpool size in beaconHandler

* refactor: rename flag to disableSameMessageVerificationRandomness

* fix: remove UV_THREADPOOL_SIZE from ./lodestar

* docs: add TODO about updating metrics

* fix: make benchmark multi threading cross-compatible

* chore: add [email protected]

* feat: default to added randomness

* feat: add warning for no same message randomness

* fix: passing to updated bls functions

* feat: add blst peerDep

* fix: default to same message randomness

* chore: update yarn.lock

* chore: remove unused function to clear lint

* feat: break out setThreadPoolSize

* docs: update packages/cli/src/cmds/beacon/setThreadPoolSize.ts

Co-authored-by: Nico Flaig <[email protected]>

* chore: update location for blst dep

* chore: run lint again

* fix: remove peerDep from light-client

* test: fix browser based tests

* fix: bad relative imports

* docs: add note to readme about switchable bls

* docs: typo

* chore: lint readme

* fix: light-client unit tests

* fix: light-client e2e test

* feat: remove disableSameMessageVerificationRandomness

* refactor: remove unused type

* docs: update wordlist

* fix: e2e tests

* Lint package.json

* Revert "fix: e2e tests"

This reverts commit f71acd7.

* Revert "fix: light-client e2e test"

This reverts commit 23c11f0.

* Revert "fix: light-client unit tests"

This reverts commit fa7893e.

* Revert "test: fix browser based tests"

This reverts commit 98d04ab.

* docs: update readme to remove switchable bls argument

* fix: replace optimizeDeps in vitest.browser.config

* chore: updated to bls 8.1.0

* feat: move setting threadpool size and warnings to applyPreset.ts

* fix: remove setThreadpoolSize from beacon handler

* feat: move libuv size logging into handler to use logger

* refactor: rename applyPreset to preInitialization

* refactor: logging about pool size

* Update packages/cli/src/options/globalOptions.ts

Co-authored-by: Nico Flaig <[email protected]>

* refactor: rename prover applyPreset

* docs: change comment in cli/index

* fix: update logging for

* fix: throw error for invalid uvThreadpoolSize

* Update packages/cli/src/preInitialization.ts

Co-authored-by: Nico Flaig <[email protected]>

* Fix lint issues

* Remove unused import

* refactor: move bls pool logging back to multithread.ts

* fix: log of threadcount

---------

Co-authored-by: Nico Flaig <[email protected]>

* chore: update references to consensus spec to v1.4.0 (#6704)

* chore: update references to consensus spec to v1.4.0

* Remove unintended formatting changes

* chore: update consensus spec version in README (#6705)

* docs: correct plausible url (#6709)

fix: correct plausible url

* docs: incorrect scripts location (#6710)

fix: incorrect scripts location

* docs: no more broken images (#6708)

* fix: no more broken images

* fix: incorrect paths

* feat: check aggregationBits length of `SignedAggregateAndProof` in gossip validation (#6700)

* Add unit test

* Update packages/beacon-node/src/chain/validation/aggregateAndProof.ts

Co-authored-by: Nico Flaig <[email protected]>

---------

Co-authored-by: Nico Flaig <[email protected]>

* feat: add and track blob source for metrics (#6628)

* feat: add and track blob source for metrics

* adding blobsSource for blobsPromise

* address feedback

* apply feedback

* updates

* only allow non blobspromise blocks to be imported

* feat: add support for browser bundle for lightclient (#6673)

* Reorganize the code so it is accessible from one package

* Add support for browser build for lightclient

* Update the build config

* Improve the bls vite plugin

* Restructure the vite and vitest scripts

* Simplify vite config

* Remove unused polyfill

* Fix the doc lint error

* Add support for bundle test

* Update the package json files

* Add dist build to default build task

* Fix spelling in the docs

* Fix the lint error

* Fix type error

* Disable eslint errors

* Increase the timeout for bundle test

* Fix eslint bundle

* Fix lint warning

* Remove the unused config

* Add the default export to bundle

* Enable compression on th build

* Update packages/light-client/README.md

Co-authored-by: Nico Flaig <[email protected]>

* Increase timeout for one test

* Optimize package build task

* Update the readme

---------

Co-authored-by: Nico Flaig <[email protected]>

* docs: fix plausible domain (#6712)

* ci: add paths-ignore to workflows (#6713)

* chore: added paths-ignore

* chore: address comments

* feat: add arm64 binary support (#6707)

* feat: add arm64 binary support

* chore: workaround yarn

* chore: add comment

* chore: workaround runner limitations

* ci: publish binaries for release candidates (#6714)

* feat: add types support to esm bundle for lightclient (#6685)

* Add vite dts plugin

* Restructure types export

* Update vite build config

* Remove unused file

* Update the build process

* Fix doc formatting

* Build the dist for type tests

* chore: update vitest (#6718)

Update vitest

* chore: do not build all binaries atomically (#6719)

* feat: update libp2p deps (#6711)

* feat: update libp2p deps

* chore: fix linter/type errors

* chore(deps): bump ejs from 3.1.9 to 3.1.10 (#6721)

Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](mde/ejs@v3.1.9...v3.1.10)

---
updated-dependencies:
- dependency-name: ejs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: revert "ci: add paths-ignore to workflows (#6713)" (#6730)

Revert "ci: add paths-ignore to workflows (#6713)"

This reverts commit e460bb1.

* docs: restore docs pages lost during docusaurus migration (#6725)

* ci: fix incorrect build caching (#6731)

fix: incorrect build caching

* fix: build error log during esm bundle build (#6737)

Fix build error

* chore: update fastify to v4.27.0 (#6740)

* deps: upgrade vitest minor version (#6745)

Upgrade vitest

* chore: warn when heap limit is too low (#6722)

* chore: warn when heap limit is too low

* chore: units

Co-authored-by: Nico Flaig <[email protected]>

* chore: address comments

* chore: added faq element

* chore: address comments

Co-authored-by: Nico Flaig <[email protected]>

* chore: address comments

Co-authored-by: Nico Flaig <[email protected]>

* chore: address comments

---------

Co-authored-by: Nico Flaig <[email protected]>

* feat: disable flood publish (#6755)

* feat: disable flood publish

* feat: add network.disableFloodPublish cli flag

* chore: address PR comments

* test: allow compact diff for test failures (#6783)

* Allow the compact diff for tests

* Update the doc

* Update docs/pages/contribution/testing/index.md

Co-authored-by: Julien <[email protected]>

* Fix linting on docs

* Fix linting

---------

Co-authored-by: Julien <[email protected]>

* chore: upgrade classic-level (#6793)

* chore: upgrade classic-level

* chore: address comments

* feat(prover): support non-mutated verification provider in prover (#6727)

* Restructure the assertions

* Add an inspector to run the logic to detect providers

* Update web3 provdier logic to use inspetor

* Fix the types for proxy

* Make the default type for mutation

* Rename elrpc to elrpcprovider

* Apply suggestions from code review

Co-authored-by: Julien <[email protected]>

* Fix build error

* Update the readme doc

* Apply suggestions from code review

Co-authored-by: Julien <[email protected]>

* Fix the docs linting

* Add missing words

---------

Co-authored-by: Julien <[email protected]>

* docs: added debugging section (#6743)

* docs: added debugging section

* chore: spell checks

* chore: added extra docs

* chore: address comments

* chore: added extra configuration

* chore: updated docs

* chore: added extra configuration

* chore: fix lint

* chore: fix typos

* chore: .gitignore

* chore: address comments

* chore: address comments

* chore: review debugging section PR (#6807)

* chore: update the naming conventions used in sim tests (#6805)

* Rename simulation test to crucible

* Rename SimulationEnvironment to Simulation

* Use consistent function names

* Update readme

* Rename interfaces for consistent pattern

* Fix lint error

* feat: recognize grandine from agentVersion (#6808)

* Add grandine

* add grandine to wordlist

* chore: refactor event loop interactions (#6806)

* chore: refactor sleep(0) usage

* chore: refactor setTimeout

* chore: address comments

* chore: cleanup

* Apply suggestions from code review

---------

Co-authored-by: Cayman <[email protected]>

* chore: fix broken docker (#6813)

* chore: log newPayload engine api (#6810)

* chore: add `get_proposer_head` check in fork choice spec test (#6814)

* Check get_proposer_head

* Fix enum typo

* lint

* chore: consolidate classic-level usage (#6795)

* chore: do not rely on leveldown

* chore: replace level with classic-level

* chore: added docker support for osx (#6696)

* chore: added docker support for osx

* chore: address comments

* chore: address comments

* Update docker-compose.yml

Co-authored-by: Nico Flaig <[email protected]>

* chore: address comments

---------

Co-authored-by: Nico Flaig <[email protected]>

* chore: fix vitest performance with spec tests artifacts in place (#6817)

Fix vitest performance with spec tests in place

* chore: clean up yarn lockfile (#6816)

* feat: disable flood publish by default (#6815)

* feat: use @chainsafe/blst directly (#6706)

* feat: use @chainsafe/blst directly

* chore: update to [email protected]

* refactor: remove randomBytesNonZero and user blst exported version

* chore: update blst references

* test: catch invalid deserialization in spec tests and return false

* feat: create signatureFromBytes and signatureFromBytesNoCheck in utils package

* feat: implement signatureFromBytes from utils package

* feat: implement signatureFromBytes everywhere

* fix: light-client empty module for blst

---------

Co-authored-by: matthewkeil <[email protected]>

* fix: avoid Buffer.from copies (#6723)

* fix: avoid Buffer.from copies

* chore: simplify shuffling

* fix: use subarray instead of slice in shuffling

* chore: remove unnecessary devDependencies

* chore: rely on fastify 4.x behavior

* chore: avoid copy in verifyMerkleBranch

* use toBase64

* relax assertions in shuffle function

* Update packages/state-transition/src/util/shuffle.ts

Co-authored-by: twoeths <[email protected]>

---------

Co-authored-by: twoeths <[email protected]>

* chore: update nodejs to latest 22 (#6729)

* Upgrade node js version to 22

* Update node types

* Revert action config

* Add package from git hash

* Fix the build error

* Update the docs for node-22

* Update docker version for Nodejs to 22

* Update package.json

* Update package.json

Co-authored-by: Nico Flaig <[email protected]>

* Update readme docs

* Add word in dictionary

* Add word in dictionary

---------

Co-authored-by: Cayman <[email protected]>
Co-authored-by: Nico Flaig <[email protected]>

* deps: update systeminformation to 5.22.9 (#6823)

* chore: add distutils to build phase of Dockerfile (#6845)

* test: increase timeout of keystore tests (#6846)

* test: increase timeout of keystore cache tests

* Increase hook timeout

* Consistent number formatting

* chore: only log warning if media type is not supported (415) (#6847)

* fix: revert napi bls (#6853)

* Revert "feat: use @chainsafe/blst directly (#6706)"

This reverts commit 66fe753.

* Revert "feat: switch bls to napi rebuild (#6616)"

This reverts commit 97d9aa8.

* chore: bump package versions to 1.19.0

* chore: bump @chainsafe/blst to v0.2.11 (#6856)

* fix: arm64 binaries creation issue (#6858)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: tuyennhv <[email protected]>
Co-authored-by: Julien <[email protected]>
Co-authored-by: Nico Flaig <[email protected]>
Co-authored-by: Matthew Keil <[email protected]>
Co-authored-by: NC <[email protected]>
Co-authored-by: g11tech <[email protected]>
Co-authored-by: Nazar Hussain <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.19.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewkeil matthewkeil matthewkeil approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

@jeluard jeluard jeluard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nflaig @wemeetagain @jeluard @matthewkeil