Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minimal alloc viewdu batch hash #6977

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jul 24, 2024

Motivation

  • Minimal memory allocation when batch hash state
    • process block
    • state.balances after an epoch transition

Description

Consume ChainSafe/ssz#388

Testing

  • this branch - 1k: spiked 10 times in the last 2 days, average at base level is ~120ms to 130ms
Screenshot 2024-07-24 at 13 45 19
  • te/batch_hash_tree_root - 64: spiked 20 times in the last 2 days, average at base level is not stable ranging from ~130ms to 250ms
Screenshot 2024-07-24 at 13 47 55

@twoeths twoeths requested a review from a team as a code owner July 24, 2024 06:48
@twoeths twoeths changed the title Te/minimal alloc viewdu batch hash feat: minimal alloc viewdu batch hash Jul 24, 2024
@twoeths twoeths merged commit bff2090 into te/batch_hash_tree_root Jul 24, 2024
13 of 18 checks passed
@twoeths twoeths deleted the te/minimal_alloc_viewdu_batch_hash branch July 24, 2024 06:50
twoeths added a commit that referenced this pull request Aug 2, 2024
* fix: sync listValidator.ts from ssz

* fix: reuse HashComputationGroup in some flows

* feat: use same HCGroup for epoch transition

* fix: only batch hash balances of state in epoch transition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant