Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: full batch hash on epoch transition #7030

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Aug 16, 2024

Motivation

  • Previously the batch hash of state happen in every hashTreeRoot(), and I found only batch hash balances gave more performant because there is less gc, but not able to find the root cause of it

Description

  • With new batchHashTreeRoot() api, we only apply when process epoch and block
  • lg1k shows comparable performance
Screenshot 2024-08-16 at 09 51 48
  • while the test mainnet node showed better performance
Screenshot 2024-08-16 at 09 52 22

@twoeths twoeths marked this pull request as ready for review August 16, 2024 02:54
@twoeths twoeths requested a review from a team as a code owner August 16, 2024 02:54
@twoeths twoeths merged commit 26af7b9 into te/batch_hash_tree_root Aug 16, 2024
12 of 16 checks passed
@twoeths twoeths deleted the te/full_batch_epoch_transition branch August 16, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant