feat: snapshot apis for EIP-4881 #400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
g11tech
reviewed
Sep 10, 2024
| * - special handle for index === snapshot.count - 1, we restore from snapshot | ||
| */ | ||
| sliceTo(index: number): this { | ||
| if (index < this.snapshot.count - 1) { |
g11tech
previously approved these changes
Sep 10, 2024
now instead of saving all roots, we'll just save serialized snapshot periodically. Something like: const treeSnapshot = depositRootTree.toSnapshot(depositCount);
const depositSnapshot = {
finalized: treeSnapshot.finalized,
depositRoot: treeSnapshot.root,
depositCount: treeSnapshot.count,
executionBlockHash,
executionBlockHeight,
};
db.put(executionBlockHeight, depositSnapshot);upon restart we download snapshot from const depositRootTree = DepositDataRootPartialList.toPartialViewDU({
finalized: snapshot.finalized,
root: snapshot.depositRoot,
count: snapshot.depositCount,
});then the partial tree grows from there similar to the current full tree |
wemeetagain
reviewed
Sep 11, 2024
packages/ssz/src/util/types.ts
Outdated
| @@ -1 +1,8 @@ | |||
| export type Require<T, K extends keyof T> = T & Required<Pick<T, K>>; | |||
|
|
|||
| /** Snapshot for PartialListCompositeType */ | |||
There was a problem hiding this comment.
Can you add more comments here?
Eg:
A snapshot contains the minimum amount of information needed to reconstruct a merkleized list, for the purposes of appending more items. Note: This does not contain list elements, rather only contains intermediate merkle nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implement snapshot apis for eip-4881
Description
PartialListCompositeTypetype along with ViewDU (and no View since we lacks a lot of methods there and dont maintain it anymore)toPartialViewDU()api as the entry pointtoSnapshot, fromSnapshotapisDepositDataRootPartialList = new PartialListCompositeType(Root, 2 ** DEPOSIT_CONTRACT_TREE_DEPTH);depositRootTree = DepositDataRootPartialList.toPartialViewDU(snapshot)Closes #293
a candidate to replace #377
TODOs