feat/snapshot-eip-4881

[AkshatGada]

Attempts to solve issue ChainSafe/lodestar#4935

1. Added deposit contract snapshot interface
2. Added test cases

waiting for your review

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[philknows]

If you were trying to commit your work from here, it did not make it into this PR...

[wemeetagain]

Looks like a good start. A few comments:

Instead of redefining MerkleTree, Leaf, Node, etc here, please reuse the existing infra from this library. That means using the existing Tree, LeafNode, BranchNode constructs. You should be able to define your custom tree editing / navigation functions either purely functionally, or in a wrapper class.

Eventually, this code / PR should be migrated to the lodestar repo and live there. Whether you want to keep this review here for now is up to you.

[AkshatGada]

Thanks so much for your feedback , I will start resolving the linting errors and also start to run successfully tests . Regards , Akshat

…

On Fri, Jun 14, 2024, 7:29 PM Cayman ***@***.***> wrote: ***@***.**** commented on this pull request. Looks like a good start. A few comments: Instead of redefining MerkleTree, Leaf, Node, etc here, please reuse the existing infra from this library. That means using the existing Tree, LeafNode, BranchNode constructs. You should be able to define your custom tree editing / navigation functions either purely functionally, or in a wrapper class. Eventually, this code / PR should be migrated to the lodestar repo and live there. Whether you want to keep this review here for now is up to you. — Reply to this email directly, view it on GitHub <#377 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXDLB6TCYRZXENTGTDUAJHDZHLZKVAVCNFSM6AAAAABJCDVGMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJYGQ3DOOJYGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[philknows]

Hi @AkshatGada , do you still plan to keep working on this?

[AkshatGada]

Yes , I am a little busy with college and my internship , I am running tests locally , please grant me some time to get it done .

[AkshatGada]

I am planning to do it as a project for the ethereum protocol fellowship.

[philknows]

Superseded by #400