Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[non-substantive] Clarify offsets serialization #62

Closed
ColinSchwarz opened this issue Sep 22, 2020 · 1 comment
Closed

[non-substantive] Clarify offsets serialization #62

ColinSchwarz opened this issue Sep 22, 2020 · 1 comment

Comments

@ColinSchwarz
Copy link

ethereum/consensus-specs#2043
@dapplion dapplion transferred this issue from ChainSafe/lodestar Sep 29, 2020
@dapplion
Copy link
Contributor

@wemeetagain Does this issue require any changes in our case? It just adds a uint32 casting

variable_offsets = [serialize(uint32(sum(fixed_lengths + variable_lengths[:i]))) for i in range(len(value))]

wemeetagain added a commit that referenced this issue Aug 26, 2021
@wemeetagain
Merge pull request #62 from ChainSafe/dependabot/npm_and_yarn/path-pa…
85d289c 
…rse-1.0.7

Bump path-parse from 1.0.6 to 1.0.7
wemeetagain pushed a commit that referenced this issue Aug 26, 2021
@twoeths
Implement setHashObjectFn (#62)
35bad6a 
* Implement setHashObjectFn

* Fix lint

* Add missing JSDoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dapplion @ColinSchwarz @philknows