Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataview based readwrite num bytes opts #176

Closed
wants to merge 1 commit into from
Closed

dataview based readwrite num bytes opts #176

wants to merge 1 commit into from

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Aug 30, 2021

This PR replaces the byte extract from uint number via native dataview, which is roughly 2x faster extraction than normal loop.
when plugged in it gives whopping 80% performace improvement over normal uint byte extraction and a marginal 3-5% improvement in the new uint64 tree backed datatype manipulation.

before:
image

after:
image

partially closes #143

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2021

CLA assistant check
All committers have signed the CLA.

@dapplion
Copy link
Contributor

dapplion commented Jan 20, 2022

Yeah DataView ops are so much faster than manual manipulation with currently do. All this optimizations are found in a similar form in #223 should we close this one in favor of #223 ?

@wemeetagain
Copy link
Member

@dapplion 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fast conversion from decimal to bytes
4 participants