Fix React warning with data attributes #1841
Conversation
|
Your Render PR Server URL is https://storage-ui-stage-pr-1841.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7atl6jvog4ifk3n7jgg. |
|
Your Render PR Server URL is https://chainsafe-components-stage-pr-1841.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7atl73vog4ifk3n7jt0. |
|
Your Render PR Server URL is https://files-ui-stage-pr-1841.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7atl7jvog4ifk3n7k1g. |
Tbaut
changed the title
| @@ -356,7 +356,7 @@ const Button: React.FC<IButtonProps> = ({ | |||
| )} | |||
| disabled={disabled || loading} | |||
| {...rest} | |||
| data-testId={`button-${testId}`} | |||
| data-testid={`button-${testId}`} | |||
There was a problem hiding this comment.
Should all the ${testId} references be updated too?
There was a problem hiding this comment.
no I think it's ok because that's a prop in a component that doesn't end up as an html attribute. The problem from the warning is that the prop was directly translated as html, and html attributes should not have camelCase
There was a problem hiding this comment.
Ah ok! Thanks for the explanation :)
Tbaut
added
Status: Review Needed 👀
Something I missed, thanks @tanmoyAtb: React doesn't like having camelCase for data attributes somehow.
So we'll have to live with
data-testidall lower case, still more consistent than before.