-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style the error boundaries component #1910
Conversation
Your Render PR Server URL is https://files-ui-stage-pr-1910.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7tashcobjdabj6mttsg. |
Your Render PR Server URL is https://storage-ui-stage-pr-1910.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7tashsobjdabj6mtue0. |
Your Render PR Server URL is https://chainsafe-components-stage-pr-1910.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7tasikobjdabj6mtuqg. |
I ran this branch locally and temporarily reverted Tanmoy's search fix to test this out. Looking good in both themes. The close button was not responding to my click action and I also noticed that after around 6 seconds of being displayed the styling for the error disappears and the unstyled error is displayed. Video below: Screen.Recording.2022-02-02.at.1.29.35.PM.mov |
What you see after some time is the react development error (which is still nice actually) because you run a dev server. This would not be shown in prod. or on render. The reason it is lagging is because this error is being prepared. Close it with the cross at the top right and you'll see the error boundaries component again, and the close button should then work. |
Sounds good 👍 thanks for the explanation. I wasn't sure what was happening there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested and closed the react development error, all is beautiful 🔥
Its amazing how the light and dark theme I'm not sure how useful the stack part of the modal would be. This is what I got on a local build version. @asnaith thanks for giving the idea on how to best test this PR :) |
Yeah, the stack can be useful, as well as useless, it'll really depend on the error itself! |
closes #41 ooooh that feels good!
I wasn't able to use
createStyle
, the app kept crashing, saying I wasn't able to useuseTheme
. so I did this all manually 🤷♂️.Edit: error boundaries are a weird kind of component based on old fashion classes where you can't use hooks basically https://blog.lookitskris.com/error-boundaries-hooks/
Submission checklist:
Layout
Theme